[kudu-CR] KUDU-1861 add range-partitioning of loadgen tables

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10633 ) Change subject: KUDU-1861 add range-partitioning of loadgen tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10453 ) Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. Patch Set 7: Code-Review+2 -- To view, visit http://gerr

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-06-06 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10453 to look at the new patch set (#7). Change subject: [rebalancing] Add a randomized rebalancing algorithm test ..

[kudu-CR] KUDU-1861 add range-partitioning of loadgen tables

2018-06-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10633 to look at the new patch set (#2). Change subject: KUDU-1861 add range-partitioning of loadgen tables .. KUDU-1861

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10453 ) Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. Patch Set 6: Code-Review+2 -- To view, visit http://gerr

[kudu-CR] KUDU-1861 add range-partitioning of loadgen tables

2018-06-06 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10633 Change subject: KUDU-1861 add range-partitioning of loadgen tables .. KUDU-1861 add range-partitioning of loadgen tables This patch adds

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-06-06 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10453 to look at the new patch set (#6). Change subject: [rebalancing] Add a randomized rebalancing algorithm test ..

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-06-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10453 ) Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10453 ) Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. Patch Set 5: Code-Review+2 -- To view, visit http://gerr

[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test

2018-06-06 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Mike Percy, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10453 to look at the new patch set (#5). Change subject: [rebalancing] Add a randomized rebalancing algorithm test

[kudu-CR] [util] fix compilation on OS X

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10632 ) Change subject: [util] fix compilation on OS X .. [util] fix compilation on OS X This is a follow-up for 8719014f2523671b33fde

[kudu-CR] [util] fix compilation on OS X

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10632 ) Change subject: [util] fix compilation on OS X .. Patch Set 1: Verified+1 Unrelated flake in MasterFailoverTest.TestMasterPermanentFai

[kudu-CR] [util] fix compilation on OS X

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10632 ) Change subject: [util] fix compilation on OS X .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu

[kudu-CR] [util] fix compilation on OS X

2018-06-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10632 ) Change subject: [util] fix compilation on OS X .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10632

[kudu-CR] [util] fix compilation on OS X

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10632 Change subject: [util] fix compilation on OS X .. [util] fix compilation on OS X This is a follow-up for 8719014f2523671b33fde92c110f21

[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10399 ) Change subject: [tools] rebalancer in the kudu CLI tool .. Removed reviewer Kudu Jenkins with the following votes: * Verified-

[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10399 ) Change subject: [tools] rebalancer in the kudu CLI tool .. Patch Set 23: Verified+1 Unrelated flake in OptionalSSL/TestRpc.TestClientC

[kudu-CR] [rebalancing] add a rebalancing algorithm

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] add a rebalancing algorithm .. [rebalancing] add a rebalancing algorithm This changelist introdu

[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-06-06 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10399 to look at the new patch set (#23). Change subject: [tools] rebalancer in the kudu CLI tool .. [tools]

[kudu-CR] [rebalancing] add a rebalancing algorithm

2018-06-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] add a rebalancing algorithm .. Patch Set 20: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [rebalancing] add a rebalancing algorithm

2018-06-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] add a rebalancing algorithm .. Patch Set 20: Code-Review+1 LGTM, not sure if Will wants to take another loo

[kudu-CR] [rebalancing] add a rebalancing algorithm

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] add a rebalancing algorithm .. Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/10336/19/

[kudu-CR] [rebalancing] add a rebalancing algorithm

2018-06-06 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10336 to look at the new patch set (#20). Change subject: [rebalancing] add a rebalancing algorithm ..

[kudu-CR] [rebalancing] add a rebalancing algorithm

2018-06-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] add a rebalancing algorithm .. Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/10336/18/src

[kudu-CR] [rebalancing] add a rebalancing algorithm

2018-06-06 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Mike Percy, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10336 to look at the new patch set (#19). Change subject: [rebalancing] add a rebalancing algorithm

[kudu-CR] [rebalancing] add a rebalancing algorithm

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] add a rebalancing algorithm .. Patch Set 18: (11 comments) Thank you for the review! http://gerrit.clo

[kudu-CR] KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any

2018-06-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10591 ) Change subject: KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any .. Patch Set 7: Overall looks good, ju

[kudu-CR] KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any

2018-06-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10591 ) Change subject: KUDU-1038 Deleting a tablet should also delete its log recovery directory, if any .. Patch Set 7: (23 comments) http://

[kudu-CR] [rebalancing] Add a rebalancing algorithm

2018-06-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. Patch Set 18: (11 comments) Looks good, I just have some small nits for fee

[kudu-CR] WIP: Kudu Backup/Restore Spark Jobs

2018-06-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10375 ) Change subject: WIP: Kudu Backup/Restore Spark Jobs .. Patch Set 12: (39 comments) http://gerrit.cloudera.org:8080/#/c/10375/12/java/kud

[kudu-CR] WIP: Kudu Backup/Restore Spark Jobs

2018-06-06 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10375 to look at the new patch set (#12). Change subject: WIP: Kudu Backup/Restore Spark Jobs ...

[kudu-CR] Fix flaky file cache-test

2018-06-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9900 ) Change subject: Fix flaky file_cache-test .. Fix flaky file_cache-test This test became flaky after 4db748f3021711a67017fe51f3009

[kudu-CR] Fix flaky file cache-test

2018-06-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9900 ) Change subject: Fix flaky file_cache-test .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9900 To unsubsc

[kudu-CR] KUDU-1865: Avoid some heap allocations in RPC paths

2018-06-06 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/8895 ) Change subject: KUDU-1865: Avoid some heap allocations in RPC paths .. Abandoned Not needed after the fix of IMPALA-5518 -- To view, visit http://ge

[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10399 ) Change subject: [tools] rebalancer in the kudu CLI tool .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/10399/20/src

[kudu-CR] [tools] add 'kudu tablet set attributes' sub-command

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10536 ) Change subject: [tools] add 'kudu tablet set_attributes' sub-command .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [tools] add 'kudu tablet set attributes' sub-command

2018-06-06 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10536 to look at the new patch set (#2). Change subject: [tools] add 'kudu tablet set_attributes' sub-command .

[kudu-CR] Fix ksck checksum scan printing

2018-06-06 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10535 to look at the new patch set (#6). Change subject: Fix ksck checksum_scan printing .. Fix ksck check

[kudu-CR] Fix ksck checksum scan printing

2018-06-06 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10535 ) Change subject: Fix ksck checksum_scan printing .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10535/5/src/kudu/tool

[kudu-CR] [tools] more integration tests for rebalancer

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10540 ) Change subject: [tools] more integration tests for rebalancer .. Patch Set 9: > Build Failed > > http://jenkins.kudu.apache.org/job/

[kudu-CR] [Java] Add Schema.getColumnById

2018-06-06 Thread Grant Henke (Code Review)
Grant Henke has abandoned this change. ( http://gerrit.cloudera.org:8080/10546 ) Change subject: [Java] Add Schema.getColumnById .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/10546 To unsubscribe, visit http://g

[kudu-CR] [java] Move some methods to a SparkUtil class

2018-06-06 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [java] Move some methods to a SparkUtil class .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10572 To unsubscribe, vis

[kudu-CR] [java] Move some methods to a SparkUtil class

2018-06-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10572 ) Change subject: [java] Move some methods to a SparkUtil class .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [java] Move some methods to a SparkUtil class

2018-06-06 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10572 ) Change subject: [java] Move some methods to a SparkUtil class .. [java] Move some methods to a SparkUtil class Moves some utilit

[kudu-CR] [rebalancing] Add a rebalancing algorithm

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. Removed reviewer Kudu Jenkins with the following votes: * Verifie

[kudu-CR] [rebalancing] Add a rebalancing algorithm

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: [rebalancing] Add a rebalancing algorithm .. Patch Set 18: Verified+1 unrelated flake in org.apache.kudu.client.TestAs

[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10399 ) Change subject: [tools] rebalancer in the kudu CLI tool .. Patch Set 22: Verified+1 unrelated flake in FileCacheTest/1.TestHeavyReads

[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10399 ) Change subject: [tools] rebalancer in the kudu CLI tool .. Removed reviewer Kudu Jenkins with the following votes: * Verified-

[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10399 ) Change subject: [tools] rebalancer in the kudu CLI tool .. Patch Set 22: (13 comments) http://gerrit.cloudera.org:8080/#/c/10399/20//

[kudu-CR] [tools] more integration tests for rebalancer

2018-06-06 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10540 to look at the new patch set (#9). Change subject: [tools] more integration tests for rebalancer ..

[kudu-CR] [tools] more integration tests for rebalancer

2018-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10540 ) Change subject: [tools] more integration tests for rebalancer .. Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/10540/

[kudu-CR] [rebalancer] 'auto' mode for RF=1 tablet movements

2018-06-06 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10612 to look at the new patch set (#2). Change subject: [rebalancer] 'auto' mode for RF=1 tablet movements .

[kudu-CR] [kudu CLI] more integration tests for rebalancer

2018-06-06 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10540 to look at the new patch set (#8). Change subject: [kudu CLI] more integration tests for rebalancer ...

[kudu-CR] [tools] rebalancer in the kudu CLI tool

2018-06-06 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10399 to look at the new patch set (#22). Change subject: [tools] rebalancer in the kudu CLI tool .