[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-14 Thread Anonymous Coward (Code Review)
jinxing6...@126.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/11333 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. Patch Set 9: Thanks for merging! Adar~ -- To view, visit ht

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11394 ) Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer .. Patch Set 4: (1 comment) http://gerrit.clouder

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-09-14 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11394 to look at the new patch set (#4). Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. Patch Set 3: (11 comments) http://gerrit.cloudera.org:808

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-09-14 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11395 to look at the new patch set (#4). Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator ...

[kudu-CR] KUDU-2463 pt 3: don't scan if MVCC hasn't moved

2018-09-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11428 ) Change subject: KUDU-2463 pt 3: don't scan if MVCC hasn't moved .. Patch Set 2: (7 comments) Looks good to me http://gerrit.cloudera.or

[kudu-CR] KUDU-2463 pt 2: adjust MVCC on Raft no-op

2018-09-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11427 ) Change subject: KUDU-2463 pt 2: adjust MVCC on Raft no-op .. Patch Set 2: Is there a scenario in which this change is necessary for corre

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11142 ) Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops .. Patch Set 6: (32 comments) Approach looks good, test looks good. Ho

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 8: Code-Review+2 LGTM, though would be good to get Mike o

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-09-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11394 ) Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer .. Patch Set 3: Code-Review+2 (1 comment) Changes

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-09-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. Patch Set 3: (11 comments) http://gerrit.cloudera.org:808

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11333 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. [KUDU-2521] Java Implementation for BloomFilter Change-Id: I32

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11333 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] Add a tool to dump master data in a readable format

2018-09-14 Thread Fengling Wang (Code Review)
Fengling Wang has abandoned this change. ( http://gerrit.cloudera.org:8080/10697 ) Change subject: Add a tool to dump master data in a readable format .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/10697 To unsu

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-14 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11142 to look at the new patch set (#6). Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops ..