[kudu-CR] Add thrift module for common thrift utilities

2018-09-21 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11493 ) Change subject: Add thrift module for common thrift utilities .. Add thrift module for common thrift utilities The HMS patch

[kudu-CR] Add thrift module for common thrift utilities

2018-09-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11493 ) Change subject: Add thrift module for common thrift utilities .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] hybrid clock: restore SleepFor in WaitUntilAfterLocally

2018-09-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11495 ) Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally .. Patch Set 1: Code-Review+2 LGTM, but would be nice to get a

[kudu-CR] Add thrift module for common thrift utilities

2018-09-21 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11493 to look at the new patch set (#3). Change subject: Add thrift module for common thrift utilities

[kudu-CR] Add thrift module for common thrift utilities

2018-09-21 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11493 ) Change subject: Add thrift module for common thrift utilities .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-21 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] hybrid clock: restore SleepFor in WaitUntilAfterLocally

2018-09-21 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11495 to review the following change. Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally

[kudu-CR] Add thrift module for common thrift utilities

2018-09-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11493 ) Change subject: Add thrift module for common thrift utilities .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] Add thrift module for common thrift utilities

2018-09-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11493 ) Change subject: Add thrift module for common thrift utilities .. Patch Set 2: As a reminder, this thrift code doesn't contain any unit

[kudu-CR] Add thrift module for common thrift utilities

2018-09-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11493 ) Change subject: Add thrift module for common thrift utilities .. Patch Set 2: (3 comments)

[kudu-CR] Add thrift module for common thrift utilities

2018-09-21 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11493 to look at the new patch set (#2). Change subject: Add thrift module for common thrift utilities

[kudu-CR] Add thrift module for common thrift utilities

2018-09-21 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11493 to review the following change. Change subject: Add thrift module for common thrift utilities .. Add thrift

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 10: (5 comments)

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#10). Change subject: KUDU-2245 Graceful leadership transfer

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#9). Change subject: KUDU-2245 Graceful leadership transfer

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 8: I think this uncovered a bug in CheckCompleteMove that was

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-21 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11142 ) Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops .. KUDU-2463 pt 1: adjust MVCC when replaying no-ops

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11142 ) Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11142 ) Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops .. Patch Set 10: (1 comment)

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-21 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11142 to look at the new patch set (#10). Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11142 ) Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops .. Patch Set 9: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#8). Change subject: KUDU-2245 Graceful leadership transfer

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-21 Thread Dan Burkert (Code Review)
Hello Andrew Wong, Kudu Jenkins, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11413 to look at the new patch set (#5). Change subject: HMS integration: provide Java API to override owner during table create

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 7: (30 comments)

[kudu-CR] [test] Adjust Kudu binary locator logic.

2018-09-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11475 ) Change subject: [test] Adjust Kudu binary locator logic. .. [test] Adjust Kudu binary locator logic. This patch adjusts the

[kudu-CR] [test] Adjust Kudu binary locator logic.

2018-09-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11475 ) Change subject: [test] Adjust Kudu binary locator logic. .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2463 pt 3: don't scan if MVCC hasn't moved

2018-09-21 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11428 to look at the new patch set (#10). Change subject: KUDU-2463 pt 3: don't scan if MVCC hasn't moved

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 4: (7 comments)

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-21 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11488 to look at the new patch set (#4). Change subject: [tools] ksck checksums: Factor out of main ksck code

[kudu-CR] [test] Clean up MiniKuduCluster and BaseKuduTest

2018-09-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11474 ) Change subject: [test] Clean up MiniKuduCluster and BaseKuduTest .. [test] Clean up MiniKuduCluster and BaseKuduTest This patch

[kudu-CR] [tools] ksck checksums: Factor out of main ksck code

2018-09-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 ) Change subject: [tools] ksck checksums: Factor out of main ksck code .. Patch Set 3: (7 comments)