[kudu-CR] client: avoid KLOG EVERY N SECS with ScopedCleanup

2019-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12170 Change subject: client: avoid KLOG_EVERY_N_SECS with ScopedCleanup .. client: avoid KLOG_EVERY_N_SECS with ScopedCleanup I saw a failure

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-01-07 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12122 to look at the new patch set (#4). Change subject: KUDU-2543 pt 2: pass around default authz tokens ..

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 4: (35 comments) http://gerrit.cloudera.org:8080/#/c/1212

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-01-07 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12122 to look at the new patch set (#5). Change subject: KUDU-2543 pt 2: pass around default authz tokens ..

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

2019-01-07 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11751 to look at the new patch set (#10). Change subject: KUDU-2543 pt 1: basic checks for authz tokens

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

2019-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 ) Change subject: KUDU-2543 pt 1: basic checks for authz tokens .. Patch Set 10: (21 comments) http://gerrit.cloudera.org:8080/#/c/11751/

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-07 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12121/4/src/ku

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-07 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12121 to look at the new patch set (#5). Change subject: [fs]: wrapping up containers in scoped_refptr .

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-07 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#10). Change subject: KUDU-2636: LBM supports deleting dead and full containers ...

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 ) Change subject: KUDU-2543 pt 1: basic checks for authz tokens .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] client: avoid KLOG EVERY N SECS with ScopedCleanup

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 ) Change subject: client: avoid KLOG_EVERY_N_SECS with ScopedCleanup .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12170

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:80

[kudu-CR] Support CXXFLAGS

2019-01-07 Thread Tim Armstrong (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12162 to look at the new patch set (#3). Change subject: Support CXXFLAGS .. Support CXXFLAGS I ran into a c

[kudu-CR] Support CXXFLAGS

2019-01-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12162 ) Change subject: Support CXXFLAGS .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12162/1/CMakeLists.txt File CMakeLi

[kudu-CR] client: avoid KLOG EVERY N SECS with ScopedCleanup

2019-01-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 ) Change subject: client: avoid KLOG_EVERY_N_SECS with ScopedCleanup .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/1217

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-07 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12138 to look at the new patch set (#4). Change subject: Support location awareness in READ_CLOSEST for the C++ client .

[kudu-CR] Rename ts location assignment-itest to location assignment-itest

2019-01-07 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12161 ) Change subject: Rename ts_location_assignment-itest to location_assignment-itest .. Rename ts_location_assignment-itest to loca

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-07 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12138 to look at the new patch set (#5). Change subject: Support location awareness in READ_CLOSEST for the C++ client .

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 5: (4 comments) http://gerrit.cloudera.org

[kudu-CR] client: avoid KLOG EVERY N SECS with ScopedCleanup

2019-01-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 ) Change subject: client: avoid KLOG_EVERY_N_SECS with ScopedCleanup .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/121

[kudu-CR] [docs] add Hive Metastore integration

2019-01-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11798

[kudu-CR] WIP: Add an intial docker integration

2019-01-07 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12173 Change subject: WIP: Add an intial docker integration .. WIP: Add an intial docker integration This patch adds an initial Docker file whi

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-07 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12138 to look at the new patch set (#6). Change subject: Support location awareness in READ_CLOSEST for the C++ client .

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 10: > Something's not quite right with this patch;

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 5: Code-Review+2 (1 comment) Looks good, though I'd still lik

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-07 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12174 Change subject: Assign locations to tablet servers and the client in Java .. Assign locations to tablet servers and the client in Java

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-07 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12138 to look at the new patch set (#7). Change subject: Support location awareness in READ_CLOSEST for the C++ client .

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 7: Verified+1 Unrelated flake. -- To view

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-07 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Removed reviewer Kudu Jenkins with the followi

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

2019-01-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 ) Change subject: KUDU-2543 pt 1: basic checks for authz tokens .. Patch Set 10: (3 comments) LGTM, just minor nits. http://gerrit.cloudera.

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-07 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12175 Change subject: Support location awareness in READ_CLOSEST for the Java client .. Support location awareness in READ_CLOSEST for the Jav

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-07 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12175 to look at the new patch set (#2). Change subject: Support location awareness in READ_CLOSEST for the Java client ..

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-07 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12174 to look at the new patch set (#3). Change subject: Assign locations to tablet servers and the client in Java ...

[kudu-CR] tablet: clean up MergeIterState API

2019-01-07 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12176 to review the following change. Change subject: tablet: clean up MergeIterState API .. tablet: clean up MergeIterState

[kudu-CR] tablet: clean up MergeIterState API

2019-01-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12176 to look at the new patch set (#2). Change subject: tablet: clean up MergeIterState API .. tablet: clean

[kudu-CR] tablet: clean up MergeIterState API

2019-01-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12176 to look at the new patch set (#3). Change subject: tablet: clean up MergeIterState API .. tablet: clean

[kudu-CR] tablet: clean up MergeIterState API

2019-01-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12176 ) Change subject: tablet: clean up MergeIterState API .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12176/2/src/kudu/co

[kudu-CR] [tools] Add table scan tool

2019-01-07 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#3). Change subject: [tools] Add table scan tool .. [tools] Add table

[kudu-CR] tablet: clean up MergeIterState API

2019-01-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12176 ) Change subject: tablet: clean up MergeIterState API .. Patch Set 3: Overriding Jenkins; the failures were due to two known flakies: KUDU-

[kudu-CR] tablet: clean up MergeIterState API

2019-01-07 Thread Mike Percy (Code Review)
Mike Percy has removed a vote on this change. Change subject: tablet: clean up MergeIterState API .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12176 To unsubscribe, visit http://g

[kudu-CR] tablet: clean up MergeIterState API

2019-01-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12176 ) Change subject: tablet: clean up MergeIterState API .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12176 T

[kudu-CR] [tools] Add table scan tool

2019-01-07 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#4). Change subject: [tools] Add table scan tool .. [tools] Add table

[kudu-CR] Support CXXFLAGS

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12162 ) Change subject: Support CXXFLAGS .. Support CXXFLAGS I ran into a case when building Kudu in native-toolchain where I want to bui

[kudu-CR] Support CXXFLAGS

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12162 ) Change subject: Support CXXFLAGS .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12162 To unsubscribe, v

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8

[kudu-CR] WIP: Add an intial docker integration

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12173 ) Change subject: WIP: Add an intial docker integration .. Patch Set 1: Verified+1 Overriding Jenkins, the failure had nothing to do with t

[kudu-CR] WIP: Add an intial docker integration

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: WIP: Add an intial docker integration .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12173 To unsubscribe, visit http:/

[kudu-CR] WIP: Add an intial docker integration

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12173 ) Change subject: WIP: Add an intial docker integration .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12173/1//COMMIT_MS

[kudu-CR] WIP: Add an intial docker integration

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12173 ) Change subject: WIP: Add an intial docker integration .. Patch Set 1: (9 comments) Neat stuff! http://gerrit.cloudera.org:8080/#/c/1217

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 7: (6 comments) http://gerrit.cloudera.org