[kudu-CR] generic iterators: assorted cleanup

2019-01-08 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12156 to look at the new patch set (#3). Change subject: generic_iterators: assorted cleanup .. generic_itera

[kudu-CR] generic iterators: assorted cleanup

2019-01-08 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12156 to look at the new patch set (#2). Change subject: generic_iterators: assorted cleanup .. generic_itera

[kudu-CR] generic iterators: short-circuit MergeIterState::PullNextBlock

2019-01-08 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12157 to look at the new patch set (#2). Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock ..

[kudu-CR] tablet: clean up MergeIterState API

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12176 ) Change subject: tablet: clean up MergeIterState API .. tablet: clean up MergeIterState API This patch simply adds documentation a

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Patch Set 3: Code-Review+2 (1 comment) http://gerri

[kudu-CR] KUDU-2195. Add additional gflag to force sync of consensus metadata

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12186 ) Change subject: KUDU-2195. Add additional gflag to force sync of consensus metadata .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 8: Code-Review+2 -- To view, visit http://

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 ) Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-01-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 5: (12 comments) http://gerrit.cloudera.org:8080/#/c/12122/5/

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 6: > Here is a tserver node of our online cluster, and it has

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. [fs]: wrapping up containers in scoped_refptr It's necessary to

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 6: Here is a tserver node of our online cluster, and it has been r

[kudu-CR] KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks

2019-01-08 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12166 ) Change subject: KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks .. KUDU-2652: deflake TsRecoveryITest.TestN

[kudu-CR] KUDU-2195. Add additional gflag to force sync of consensus metadata

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12186 ) Change subject: KUDU-2195. Add additional gflag to force sync of consensus metadata .. Patch Set 1: Code-Review+2 Seems harmless enough.

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 11: (3 comments) > And here are another three com

[kudu-CR] tablet: clean up MergeIterState API

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12176 ) Change subject: tablet: clean up MergeIterState API .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1217

[kudu-CR] rpc: add TCP socket statistics to /rpcz

2019-01-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 ) Change subject: rpc: add TCP socket statistics to /rpcz .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12184/1/src/kud

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 11: (3 comments) Thank you very much :) And here are

[kudu-CR] Reduce severity of "Error trying to read ahead of the log" log message

2019-01-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12185 ) Change subject: Reduce severity of "Error trying to read ahead of the log" log message .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] tablet: clean up MergeIterState API

2019-01-08 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12176 to look at the new patch set (#4). Change subject: tablet: clean up MergeIterState API .. tablet: clean

[kudu-CR] tablet: clean up MergeIterState API

2019-01-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12176 ) Change subject: tablet: clean up MergeIterState API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12176/3/src/kudu/com

[kudu-CR] KUDU-2195. Add additional gflag to force sync of consensus metadata

2019-01-08 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12186 to review the following change. Change subject: KUDU-2195. Add additional gflag to force sync of consensus metadata ..

[kudu-CR] KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks

2019-01-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12166 ) Change subject: KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks .. Patch Set 2: Code-Review+2 -- To view, visit ht

[kudu-CR] [gutil] suppress -Wdeprecated-declarations warning on macOS

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12183 ) Change subject: [gutil] suppress -Wdeprecated-declarations warning on macOS .. [gutil] suppress -Wdeprecated-declarations warni

[kudu-CR] KUDU-2195 (part 1): always sync PBC-format metadata files

2019-01-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9043 ) Change subject: KUDU-2195 (part 1): always sync PBC-format metadata files .. Patch Set 1: This was recently seen in the wild again. Usuall

[kudu-CR] KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12166 ) Change subject: KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks .. Patch Set 2: Code-Review+2 -- To view, visit ht

[kudu-CR] [gutil] suppress -Wdeprecated-declarations warning on macOS

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12183 ) Change subject: [gutil] suppress -Wdeprecated-declarations warning on macOS .. Patch Set 3: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] [gutil] suppress -Wdeprecated-declarations warning on macOS

2019-01-08 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12183 to look at the new patch set (#3). Change subject: [gutil] suppress -Wdeprecated-declarations warning on macOS

[kudu-CR] Reduce severity of "Error trying to read ahead of the log" log message

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12185 ) Change subject: Reduce severity of "Error trying to read ahead of the log" log message .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12183 ) Change subject: [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12 .. Patch Set 2: Code-Review+2 Confirmed it eliminates the

[kudu-CR] [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12

2019-01-08 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12183 to look at the new patch set (#2). Change subject: [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12 ...

[kudu-CR] Reduce severity of "Error trying to read ahead of the log" log message

2019-01-08 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12185 to look at the new patch set (#2). Change subject: Reduce severity of "Error trying to read ahead of the log" log message .

[kudu-CR] Reduce severity of "Error trying to read ahead of the log" log message

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12185 Change subject: Reduce severity of "Error trying to read ahead of the log" log message .. Reduce severity of "Error trying to read ahea

[kudu-CR] KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks

2019-01-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12166 ) Change subject: KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks .. Patch Set 2: (2 comments) http://gerrit.cloude

[kudu-CR] KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks

2019-01-08 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12166 to look at the new patch set (#2). Change subject: KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks ...

[kudu-CR] KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks

2019-01-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12166 ) Change subject: KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks .. Patch Set 1: (1 comment) http://gerrit.cloudera

[kudu-CR] KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks

2019-01-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12166 ) Change subject: KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks .. Patch Set 1: (1 comment) http://gerrit.cloudera

[kudu-CR] rpc: add TCP socket statistics to /rpcz

2019-01-08 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12184 to review the following change. Change subject: rpc: add TCP socket statistics to /rpcz .. rpc: add TCP

[kudu-CR] [test] dos2unix for rowset tree-test

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12182 ) Change subject: [test] dos2unix for rowset_tree-test .. [test] dos2unix for rowset_tree-test This patch converts DOS-style lin

[kudu-CR] [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12183 ) Change subject: [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerr

[kudu-CR] [test] dos2unix for rowset tree-test

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12182 ) Change subject: [test] dos2unix for rowset_tree-test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/121

[kudu-CR] [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12183 Change subject: [gutil] suppress -Wdeprecated-declarations on macOS >= 10.12 .. [gutil] suppress -Wdeprecated-declarations on macOS >= 1

[kudu-CR] [tools] Add table scan tool

2019-01-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12167/4/src/kudu/tools/tool

[kudu-CR] [test] dos2unix for rowset tree-test

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12182 Change subject: [test] dos2unix for rowset_tree-test .. [test] dos2unix for rowset_tree-test This patch converts DOS-style line breaks

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 ) Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12178 to look at the new patch set (#4). Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder .

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12178 to look at the new patch set (#3). Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder .

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 ) Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/12178/

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 2: (21 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [tools] Add table scan tool

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 4: (5 comments) I left a few high-level comments, but at the top level: what

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 11: I pushed a new revision with a few cleanups: -

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#11) to the change originally created by helifu. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. KUDU-2636: LBM supp

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#6) to the change originally created by helifu. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. [fs]: wrapping up containers in

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12180 ) Change subject: Fix DOS line endings in TestServerInfo.java .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12180 ) Change subject: Fix DOS line endings in TestServerInfo.java .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12180 ) Change subject: Fix DOS line endings in TestServerInfo.java .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12180/1/j

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12180 ) Change subject: Fix DOS line endings in TestServerInfo.java .. Patch Set 1: (1 comment) Maybe http://gerrit.cloudera.org:8080/#/c/12180

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloude

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Patch Set 3: Code-Review+1 -- To view, visit http://ge

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 8: Code-Review+1 -- To view, visit http://ger

[kudu-CR] KUDU-2348: In the Java client, pick a random replica when no replica is local

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12158 ) Change subject: KUDU-2348: In the Java client, pick a random replica when no replica is local .. Patch Set 8: My bad, had the wrong l

[kudu-CR] KUDU-2348: In the Java client, pick a random replica when no replica is local

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12158 ) Change subject: KUDU-2348: In the Java client, pick a random replica when no replica is local .. Patch Set 8: You might also want to

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-08 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12138 to look at the new patch set (#8). Change subject: Support location awareness in READ_CLOSEST for the C++ client

[kudu-CR] Fix DOS line endings in TestServerInfo.java

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12180 Change subject: Fix DOS line endings in TestServerInfo.java .. Fix DOS line endings in TestServerInfo.java Change-Id: Id0c470ed24238e04

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-08 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12174 to look at the new patch set (#4). Change subject: Assign locations to tablet servers and the client in Java ...

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-08 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12175 to look at the new patch set (#3). Change subject: Support location awareness in READ_CLOSEST for the Java client ..

[kudu-CR] Support location awareness in READ CLOSEST for the Java client

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 ) Change subject: Support location awareness in READ_CLOSEST for the Java client .. Patch Set 2: (4 comments) http://gerrit.cloudera.or

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:80

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 7: (7 comments) http://gerrit.cloudera.org

[kudu-CR] tablet: clean up MergeIterState API

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12176 ) Change subject: tablet: clean up MergeIterState API .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12176/

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 ) Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder .. Patch Set 2: Code-Review+1 Nothing to add to Alexey's comments. -- T

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 ) Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder .. Patch Set 2: (4 comments) A few nits http://gerrit.cloudera.org:8

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12178 To unsubscribe, vi

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 ) Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder .. Patch Set 2: Verified+1 The failure seems unrelated: RaftConsensusN

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12178 To unsubscribe, v

[kudu-CR] Assign locations to tablet servers and the client in Java

2019-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 ) Change subject: Assign locations to tablet servers and the client in Java .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:808

[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12178 to look at the new patch set (#2). Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder

[kudu-CR] KUDU-2565: pass IOContext to ValidateDeltaOrder

2019-01-08 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12178 to review the following change. Change subject: KUDU-2565: pass IOContext to ValidateDeltaOrder .. KUDU-2