[kudu-CR] docs: KUDU-2411: Document the binary test jar

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 ) Change subject: docs: KUDU-2411: Document the binary test jar .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/12685/1/d

[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 ) Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:

[kudu-CR] docs: KUDU-2411: Document the binary test jar

2019-03-06 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12685 to look at the new patch set (#3). Change subject: docs: KUDU-2411: Document the binary test jar .

[kudu-CR](branch-1.9.x) add release notes for 1.9.0

2019-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: add release notes for 1.9.0 .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12389/5/docs/release_notes.

[kudu-CR](branch-1.9.x) add release notes for 1.9.0

2019-03-06 Thread Andrew Wong (Code Review)
Hello Will Berkeley, Alexey Serbin, Mike Percy, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Hao Hao, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12389 to look at the new patch set (#6). Change subject: add release notes for 1.9.0 .

[kudu-CR](branch-1.9.x) add release notes for 1.9.0

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: add release notes for 1.9.0 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12389/5/docs/release_notes.a

[kudu-CR] tools: fix output on 'kudu table scan' to add proper locking

2019-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12617 ) Change subject: tools: fix output on 'kudu table scan' to add proper locking .. tools: fix output on 'kudu table scan' to add prop

[kudu-CR] docs: KUDU-2411: Document the binary test jar

2019-03-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 ) Change subject: docs: KUDU-2411: Document the binary test jar .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12685/1/

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12657 ) Change subject: KUDU-2721: support ranges in CPU lists .. KUDU-2721: support ranges in CPU lists Generalise the logic to handle

[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue

2019-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 ) Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue .. Patch Set 2: (1 comment) FWIW I've +2'ed Yingchun's

[kudu-CR] docs: KUDU-2411: Document the binary test jar

2019-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 ) Change subject: docs: KUDU-2411: Document the binary test jar .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/12685/2/d

[kudu-CR] docs: KUDU-2411: Document the binary test jar

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 ) Change subject: docs: KUDU-2411: Document the binary test jar .. Patch Set 2: updated the rendering as well -- To view, visit http://ge

[kudu-CR] docs: KUDU-2411: Document the binary test jar

2019-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 ) Change subject: docs: KUDU-2411: Document the binary test jar .. Patch Set 2: Code-Review+2 Sweet, thanks! I'll leave this open for a bi

[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue

2019-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 ) Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue .. Patch Set 1: (2 comments) http://gerrit.cloudera.or

[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue

2019-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 ) Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue .. Patch Set 2: Code-Review+2 -- To view, visit http:/

[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 ) Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue .. Patch Set 1: (2 comments) http://gerrit.cloudera.org

[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 ) Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue .. Patch Set 2: updated rendering -- To view, visit ht

[kudu-CR] docs: KUDU-2411: Document the binary test jar

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 ) Change subject: docs: KUDU-2411: Document the binary test jar .. Patch Set 2: Thanks for the quick review! -- To view, visit http://ger

[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue

2019-03-06 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12686 to look at the new patch set (#2). Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue ...

[kudu-CR] docs: KUDU-2411: Document the binary test jar

2019-03-06 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12685 to look at the new patch set (#2). Change subject: docs: KUDU-2411: Document the binary test jar .

[kudu-CR] docs: KUDU-2411: document the binary test jar

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 ) Change subject: docs: KUDU-2411: document the binary test jar .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12685/1/do

[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 ) Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue .. Patch Set 1: Rendering at https://github.com/mpercy/

[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue

2019-03-06 Thread Mike Percy (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12686 to review the following change. Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue .. d

[kudu-CR] docs: KUDU-2411: document the binary test jar

2019-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 ) Change subject: docs: KUDU-2411: document the binary test jar .. Patch Set 1: Code-Review+1 (1 comment) Looks good! http://gerrit.clou

[kudu-CR] docs: KUDU-2411: document the binary test jar

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12685 ) Change subject: docs: KUDU-2411: document the binary test jar .. Patch Set 1: Rendered docs here: https://github.com/mpercy/kudu/blob/bi

[kudu-CR] docs: KUDU-2411: document the binary test jar

2019-03-06 Thread Mike Percy (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12685 to review the following change. Change subject: docs: KUDU-2411: document the binary test jar .. docs: K

[kudu-CR] KUDU-2721: support ranges in CPU lists

2019-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12657 ) Change subject: KUDU-2721: support ranges in CPU lists .. Patch Set 10: Are you ok with me submitting? -- To view, visit http://gerr

[kudu-CR] [tools] Support running the master and tablet server via the kudu binary

2019-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 ) Change subject: [tools] Support running the master and tablet server via the kudu binary .. Patch Set 18: -Verified Whoops, didn't mean

[kudu-CR] [master] introduce TTL-based cache

2019-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12652 ) Change subject: [master] introduce TTL-based cache .. Patch Set 1: > Yep, I took a look at that cache prior starting working on this one.

[kudu-CR] [tools] Support running the master and tablet server via the kudu binary

2019-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 ) Change subject: [tools] Support running the master and tablet server via the kudu binary .. Patch Set 18: Verified-1 Code-Review+1 Looks

[kudu-CR] KUDU-2705: Add timing information to /scans

2019-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12604 ) Change subject: KUDU-2705: Add timing information to /scans .. Patch Set 5: Verified+1 Code-Review+2 Failures were KUDU-1736 and KUDU-27

[kudu-CR] KUDU-2705: Add timing information to /scans

2019-03-06 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2705: Add timing information to /scans .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12604 To unsubscribe, visit

[kudu-CR] [master] introduce TTL-based cache

2019-03-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12652 ) Change subject: [master] introduce TTL-based cache .. Patch Set 1: > Did you look into augmenting the existing generic cache code in

[kudu-CR] [tools] Support running the master and tablet server via the kudu binary

2019-03-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 ) Change subject: [tools] Support running the master and tablet server via the kudu binary .. Patch Set 15: (1 comment) http://gerrit.cl

[kudu-CR] [tools] Support running the master and tablet server via the kudu binary

2019-03-06 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12517 to look at the new patch set (#18). Change subject: [tools] Support running the master and tablet server via the kudu b

[kudu-CR] KUDU-2711 (part 1): add a benchmark for GetTableLocations

2019-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12613 ) Change subject: KUDU-2711 (part 1): add a benchmark for GetTableLocations .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] [thirdparty] Bump RapidJSON version to 1.1.0

2019-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12643 ) Change subject: [thirdparty] Bump RapidJSON version to 1.1.0 .. Patch Set 8: Code-Review+2 Mike/Todd, do either of you want to take anoth

[kudu-CR] [thirdparty] Bump RapidJSON version to 1.1.0

2019-03-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12643 ) Change subject: [thirdparty] Bump RapidJSON version to 1.1.0 .. Patch Set 8: > So we should bisect the repo and figure out which post-1

[kudu-CR] [thirdparty] Bump RapidJSON version to 1.1.0

2019-03-06 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12643 to look at the new patch set (#8). Change subject: [thirdparty] Bump RapidJSON version to 1.1.0 .

[kudu-CR] [thirdparty] Bump RapidJSON version to 1.1.0

2019-03-06 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12643 to look at the new patch set (#7). Change subject: [thirdparty] Bump RapidJSON version to 1.1.0 .

[kudu-CR] [thirdparty] Bump RapidJSON version to 1.1.0

2019-03-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12643 ) Change subject: [thirdparty] Bump RapidJSON version to 1.1.0 .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/12643/6/

[kudu-CR](branch-1.9.x) [docs] Remove outdated package and quickstart references

2019-03-06 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12664 ) Change subject: [docs] Remove outdated package and quickstart references .. [docs] Remove outdated package and quickstart referen

[kudu-CR] [docs] Fix table name in Impala docs

2019-03-06 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12534 ) Change subject: [docs] Fix table name in Impala docs .. [docs] Fix table name in Impala docs Change-Id: I39866cfc810731e26592dd

[kudu-CR] KUDU-1291: efficiently support predicates on non-prefix key components

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#22) to the change originally created by Anupama Gupta. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: KUDU-1291: efficiently support predicates on non-prefix key components ..

[kudu-CR] [master] introduce TTL-based cache

2019-03-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12652 ) Change subject: [master] introduce TTL-based cache .. Patch Set 1: Did you look into augmenting the existing generic cache code in util/

[kudu-CR] KUDU-1291: efficiently support predicates on non-prefix key components

2019-03-06 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#21) to the change originally created by Anupama Gupta. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: KUDU-1291: efficiently support predicates on non-prefix key components ..