[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-19 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13976 ) Change subject: [tools] Add table tools to delete column and alter column .. [tools] Add table tools to delete column and alter c

[kudu-CR] small cleanup: remove unnecessary semicolons (part 2)

2019-08-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14095 ) Change subject: small cleanup: remove unnecessary semicolons (part 2) .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [docs] Fix an outdated slow DNS log description

2019-08-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14105 Change subject: [docs] Fix an outdated slow DNS log description .. [docs] Fix an outdated slow DNS log description Slow DNS log format h

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14086 ) Change subject: [compression] Refactor unit tests and add simple benchmark test .. [compression] Refactor unit tests and add si

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 ) Change subject: [compression] Refactor unit tests and add simple benchmark test .. Patch Set 5: Verified+1 unrelated flake in MultiThr

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [compression] Refactor unit tests and add simple benchmark test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14086

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 ) Change subject: [compression] Refactor unit tests and add simple benchmark test .. Patch Set 5: Code-Review+2 (2 comments) http://ger

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14086 to look at the new patch set (#5). Change subject: [compression] Refactor unit tests and add simple benchmark test ..

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 ) Change subject: [compression] Refactor unit tests and add simple benchmark test .. Patch Set 4: (3 comments) http://gerrit.cloudera.or

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 ) Change subject: [tools] Add table tools to delete column and alter column .. Patch Set 12: Code-Review+1 -- To view, visit http://gerr

[kudu-CR] small cleanup: remove unnecessary semicolons (part 2)

2019-08-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14095 to look at the new patch set (#2). Change subject: small cleanup: remove unnecessary semicolons (part 2) ...

[kudu-CR] small cleanup: remove unnecessary semicolons (part 2)

2019-08-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14095 ) Change subject: small cleanup: remove unnecessary semicolons (part 2) .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 ) Change subject: [tools] Add table tools to delete column and alter column .. Patch Set 12: Code-Review+2 (1 comment) http://gerrit.clou

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 ) Change subject: [tools] Add table tools to delete column and alter column .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit

[kudu-CR] small cleanup: remove unnecessary semicolons (part 2)

2019-08-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14095 ) Change subject: small cleanup: remove unnecessary semicolons (part 2) .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 ) Change subject: [compression] Refactor unit tests and add simple benchmark test .. Patch Set 4: Code-Review+1 (1 comment) Will defer to

[kudu-CR] KUDU-1938 Add support for CHAR/VARCHAR pt 1

2019-08-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 ) Change subject: KUDU-1938 Add support for CHAR/VARCHAR pt 1 .. Patch Set 26: (10 comments) http://gerrit.cloudera.org:8080/#/c/13760/

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 ) Change subject: [compression] Refactor unit tests and add simple benchmark test .. Patch Set 4: (3 comments) http://gerrit.cloudera.o

[kudu-CR] small cleanup: remove unnecessary semicolons (part 2)

2019-08-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14095 Change subject: small cleanup: remove unnecessary semicolons (part 2) .. small cleanup: remove unnecessary semicolons (part 2) Removed

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 ) Change subject: [compression] Refactor unit tests and add simple benchmark test .. Patch Set 4: (7 comments) http://gerrit.cloudera.or

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14086 to look at the new patch set (#4). Change subject: [compression] Refactor unit tests and add simple benchmark test .

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14086 to look at the new patch set (#3). Change subject: [compression] Refactor unit tests and add simple benchmark test .

[kudu-CR] [compression] Refactor unit tests and add simple benchmark test

2019-08-19 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14086 to look at the new patch set (#2). Change subject: [compression] Refactor unit tests and add simple benchmark test .

[kudu-CR] [test] handle ScanTableToStrings() result status

2019-08-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/11825 ) Change subject: [test] handle ScanTableToStrings() result status .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/1182

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-19 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-19 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 ) Change subject: [tools] Add table tools to delete column and alter column .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-19 Thread Yifan Zhang (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13976 to look at the new patch set (#12). Change subject: [tools] Add table tools to delete column and alter column .

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-19 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 ) Change subject: [tools] Add table tools to delete column and alter column .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 ) Change subject: [tools] Add table tools to delete column and alter column .. Patch Set 11: Code-Review+1 -- To view, visit http://gerr