[kudu-CR] env: add a fifo class

2020-03-28 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15584 to look at the new patch set (#3). Change subject: env: add a fifo class .. env: add a fifo class This a

[kudu-CR] [build-support] introduce PARALLEL variable

2020-03-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15591 Change subject: [build-support] introduce PARALLEL variable .. [build-support] introduce PARALLEL variable This patch introduces PARALL

[kudu-CR] tracing: remove kudu::Bind usage from various callbacks

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15580 to look at the new patch set (#2). Change subject: tracing: remove kudu::Bind usage from various callbacks .

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15583 to look at the new patch set (#2). Change subject: gutil: remove callback and bind from the codebase ...

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15582 to look at the new patch set (#2). Change subject: consensus: remove kudu::Bind usage from dirty callbacks .

[kudu-CR] fs: remove kudu::Bind usage from DataDir closures

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15581 to look at the new patch set (#2). Change subject: fs: remove kudu::Bind usage from DataDir closures ...

[kudu-CR] gutil: remove BASE EXPORT

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15576 to look at the new patch set (#2). Change subject: gutil: remove BASE_EXPORT .. gutil:

[kudu-CR] subprocess: use a fifo instead of stdout for IO

2020-03-28 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15574 to look at the new patch set (#5). Change subject: subprocess: use a fifo instead of stdout for IO ...

[kudu-CR] subprocess: use a fifo instead of stdout for IO

2020-03-28 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15574 to look at the new patch set (#4). Change subject: subprocess: use a fifo instead of stdout for IO ...

[kudu-CR] env: add a fifo class

2020-03-28 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15584 to look at the new patch set (#2). Change subject: env: add a fifo class .. env: add a fifo class This a

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 ) Change subject: [ranger] add more comments for Ranger privilege model .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] env: add a fifo class

2020-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15584 Change subject: env: add a fifo class .. env: add a fifo class This adds a basic Fifo class that encapsulates the usage of mkfifo and ass

[kudu-CR] subprocess: use a fifo instead of stdout for IO

2020-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15574 ) Change subject: subprocess: use a fifo instead of stdout for IO .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/15574/

[kudu-CR] subprocess: use a fifo instead of stdout for IO

2020-03-28 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15574 to look at the new patch set (#3). Change subject: subprocess: use a fifo instead of stdout for IO ...

[kudu-CR] gutil: remove BASE EXPORT

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15576 to review the following change. Change subject: gutil: remove BASE_EXPORT .. gutil: remove BASE_EXPORT

[kudu-CR] fs: remove kudu::Bind usage from ErrorManager

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15579 to review the following change. Change subject: fs: remove kudu::Bind usage from ErrorManager .. fs: r

[kudu-CR] logging: remove kudu::Bind usage from LoggingCallback

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15577 to review the following change. Change subject: logging: remove kudu::Bind usage from LoggingCallback .

[kudu-CR] consensus: remove kudu::Bind usage from dirty callbacks

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15582 to review the following change. Change subject: consensus: remove kudu::Bind usage from dirty callbacks ...

[kudu-CR] fs: remove kudu::Bind usage from DataDir closures

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15581 to review the following change. Change subject: fs: remove kudu::Bind usage from DataDir closures .. f

[kudu-CR] tracing: remove kudu::Bind usage from various callbacks

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15580 to review the following change. Change subject: tracing: remove kudu::Bind usage from various callbacks ...

[kudu-CR] rpc: remove kudu::Bind usage from ServerPicker

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15578 to review the following change. Change subject: rpc: remove kudu::Bind usage from ServerPicker .. rpc:

[kudu-CR] env: remove kudu::Bind usage from Walk

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15575 to look at the new patch set (#2). Change subject: env: remove kudu::Bind usage from Walk ..

[kudu-CR] gutil: remove callback and bind from the codebase

2020-03-28 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15583 to review the following change. Change subject: gutil: remove callback and bind from the codebase .. g

[kudu-CR] log: clean up entry batch append callback usage

2020-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15571 ) Change subject: log: clean up entry batch append callback usage .. Patch Set 5: Verified+1 Overriding Jenkins, test flake. -- To view,

[kudu-CR] log: clean up entry batch append callback usage

2020-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15571 ) Change subject: log: clean up entry batch append callback usage .. log: clean up entry batch append callback usage I started with

[kudu-CR] log: clean up entry batch append callback usage

2020-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15571 ) Change subject: log: clean up entry batch append callback usage .. Removed reviewer Kudu Jenkins with the following votes: * Veri