[kudu-CR] [master] add 'runtime' tag for master ts rpc timeout ms

2020-05-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15906 ) Change subject: [master] add 'runtime' tag for master_ts_rpc_timeout_ms .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] util: quell warning in sockaddr.cc

2020-05-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15908 ) Change subject: util: quell warning in sockaddr.cc .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] docs: add Ranger integration

2020-05-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15897 ) Change subject: docs: add Ranger integration .. Patch Set 2: (1 comment) Took a quick glance.

[kudu-CR] util: quell warning in sockaddr.cc

2020-05-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15908 ) Change subject: util: quell warning in sockaddr.cc .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform

2020-05-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform .. Patch Set 20: Code-Review+2 Thank you for

[kudu-CR] KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform

2020-05-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14964 ) Change subject: KUDU-3007 (3/3): Support building and running Kudu on aarch64 platform .. KUDU-3007 (3/3): Support building

[kudu-CR] tablet: rename transaction-related files to use "op"

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15907 ) Change subject: tablet: rename transaction-related files to use "op" .. tablet: rename transaction-related files to use "op" No

[kudu-CR] [tests] added more tests for GetTableLocations()

2020-05-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15896 ) Change subject: [tests] added more tests for GetTableLocations() .. [tests] added more tests for GetTableLocations() Added a

[kudu-CR] util: quell warning in sockaddr.cc

2020-05-12 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15908 to look at the new patch set (#2). Change subject: util: quell warning in sockaddr.cc .. util:

[kudu-CR] util: quell warning in sockaddr.cc

2020-05-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15908 ) Change subject: util: quell warning in sockaddr.cc .. Patch Set 1: This is same what Vlad was trying to fix.

[kudu-CR] tablet: rename transaction-related files to use "op"

2020-05-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15907 ) Change subject: tablet: rename transaction-related files to use "op" .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] util: quell warning in sockaddr.cc

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15908 Change subject: util: quell warning in sockaddr.cc .. util: quell warning in sockaddr.cc Building in DEBUG mode, I would see the

[kudu-CR] tablet: rename transaction-related files to use "op"

2020-05-12 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Grant Henke, Hao Hao, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15907 to look at the new patch set (#2). Change subject: tablet: rename transaction-related files to use "op"

[kudu-CR] tablet: rename transaction-related files to use "op"

2020-05-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15907 ) Change subject: tablet: rename transaction-related files to use "op" .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) KUDU-3113: fix auto-rebalancer move execution

2020-05-12 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15905 ) Change subject: KUDU-3113: fix auto-rebalancer move execution .. KUDU-3113: fix auto-rebalancer move execution NOTE: this wasn't

[kudu-CR] tablet: rename transaction-related files to use "op"

2020-05-12 Thread Andrew Wong (Code Review)
Hello Grant Henke, Bankim Bhavsar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15907 to review the following change. Change subject: tablet: rename transaction-related files to use "op"

[kudu-CR] replace "transaction" terminology with "op"

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15870 ) Change subject: replace "transaction" terminology with "op" .. replace "transaction" terminology with "op" This renames most

[kudu-CR] replace "transaction" terminology with "op"

2020-05-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15870 ) Change subject: replace "transaction" terminology with "op" .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] replace "transaction" terminology with "op"

2020-05-12 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Bankim Bhavsar, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15870 to look at the new patch set (#6). Change subject: replace "transaction" terminology with "op"

[kudu-CR] replace "transaction" terminology with "op"

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15870 ) Change subject: replace "transaction" terminology with "op" .. Patch Set 5: (8 comments)

[kudu-CR] replace "transaction" terminology with "op"

2020-05-12 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Bankim Bhavsar, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15870 to look at the new patch set (#5). Change subject: replace "transaction" terminology with "op"

[kudu-CR] [tests] added more tests for GetTableLocations()

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15896 ) Change subject: [tests] added more tests for GetTableLocations() .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] replace "transaction" terminology with "op"

2020-05-12 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Bankim Bhavsar, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15870 to look at the new patch set (#4). Change subject: replace "transaction" terminology with "op"

[kudu-CR] replace "transaction" terminology with "op"

2020-05-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15870 ) Change subject: replace "transaction" terminology with "op" .. Patch Set 3: (3 comments)

[kudu-CR] [master] add 'runtime' tag for master ts rpc timeout ms

2020-05-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15906 Change subject: [master] add 'runtime' tag for master_ts_rpc_timeout_ms .. [master] add 'runtime' tag for master_ts_rpc_timeout_ms The

[kudu-CR] replace "transaction" terminology with "op"

2020-05-12 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15870 ) Change subject: replace "transaction" terminology with "op" .. Patch Set 3: (5 comments) Reviewed about half-way...

[kudu-CR](branch-1.12.x) KUDU-3113: fix auto-rebalancer move execution

2020-05-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15905 ) Change subject: KUDU-3113: fix auto-rebalancer move execution .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) KUDU-3113: fix auto-rebalancer move execution

2020-05-12 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15905 to look at the new patch set (#2). Change subject: KUDU-3113: fix auto-rebalancer move execution ..

[kudu-CR] tablet: update "transaction" comments to use "op" terminology

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/15873 ) Change subject: tablet: update "transaction" comments to use "op" terminology .. Abandoned squashed -- To view, visit

[kudu-CR] tablet: rename Transaction to Op

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/15885 ) Change subject: tablet: rename Transaction to Op .. Abandoned squashed -- To view, visit http://gerrit.cloudera.org:8080/15885 To unsubscribe,

[kudu-CR] tablet: rename MVCC "transactions" to "ops"

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/15871 ) Change subject: tablet: rename MVCC "transactions" to "ops" .. Abandoned squashed -- To view, visit http://gerrit.cloudera.org:8080/15871 To

[kudu-CR] tablet: rename variables from tx[n] to op

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/15872 ) Change subject: tablet: rename variables from tx[n] to op .. Abandoned squashed -- To view, visit http://gerrit.cloudera.org:8080/15872 To

[kudu-CR](branch-1.12.x) KUDU-3113: fix auto-rebalancer move execution

2020-05-12 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15905 to review the following change. Change subject: KUDU-3113: fix auto-rebalancer move execution ..

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

2020-05-12 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. [docs] add 1.12.0 release notes Change-Id:

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

2020-05-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 13: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15685

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

2020-05-12 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Lieber-Dembo, Grant Henke, Hannah Nguyen, Greg Solovyev, Volodymyr Verovkin, Bankim Bhavsar, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15685 to look at the new patch set

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

2020-05-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 12: (4 comments)

[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics

2020-05-12 Thread Brian McDevitt (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15882 to look at the new patch set (#3). Change subject: [KUDU-3116] Enhance KuduContext row operation metrics

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

2020-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 12: Code-Review+2 (3 comments)

[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics

2020-05-12 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/15882 ) Change subject: [KUDU-3116] Enhance KuduContext row operation metrics .. Patch Set 1: (6 comments) New patch set. Thanks for the

[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics

2020-05-12 Thread Brian McDevitt (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15882 to look at the new patch set (#2). Change subject: [KUDU-3116] Enhance KuduContext row operation metrics

[kudu-CR] KUDU-3112. Fix WaitForBind method for checking service status

2020-05-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15893 ) Change subject: KUDU-3112. Fix WaitForBind method for checking service status .. Patch Set 3: (5 comments)

[kudu-CR](branch-1.12.x) [docs] add 1.12.0 release notes

2020-05-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 ) Change subject: [docs] add 1.12.0 release notes .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15685

[kudu-CR] KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread

2020-05-12 Thread RuiChen (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15899 to look at the new patch set (#2). Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread

[kudu-CR] KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread

2020-05-12 Thread RuiChen (Code Review)
RuiChen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15899 ) Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread .. Patch Set 1: Todd, thank you for