[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior

2020-10-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16537 ) Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior .. KUDU-2612 p2 (c): small fix on TxnStatusManager's

[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior

2020-10-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16537 ) Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior .. Patch Set 6: Code-Review+2 Carrying over Hao's +2 from P

[kudu-CR] KUDU-2612 p11: persist txn metadata in superblock

2020-10-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16492 ) Change subject: KUDU-2612 p11: persist txn metadata in superblock .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] KUDU-2612 p10: have timestamp assignment account for commit timestamps

2020-10-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16470 ) Change subject: KUDU-2612 p10: have timestamp assignment account for commit timestamps .. Patch Set 11: Code-Review+2 -- To view, vi

[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior

2020-10-06 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16537 to look at the new patch set (#6). Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior ..

[kudu-CR] KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled

2020-10-06 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Greg Solovyev, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16388 to look at the new patch set (#10). Change subject: KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled ..

[kudu-CR] KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled

2020-10-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16388 ) Change subject: KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled .. Patch Set 8: (2 comments) http://gerrit.cl

[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior

2020-10-06 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16537 to look at the new patch set (#5). Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior

[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior

2020-10-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16537 ) Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior .. Patch Set 4: > LGTM, although the approach of ensure the

[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior

2020-10-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16537 ) Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior .. Patch Set 4: Code-Review+2 LGTM, although the approach of ensu

[kudu-CR] KUDU-2612 p11: persist txn metadata in superblock

2020-10-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16492 ) Change subject: KUDU-2612 p11: persist txn metadata in superblock .. Patch Set 11: Verified+1 The failed test is unrelated to this patch

[kudu-CR] KUDU-2612 p11: persist txn metadata in superblock

2020-10-06 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2612 p11: persist txn metadata in superblock .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16492 To unsubscribe,

[kudu-CR] KUDU-2612 p11: persist txn metadata in superblock

2020-10-06 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16492 to look at the new patch set (#11). Change subject: KUDU-2612 p11: persist txn metadata in superblock ...

[kudu-CR] [catalog manager] Status::AlreadyPresent for range duplicates

2020-10-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16544 ) Change subject: [catalog_manager] Status::AlreadyPresent for range duplicates .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloud

[kudu-CR] [catalog manager] Status::AlreadyPresent for range duplicates

2020-10-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16544 ) Change subject: [catalog_manager] Status::AlreadyPresent for range duplicates .. [catalog_manager] Status::AlreadyPresent for r

[kudu-CR] [catalog manager] Status::AlreadyPresent for range duplicates

2020-10-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16544 ) Change subject: [catalog_manager] Status::AlreadyPresent for range duplicates .. Patch Set 3: Thank you for the review! -- To view,

[kudu-CR] KUDU-2612 p11: persist txn metadata in superblock

2020-10-06 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16492 to look at the new patch set (#10). Change subject: KUDU-2612 p11: persist txn metadata in superblock ...

[kudu-CR] [catalog manager] Status::AlreadyPresent for range duplicates

2020-10-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16544 ) Change subject: [catalog_manager] Status::AlreadyPresent for range duplicates .. Patch Set 3: Code-Review+2 (3 comments) http://gerrit.

[kudu-CR] KUDU-2612 p11: persist txn metadata in superblock

2020-10-06 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16492 to look at the new patch set (#9). Change subject: KUDU-2612 p11: persist txn metadata in superblock

[kudu-CR] KUDU-2612 p10: have timestamp assignment account for commit timestamps

2020-10-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16470 ) Change subject: KUDU-2612 p10: have timestamp assignment account for commit timestamps .. Patch Set 10: (8 comments) http://gerrit.clo

[kudu-CR] KUDU-2612 p10: have timestamp assignment account for commit timestamps

2020-10-06 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16470 to look at the new patch set (#11). Change subject: KUDU-2612 p10: have timestamp assignment account for commit timestamps