[kudu-CR] [catalog manager] fix the typo in the comment for 'leader lock '

2020-10-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16646 ) Change subject: [catalog manager] fix the typo in the comment for 'leader_lock_' .. Patch Set 1: Code-Review+2 -- To view, visit http:/

[kudu-CR] Remove redundant code in TabletReplica

2020-10-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16647 ) Change subject: Remove redundant code in TabletReplica .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Fix order of clearing and printing openssl error

2020-10-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16631 ) Change subject: Fix order of clearing and printing openssl error .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] Fix order of clearing and printing openssl error

2020-10-26 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16631 ) Change subject: Fix order of clearing and printing openssl error .. Fix order of clearing and printing openssl error When verif

[kudu-CR] tablet: fix build on macOS

2020-10-26 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16650 Change subject: tablet: fix build on macOS .. tablet: fix build on macOS This fixes the following error: ../../src/kudu/tablet/compactio

[kudu-CR] tablet: fix build on macOS

2020-10-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16650 To un

[kudu-CR] tablet: fix build on macOS

2020-10-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 1: Verified+1 verified manually on Mac. -- To view, visit http://gerrit.cloud

[kudu-CR] tablet: fix build on macOS

2020-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16650/1/src/

[kudu-CR] tablet: fix build on macOS

2020-10-26 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16650 to look at the new patch set (#2). Change subject: tablet: fix build on macOS .. table

[kudu-CR] tablet: fix build on macOS

2020-10-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16650/1/src/kudu/tablet/comp

[kudu-CR] tablet: fix build on macOS

2020-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16650 To u

[kudu-CR] tablet: fix build on macOS

2020-10-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] tablet: fix build on macOS

2020-10-26 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16650 ) Change subject: tablet: fix build on macOS .. tablet: fix build on macOS This fixes the following error: ../../src/kudu/tablet/

[kudu-CR] [catalog manager] fix the typo in the comment for 'leader lock '

2020-10-26 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16646 ) Change subject: [catalog manager] fix the typo in the comment for 'leader_lock_' .. [catalog manager] fix the typo in the comment for

[kudu-CR] Remove redundant code in TabletReplica

2020-10-26 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16647 ) Change subject: Remove redundant code in TabletReplica .. Remove redundant code in TabletReplica Change-Id: I506d1522ccdbf1bef6df54b

[kudu-CR] KUDU-2612: persist commit MVCC op timestamp in txn metadata

2020-10-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16569 ) Change subject: KUDU-2612: persist commit MVCC op timestamp in txn metadata .. Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloude

[kudu-CR] (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only

2020-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 ) Change subject: (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only .. Patch Set 1: (6 comments) Just a q

[kudu-CR] [tserver] validator for --scanner max wait ms

2020-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16655 Change subject: [tserver] validator for --scanner_max_wait_ms .. [tserver] validator for --scanner_max_wait_ms This patch adds a group

[kudu-CR] [tserver] validator for --scanner max wait ms

2020-10-26 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16655 to look at the new patch set (#2). Change subject: [tserver] validator for --scanner_max_wait_ms .. [t

[kudu-CR] [tserver] validator for --scanner max wait ms

2020-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [tserver] validator for --scanner_max_wait_ms .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16655 To unsubscribe, v

[kudu-CR] [tserver] validator for --scanner max wait ms

2020-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16655 ) Change subject: [tserver] validator for --scanner_max_wait_ms .. Patch Set 2: Verified+1 unrelated test failure in ToolTest.TestHmsLis

[kudu-CR] [tserver] validator for --scanner max wait ms

2020-10-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16655 ) Change subject: [tserver] validator for --scanner_max_wait_ms .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:808