[kudu-CR] KUDU-3476: Make replica placement range and table aware

2023-06-20 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19931 ) Change subject: KUDU-3476: Make replica placement range and table aware .. Patch Set 7: (10 comments) This rev addressed minor nits an

[kudu-CR] KUDU-3476: Make replica placement range and table aware

2023-06-20 Thread Mahesh Reddy (Code Review)
Hello Marton Greber, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Ádám Bakai, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19931 to look at the new patch set (#7). Change subject: KUDU-3476: Make replica placement range a

[kudu-CR](branch-1.17.x) [docs] Add release notes for 1.17.0

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19512 ) Change subject: [docs] Add release notes for 1.17.0 .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] [doc] update build/install instructions for RHEL9

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20102 ) Change subject: [doc] update build/install instructions for RHEL9 .. [doc] update build/install instructions for RHEL9 Change-

[kudu-CR] [util] fix expected/actual arguments for ASSERT EQ()

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20101 ) Change subject: [util] fix expected/actual arguments for ASSERT_EQ() .. [util] fix expected/actual arguments for ASSERT_EQ() T

[kudu-CR] [doc] update build/install instructions for RHEL9

2023-06-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20102 ) Change subject: [doc] update build/install instructions for RHEL9 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloude

[kudu-CR] [util] fix expected/actual arguments for ASSERT EQ()

2023-06-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20101 ) Change subject: [util] fix expected/actual arguments for ASSERT_EQ() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR](branch-1.17.x) [docs] Add release notes for 1.17.0

2023-06-20 Thread Yingchun Lai (Code Review)
Hello Marton Greber, Alexey Serbin, Kurt Deschler, Yuqi Du, Andrew Wong, Yifan Zhang, Khazar Mammadli, Joe McDonnell, Zoltan Chovan, Ashwani Raina, Attila Bukor, KeDeng, Ádám Bakai, Mahesh Reddy, zhanghongbin, Wenzhe Zhou, bsglz, harinreddy, Riza Suminto, Hongjiang Zhang, Kudu Jenkins, Abhishek

[kudu-CR](branch-1.17.x) [docs] Add release notes for 1.17.0

2023-06-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19512 ) Change subject: [docs] Add release notes for 1.17.0 .. Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/19512/10/docs/re

[kudu-CR] [doc] update build/install instructions for RHEL9

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20102 Change subject: [doc] update build/install instructions for RHEL9 .. [doc] update build/install instructions for RHEL9 Change-Id: I9fb4

[kudu-CR] [util] fix at-rest {en,de}cryption for OpenSSL 3

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20100 ) Change subject: [util] fix at-rest {en,de}cryption for OpenSSL 3 .. [util] fix at-rest {en,de}cryption for OpenSSL 3 It seems

[kudu-CR] [util] fix at-rest {en,de}cryption for OpenSSL 3

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [util] fix at-rest {en,de}cryption for OpenSSL 3 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20100 To unsubscribe

[kudu-CR] [util] fix at-rest {en,de}cryption for OpenSSL 3

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20100 ) Change subject: [util] fix at-rest {en,de}cryption for OpenSSL 3 .. Patch Set 1: Verified+1 unrelated test failure in ReplicatedAlter

[kudu-CR] [util] fix expected/actual arguments for ASSERT EQ()

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20101 Change subject: [util] fix expected/actual arguments for ASSERT_EQ() .. [util] fix expected/actual arguments for ASSERT_EQ() This patch

[kudu-CR] [util] fix at-rest {en,de}cryption for OpenSSL 3

2023-06-20 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20100 ) Change subject: [util] fix at-rest {en,de}cryption for OpenSSL 3 .. Patch Set 1: Code-Review+2 Nice catch! Funnily enough, I recall add

[kudu-CR] [util] fix at-rest {en,de}cryption for OpenSSL 3

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20100 Change subject: [util] fix at-rest {en,de}cryption for OpenSSL 3 .. [util] fix at-rest {en,de}cryption for OpenSSL 3 It seems that with

[kudu-CR](branch-1.17.x) [build-support] allow building with gcc/g++-7 on SLES

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20056 ) Change subject: [build-support] allow building with gcc/g++-7 on SLES .. [build-support] allow building with gcc/g++-7 on SLES

[kudu-CR](branch-1.17.x) [build-support] allow building with gcc/g++-7 on SLES

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20056 ) Change subject: [build-support] allow building with gcc/g++-7 on SLES .. Patch Set 2: Code-Review+2 Pre-commit builds succeeded. Carr

[kudu-CR](branch-1.17.x) [docs] Add release notes for 1.17.0

2023-06-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19512 ) Change subject: [docs] Add release notes for 1.17.0 .. Patch Set 11: (5 comments) Almost there. Just a few nits left. http://gerrit

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-06-20 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 16: (3 comments) http://gerrit.cloudera.org:8

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-06-20 Thread Wang Xixu (Code Review)
Hello Yuqi Du, Alexey Serbin, Yingchun Lai, Yifan Zhang, Attila Bukor, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19949 to look at the new patch set (#16). Change subject: KUDU-3483 Fix flushing data in batch when table schema cha

[kudu-CR] [build] Change shebangs to python3

2023-06-20 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20079 ) Change subject: [build] Change shebangs to python3 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20079/1//COMMIT_MSG

[kudu-CR] Change order of operations during InitCatalogManagerTask

2023-06-20 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19639 ) Change subject: Change order of operations during InitCatalogManagerTask .. Patch Set 5: > Patch Set 4: > > > Thanks for addressing thi

[kudu-CR] [KUDU-3483] Fixbug of auto flush data when table schema changed

2023-06-20 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed .. Patch Set 15: (3 comments) http://gerrit.cloudera.o

[kudu-CR] [KUDU-3483] Fixbug of auto flush data when table schema changed

2023-06-20 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:

[kudu-CR] [KUDU-3483] Fixbug of auto flush data when table schema changed

2023-06-20 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed .. Patch Set 15: (3 comments) http://gerrit.cloudera.or

[kudu-CR] KUDU-3459 Download superblock piece by piece

2023-06-20 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19620 ) Change subject: KUDU-3459 Download superblock piece by piece .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19620/2//CO