[kudu-CR] [security] a small style-related code cleanup

2023-12-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20745 ) Change subject: [security] a small style-related code cleanup .. [security] a small style-related code cleanup Since I'm

[kudu-CR] [security] a small style-related code cleanup

2023-12-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20745 ) Change subject: [security] a small style-related code cleanup .. Patch Set 2: Code-Review+2 carrying over Abhishek's +2 from PS1 --

[kudu-CR] [security] a small style-related code cleanup

2023-12-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20745 ) Change subject: [security] a small style-related code cleanup .. Patch Set 2: Verified+1 unrelated test failures (mostly KUDU-3524)

[kudu-CR] [security] a small style-related code cleanup

2023-12-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [security] a small style-related code cleanup .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20745 To unsubscribe,

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2023-12-04 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: (4 comments) > Patch Set 3: > >

[kudu-CR] [security] a small style-related code cleanup

2023-12-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20745 ) Change subject: [security] a small style-related code cleanup .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [security] a small style-related code cleanup

2023-12-04 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20745 to look at the new patch set (#2). Change subject: [security] a small style-related code cleanup

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2023-12-04 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Ashwani Raina, Yingchun Lai, Yifan Zhang, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20680 to look at the new patch set (#4). Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of

[kudu-CR] more strict check for [un]setenv() return code

2023-12-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20744 ) Change subject: more strict check for [un]setenv() return code .. more strict check for [un]setenv() return code Even if

[kudu-CR] more strict check for [un]setenv() return code

2023-12-04 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 ) Change subject: more strict check for [un]setenv() return code .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [rpc] micro-optimizations on RpczStore::LogTrace

2023-12-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20748 ) Change subject: [rpc] micro-optimizations on RpczStore::LogTrace .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [rpc] micro-optimizations on RpczStore::LogTrace

2023-12-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20748 Change subject: [rpc] micro-optimizations on RpczStore::LogTrace .. [rpc] micro-optimizations on RpczStore::LogTrace This patch

[kudu-CR] more strict check for [un]setenv() return code

2023-12-04 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 ) Change subject: more strict check for [un]setenv() return code .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] more strict check for [un]setenv() return code

2023-12-04 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 ) Change subject: more strict check for [un]setenv() return code .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [ARM] Fix CountOnes() function

2023-12-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20736 ) Change subject: [ARM] Fix CountOnes() function .. [ARM] Fix CountOnes() function This function is only used on arms. It does

[kudu-CR] [ARM] Fix CountOnes() function

2023-12-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20736 ) Change subject: [ARM] Fix CountOnes() function .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20736/2//COMMIT_MSG

[kudu-CR] more strict check for [un]setenv() return code

2023-12-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 ) Change subject: more strict check for [un]setenv() return code .. Patch Set 1: (1 comment)

[kudu-CR] more strict check for [un]setenv() return code

2023-12-04 Thread Alexey Serbin (Code Review)
Hello Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20744 to look at the new patch set (#2). Change subject: more strict check for [un]setenv() return code

[kudu-CR] [security] a small style-related code cleanup

2023-12-04 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20745 ) Change subject: [security] a small style-related code cleanup .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] more strict check for [un]setenv() return code

2023-12-04 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 ) Change subject: more strict check for [un]setenv() return code .. Patch Set 1: (1 comment)