[kudu-CR] KUDU-3532: Fix range aware replica placement bug

2023-12-20 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20781 ) Change subject: KUDU-3532: Fix range aware replica placement bug .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2023-12-20 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20827 Change subject: KUDU-3252: Follow up to replica placement bug .. KUDU-3252: Follow up to replica placement bug This patch addresses the

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20716 ) Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description. .. [util] Add a warning into

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20716 ) Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description. .. Patch Set 17: Code-Review+2 (1 comment)

[kudu-CR] [Refactor] Fix a memory leak warning

2023-12-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20784 ) Change subject: [Refactor] Fix a memory leak warning .. [Refactor] Fix a memory leak warning The following is the warning

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-20 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20716 ) Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description. .. Patch Set 17: Code-Review+1 -- To view,

[kudu-CR] [webserver] add security-related HTTP headers

2023-12-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18253 ) Change subject: [webserver] add security-related HTTP headers .. Patch Set 8: (1 comment)

[kudu-CR] [webserver] add security-related HTTP headers

2023-12-20 Thread Alexey Serbin (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18253 to look at the new patch set (#9). Change subject: [webserver] add security-related HTTP headers

[kudu-CR] [rpc] modernize code a bit

2023-12-20 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20815 ) Change subject: [rpc] modernize code a bit .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20815

[kudu-CR] [rpc] modernize code a bit

2023-12-20 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20815 ) Change subject: [rpc] modernize code a bit .. [rpc] modernize code a bit Since I'm updating the code in

[kudu-CR] [logging] simplify and improve LogThrottler

2023-12-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20820 ) Change subject: [logging] simplify and improve LogThrottler .. [logging] simplify and improve LogThrottler I've noticed that

[kudu-CR] [logging] simplify and improve LogThrottler

2023-12-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20820 ) Change subject: [logging] simplify and improve LogThrottler .. Patch Set 2: Verified+1 unrelated test failure in

[kudu-CR] [logging] simplify and improve LogThrottler

2023-12-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [logging] simplify and improve LogThrottler .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20820 To unsubscribe,

[kudu-CR] [logging] simplify and improve LogThrottler

2023-12-20 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20820 ) Change subject: [logging] simplify and improve LogThrottler .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [webserver] add security-related HTTP headers

2023-12-20 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18253 ) Change subject: [webserver] add security-related HTTP headers .. Patch Set 8: (1 comment)

[kudu-CR] [webserver] add security-related HTTP headers

2023-12-20 Thread Alexey Serbin (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18253 to look at the new patch set (#8). Change subject: [webserver] add security-related HTTP headers

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2023-12-20 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: Code-Review+1 LGTM, looks like there's

[kudu-CR] [rpc] modernize code a bit

2023-12-20 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20815 ) Change subject: [rpc] modernize code a bit .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20815 To

[kudu-CR] [logging] simplify and improve LogThrottler

2023-12-20 Thread Alexey Serbin (Code Review)
Hello Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20820 to look at the new patch set (#2). Change subject: [logging] simplify and improve LogThrottler

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-20 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20716 to look at the new patch set (#17). Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description.

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2023-12-20 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#17). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client.

[kudu-CR] KUDU-3535 Should clear log cache while tombstoning a replica.

2023-12-20 Thread Song Jiacheng (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20822 to look at the new patch set (#3). Change subject: KUDU-3535 Should clear log cache while tombstoning a replica. ..

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-20 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20716 to look at the new patch set (#16). Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description.

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2023-12-20 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#16). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client.

[kudu-CR] KUDU-3535 Should clear log cache while tombstoning a replica.

2023-12-20 Thread Song Jiacheng (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20822 to look at the new patch set (#2). Change subject: KUDU-3535 Should clear log cache while tombstoning a replica. ..

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-20 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20716 to look at the new patch set (#15). Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description.

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2023-12-20 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#15). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client.