[kudu-CR] Add compile time checks for kerberos, libvmem

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10870 ) Change subject: Add compile time checks for kerberos, libvmem .. Patch Set 6: After chatting with Sailesh in person, I removed the

[kudu-CR] Add compile time checks for kerberos, libvmem

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10870 ) Change subject: Add compile time checks for kerberos, libvmem .. Add compile time checks for kerberos, libvmem This change adds compile

[kudu-CR] Add compile time checks for kerberos, libvmem

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10870 ) Change subject: Add compile time checks for kerberos, libvmem .. Patch Set 4: Still testing the ported function manually but the code

[kudu-CR] Add compile time checks for kerberos, libvmem

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10870 Change subject: Add compile time checks for kerberos, libvmem .. Add compile time checks for kerberos, libvmem This change adds compile

[kudu-CR] Add compile time checks for kerberos, libvmem

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10870 ) Change subject: Add compile time checks for kerberos, libvmem .. Add compile time checks for kerberos, libvmem This change adds compile

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9934 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 3: Code-Review+1 (2

[kudu-CR] KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails

2018-04-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9934 ) Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails .. Patch Set 1: (5 comments)

[kudu-CR] KUDU-2031: Add metrics per connection to the reactor metrics

2018-02-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2031: Add metrics per connection to the reactor metrics .. Patch Set 3: (3 comments)

[kudu-CR] Expose RPC method info map and various metrics

2018-02-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9269 ) Change subject: Expose RPC method info map and various metrics .. Patch Set 4: (2 comments) Thanks for the review. Please see PS4.

[kudu-CR] Expose RPC method info map and various metrics

2018-02-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9269 ) Change subject: Expose RPC method info map and various metrics .. Expose RPC method info map and various metrics These changes are needed

[kudu-CR] Expose RPC method info map and various metrics

2018-02-10 Thread Lars Volker (Code Review)
Hello Michael Ho, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9269 to look at the new patch set (#3). Change subject: Expose RPC method info map and various metrics

[kudu-CR] Expose RPC method info map and various metrics

2018-02-09 Thread Lars Volker (Code Review)
Hello Michael Ho, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9269 to look at the new patch set (#2). Change subject: Expose RPC method info map and various metrics ..

[kudu-CR] DRAFT: Expose RPC method info map and various metrics

2018-02-09 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9269 Change subject: DRAFT: Expose RPC method info map and various metrics .. DRAFT: Expose RPC method info map and various metrics Change-Id:

[kudu-CR] KUDU-2256: Add GetTransferSize() to RpcContext

2018-01-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8998 to look at the new patch set (#5). Change subject: KUDU-2256: Add GetTransferSize() to RpcContext ..

[kudu-CR] KUDU-2256: Add GetTransferSize() to RpcContext

2018-01-11 Thread Lars Volker (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8998 to look at the new patch set (#4). Change subject: KUDU-2256: Add GetTransferSize() to RpcContext .. KUDU-2256: Add

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (3 comments)