[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [consensus] add lock coverage for peer queue .. [consensus] add lock coverage for peer queue A Peer or PeerQueue would lock without taking into ac

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/6299/7//COMMIT_MSG Commit Message: Line 29: https:

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6299 To unsubscribe, visit h

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6299 to look at the new patch set (#10). Change subject: [consensus] add lock coverage for peer queue .. [consensus] add

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/9/src/kudu/consensus/consensus_queue.h F

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6299 to look at the new patch set (#9). Change subject: [consensus] add lock coverage for peer queue .. [consensus] add

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/7/src/kudu/consensus/consensus_queue.h F

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/7/src/kudu/consensus/consensus_peers.cc

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/6299/7/src/kudu/consensus/consensus_peers.cc File sr

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 7: (2 comments) left an relevant question, the test lgtm and/or is nits http://gerrit.cloudera.

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-10 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6299 to look at the new patch set (#8). Change subject: [consensus] add lock coverage for peer queue .. [consensus] add

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/7//COMMIT_MSG Commit Message: Line 29: https:/

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-09 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6299 to look at the new patch set (#7). Change subject: [consensus] add lock coverage for peer queue .. [consensus] add

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 6: Will try that out, so far, I'd just been using specific test cases with default threading. Found the

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 6: as a repro strategy I'd maybe try that test (and/or some others in raft_consensus-itest) with

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 6: please add your findings to the commit message along with the links to the dist tests and the

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 6: Seeing if I can get it to repro, but running dist-test on a TSAN build of RaftConsensusITest.TestConf

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 6: Can you paste the TSAN error and reproduction steps here? I thought that we were avoiding races here

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-08 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6299 to look at the new patch set (#6). Change subject: [consensus] add lock coverage for peer queue .. [consensus] add

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/4/src/kudu/consensus/consensus_queue.cc File src

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-08 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6299 to look at the new patch set (#5). Change subject: [consensus] add lock coverage for peer queue .. [consensus] add

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/4/src/kudu/consensus/consensus_queue.cc

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/4/src/kudu/consensus/consensus_queue.cc

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/4/src/kudu/consensus/consensus_queue.cc File src

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/4/src/kudu/consensus/consensus_queue.cc File src

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6299 to look at the new patch set (#4). Change subject: [consensus] add lock coverage for peer queue .. [consensus] add

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/1/src/kudu/consensus/consensus_queue.cc File src

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6299/1/src/kudu/consensus/consensus_queue.cc File sr

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6299/1/src/kudu/consensus/consensus_queue.cc

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6299 to look at the new patch set (#3). Change subject: [consensus] add lock coverage for peer queue .. [consensus] add

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#2). Change subject: [consensus] add lock coverage for peer queue .. [consensus] add lock coverage for peer queue Certain operations in PeerMessageQueue (e.g. RequestForPeer) were not lo

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-07 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6299 Change subject: [consensus] add lock coverage for peer queue .. [consensus] add lock coverage for peer queue Certain operations in PeerMes