[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Implement RPC tracing, part 1 .. [java client] Implement RPC tracing, part 1 First part of this work is adding the tracing objects an

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 9: Code-Review+2 thanks! -- To view, visit http://gerrit.cloudera.org:8080/4781 To unsubscribe, visit ht

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#9). Change subject: [java client] Implement RPC tracing, part 1 ..

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#8). Change subject: [java client] Implement RPC tracing, part 1 ..

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 5: (1 comment) sorz http://gerrit.cloudera.org:8080/#/c/4781/7/java/kudu-client/src/main/java/org/apache

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4781 To unsubscribe, visit http://gerri

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#6). Change subject: [java client] Implement RPC tracing, part 1 ..

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4781/5/java/kudu-client/src/main/java/org/apach

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4781/5/java/kudu-client/src/main/java/org/apache/kudu/

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 5: I didn't completely research Adars argument, but the patch looks good to me. I'm happy with it module

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-02 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4781/5//COMMIT_MSG Commit Message: PS5, Line

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/4781/5//COMMIT_MSG Commit Message: PS5, Line 23: ca

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 5: Code-Review+2 Leaving unmerged in case Dan wants to take a look. -- To view, visit http://gerrit.cloud

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-01 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#5). Change subject: [java client] Implement RPC tracing, part 1 .. [java client] Imp

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4781/3/java/kudu-client/src/main/java/org/apache/kudu/c

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4781/3//COMMIT_MSG Commit Message: Line 30: R

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4781/3//COMMIT_MSG Commit Message: Line 30: RpcTraceO

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-28 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#4). Change subject: [java client] Implement RPC tracing, part 1 .. [java client] Imp

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-28 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4781/3/java/kudu-client/src/test/java/org/apach

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-28 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (16 comments) > Would be nice to understand whether there's a perf impact to this, > to decide

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (16 comments) Would be nice to understand whether there's a perf impact to this, to decide whether we

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#3). Change subject: [java client] Implement RPC tracing, part 1 ..