[kudu-CR] Add fault injection of EIOs

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add fault injection of EIOs .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6881/12//COMMIT_MSG Commit Message: Line 10: a flag-specified glob

[kudu-CR] Add fault injection of EIOs

2017-06-05 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#12). Change subject: Add fault injection of EIOs .. Add fault injection of EIOs

[kudu-CR] Add fault injection of EIOs

2017-06-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Add fault injection of EIOs .. Patch Set 11: (7 comments) Haven't addressed everything, marked some "will do"s. Pushed after rebasing as along with the EMC

[kudu-CR] Add fault injection of EIOs

2017-06-02 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#11). Change subject: Add fault injection of EIOs .. Add fault injection of EIOs

[kudu-CR] Add fault injection of EIOs

2017-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add fault injection of EIOs .. Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/6881/8/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc:

[kudu-CR] Add fault injection of EIOs

2017-05-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#5). Change subject: Add fault injection of EIOs .. Add fault injection of EIOs

[kudu-CR] Add fault injection of EIOs

2017-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Add fault injection of EIOs .. Patch Set 4: (25 comments) http://gerrit.cloudera.org:8080/#/c/6881/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc:

[kudu-CR] Add fault injection of EIOs

2017-05-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#4). Change subject: Add fault injection of EIOs .. Add fault injection of EIOs

[kudu-CR] Add fault injection of EIOs

2017-05-15 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#3). Change subject: Add fault injection of EIOs .. Add fault injection of EIOs

[kudu-CR] Add fault injection of EIOs

2017-05-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add fault injection of EIOs .. Patch Set 2: (5 comments) a small directed test would be nice. maybe just add a test to env_util test where you set the

[kudu-CR] Add fault injection of EIOs

2017-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Add fault injection of EIOs .. Patch Set 2: For now I've left the injection in env_posix.cc since it's only used within this class. If other files can take

[kudu-CR] Add fault injection of EIOs

2017-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#2). Change subject: Add fault injection of EIOs .. Add fault injection of EIOs This patch adds the functionality to inject EIOs in env_posix based on a flag-specified ECMAScript regex

[kudu-CR] Add fault injection of EIOs

2017-05-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6881 Change subject: Add fault injection of EIOs .. Add fault injection of EIOs This patch adds the functionality to inject EIOs in env_posix