[kudu-CR] Bump protobuf to 3.4.1

2017-09-18 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Bump protobuf to 3.4.1 .. Bump protobuf to 3.4.1 This allows us to drop the 'experimental' flag for move constructors introduced in 1632d16aa5993, since t

[kudu-CR] Bump protobuf to 3.4.1

2017-09-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Bump protobuf to 3.4.1 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8086 To unsubscribe, visit http://gerrit.cloudera.org:8080/s

[kudu-CR] Bump protobuf to 3.4.1

2017-09-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Bump protobuf to 3.4.1 .. Patch Set 2: Yeah this seems to be protobuf's MO: https://github.com/google/protobuf/issues/3602 -- To view, visit http://gerrit.cloud

[kudu-CR] Bump protobuf to 3.4.1

2017-09-18 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8086 to look at the new patch set (#3). Change subject: Bump protobuf to 3.4.1 .. Bump protobuf to 3.4.1 Th

[kudu-CR] Bump protobuf to 3.4.1

2017-09-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Bump protobuf to 3.4.1 .. Patch Set 2: https://github.com/google/protobuf/issues/3656 I'm going to change it back to 3.4.0 in the meantime, since I suspect it was

[kudu-CR] Bump protobuf to 3.4.1

2017-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Bump protobuf to 3.4.1 .. Patch Set 2: Code-Review+2 Looks like 3.4.1 isn't available for Java yet; I only see 3.4.0 artifacts. Could you bug the protobuf team abo

[kudu-CR] Bump protobuf to 3.4.1

2017-09-15 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: Bump protobuf to 3.4.1 .. Bump protobuf to 3.4.1 This allows us to drop the 'experimental' flag for move constructors introduced in 1632d16aa5993, since they are ena

[kudu-CR] Bump protobuf to 3.4.1

2017-09-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Bump protobuf to 3.4.1 .. Patch Set 1: Should also update in Java (for both Maven and Gradle). -- To view, visit http://gerrit.cloudera.org:8080/8086 To unsubscri

[kudu-CR] Bump protobuf to 3.4.1

2017-09-15 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8086 to review the following change. Change subject: Bump protobuf to 3.4.1 .. Bump protobuf to 3.4.1 This all