[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Expose row format flags in KuduScanner .. Expose row format flags in KuduScanner This adds a way to pass row format modifier flags to KuduScanner,

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6624 To unsubscribe, visit http://gerrit

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6624 to look at the new patch set (#13). Change subject: Expose row format flags in KuduScanner .. Expose ro

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/6624/12/src/kudu/client/client.cc File src/kudu/cl

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/6624/12/src/kudu/client/client.cc File src/kudu/client/c

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6624 to look at the new patch set (#12). Change subject: Expose row format flags in KuduScanner .. Expose ro

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6624 to look at the new patch set (#11). Change subject: Expose row format flags in KuduScanner .. Expose ro

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/6624/9/src/kudu/client/scanner-internal.cc File s

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/6624/9/src/kudu/client/scanner-internal.cc File src/kud

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6624 to look at the new patch set (#10). Change subject: Expose row format flags in KuduScanner .. Expose ro

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/6624/9/src/kudu/client/client.h File src/kudu/clie

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/6624/9/src/kudu/client/client.h File src/kudu/client/clien

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/6624/8/src/kudu/client/client.cc File src/kudu/cli

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6624 to look at the new patch set (#9). Change subject: Expose row format flags in KuduScanner .. Expose row format flags

[kudu-CR] Expose row format flags in KuduScanner

2017-05-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 8: Code-Review+1 (1 comment) Will defer to Alexey or Todd for the final review. http://gerrit.cloudera.org:808

[kudu-CR] Expose row format flags in KuduScanner

2017-05-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 8: (8 comments) Just skimmed over the code to get more context on the new feature. http://gerrit.cloudera.o

[kudu-CR] Expose row format flags in KuduScanner

2017-05-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 8: Verified+1 unrelated ITClient test failure -- To view, visit http://gerrit.cloudera.org:8080/6624

[kudu-CR] Expose row format flags in KuduScanner

2017-05-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#8). Change subject: Expose row format flags in KuduScanner .. Expose row format flags in KuduScanner This adds a way to pass row format modifier flags to KuduScanner, encoded in

[kudu-CR] Expose row format flags in KuduScanner

2017-05-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/6624/7/src/kudu/integration-tests/all_types-itest.

[kudu-CR] Expose row format flags in KuduScanner

2017-05-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 7: Verified+1 unrelated failure -- To view, visit http://gerrit.cloudera.org:8080/6624 To unsubscribe

[kudu-CR] Expose row format flags in KuduScanner

2017-05-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#7). Change subject: Expose row format flags in KuduScanner .. Expose row format flags in KuduScanner This adds a way to pass row format modifier flags to KuduScanner, encoded in

[kudu-CR] Expose row format flags in KuduScanner

2017-05-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Expose row format flags in KuduScanner .. Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/6624/6/src/kudu/client/client.cc File src/kudu/cli