[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 10: lgtm, i'll put this on a cluster and see how it goes. -- To view, visit http://

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. KUDU-1845: Kerberos client keytab should be periodically renewed With the current kerb

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5820 To unsubscr

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 10: (11 comments) http://gerrit.cloudera.org:8080/#/c/5820/9/src/kudu/security/ini

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-15 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#10). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed ...

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 9: (11 comments) http://gerrit.cloudera.org:8080/#/c/5820/9/src/kudu/security/init.c

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-14 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#9). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 8: (2 comments) > Build Failed > > http://104.196.14.100/job/kudu-gerrit/6321/

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-14 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#8). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5820/6/src/kudu/security/init.

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-06 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#7). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5820/6/src/kudu/security/init.cc

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 6: > Uploaded patch set 6. I just had to #include The util/random library wouldn

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#6). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. KUDU-1845: Kerberos client keytab should be periodically renewed With the current kerberos supp

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#6). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

Re: [kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil
Will fix it now and post an update. On Fri, Feb 3, 2017 at 9:34 AM, Todd Lipcon (Code Review) < ger...@cloudera.org> wrote: > Todd Lipcon has posted comments on this change. > > Change subject: KUDU-1845: Kerberos client keytab should be periodically > renewed > ..

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 5: seems the TSAN build doesn't like the std::random stuff (maybe it's not available

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 5: (6 comments) @Todd: Thanks, I got the ASAN build working. Aside from the code c

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-03 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#5). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/5820/4/src/kudu/security/init.cc

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 4: > So the ASAN build fails because the renew thread is leaking all its > allocatio

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 4: So the ASAN build fails because the renew thread is leaking all its allocations

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 4: Thanks Todd. As Todd fixed in the patch, the issue was that the client had a se

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-02 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#4). Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5820/1/src/kudu/security/init.cc

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5820/1/src/kudu/security/init.cc F

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5820/1/src/kudu/security/init.cc

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5820/1/src/kudu/security/init.cc F

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/5820/1//COMMIT_MSG Commit Messa

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: (2 comments) Just passing through... http://gerrit.cloudera.org:8080/#/c/5820/1/s

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: I'm having a hard time testing it properly as I don't know how to set up a kerb

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5820 Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. KUDU-1845: Kerberos client keytab should be periodica