[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-17 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. KUDU-2245 Graceful leadership transfer This patch implements gracefu

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 18: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-17 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 17: (4 comments) http://gerrit.cloudera.org:8080/#/c/11251/17/src

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/11251/17/src/kud

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-17 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#18). Change subject: KUDU-2245 Graceful leadership transfer ...

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 17: (5 comments) Finished going through the tests, this all looks go

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 17: Posted a fix for a simple issue that caused the one failure:

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-16 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 17: Verified+1 Unrelated flakes. -- To view, visit http://gerrit

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 16: I doubled the timeout in TestSimultaneousLeaderTransferAndAbru

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-16 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#17). Change subject: KUDU-2245 Graceful leadership transfer .

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 16: Hm, I had tested with a lot of runs on TSAN and didn't see a p

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-16 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 15: (5 comments) The "signature" of WARN_NOT_OK is WARN_NOT_OK(St

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-16 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#16). Change subject: KUDU-2245 Graceful leadership transfer ...

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/11251/15/src/kud

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 15: (4 comments) Looks good just a plumbing nitpick now http://gerr

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-15 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 15: Verified+1 TSAN failures are some kind of isolate failure to d

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-15 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-15 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#15). Change subject: KUDU-2245 Graceful leadership transfer .

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/11251/13/src/kud

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-15 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#14). Change subject: KUDU-2245 Graceful leadership transfer .

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-15 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 13: (13 comments) PeerMessageQueue::DetermineIfCaughtUp is called

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 13: (13 comments) I don't see a place where we lazily choose the new

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 13: Verified+1 Precommit failure is KUDU-2576. -- To view, visit

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-01 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: KUDU-2245 Graceful leadership transfer .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11251 To unsubscribe, visit ht

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-10-01 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#13). Change subject: KUDU-2245 Graceful leadership transfer .

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-25 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#12). Change subject: KUDU-2245 Graceful leadership transfer .

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/11251/10/src/

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 11: > (9 comments) > > I tried doing a bit of a refactor on the

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-24 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#11). Change subject: KUDU-2245 Graceful leadership transfer .

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 10: (9 comments) I tried doing a bit of a refactor on the CheckMo

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/11251/10/src

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/11251/8/src/

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#10). Change subject: KUDU-2245 Graceful leadership transfer .

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#9). Change subject: KUDU-2245 Graceful leadership transfer ..

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 8: I think this uncovered a bug in CheckCompleteMove that was hidd

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/11251/7/src/ku

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#8). Change subject: KUDU-2245 Graceful leadership transfer ..

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 7: (30 comments) http://gerrit.cloudera.org:8080/#/c/11251/7/src/

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/11251/7/src/kudu/

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 7: (14 comments) Few more nits. http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 ) Change subject: KUDU-2245 Graceful leadership transfer .. Patch Set 7: Not sure why it failed...it's hard to track that in the logs. I

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-07 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#7). Change subject: KUDU-2245 Graceful leadership transfer ..

[kudu-CR] KUDU-2245 Graceful leadership transfer

2018-09-07 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#6). Change subject: KUDU-2245 Graceful leadership transfer ..