[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-05 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. KUDU-2290: Tool to re-create a tablet This adds a tool `kudu tablet un

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 11: Verified+1 IWYU failures are bogus (they break the build if they

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-05 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: KUDU-2290: Tool to re-create a tablet .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9393 To unsubscribe, visit http

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/93

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/9393/10/src/kud

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-05 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#11). Change subject: KUDU-2290: Tool to re-create a tablet ..

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 10: (1 comment) LGTM except a small nit! http://gerrit.cloudera.org:

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 10: Code-Review+1 I'd like Dan to take a look too. -- To view, visit

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-03 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#10). Change subject: KUDU-2290: Tool to re-create a tablet ..

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-03 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/9393/9/src/kudu

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/9393/9/src/kudu/in

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-03 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#9). Change subject: KUDU-2290: Tool to re-create a tablet ...

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9393/7/src/kudu

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9393/7/src/kudu/in

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-02 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#8). Change subject: KUDU-2290: Tool to re-create a tablet ...

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-04-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 7: (21 comments) Are you comfortable merging this given the risk of

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/9393/7/src/kudu/i

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 7: > Build Failed Unrelated, pre-existing race. See KUDU-2058. --

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#7). Change subject: KUDU-2290: Tool to re-create a tablet ...

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/9393/6/src/kudu

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 5: (13 comments) After discussion, I decided to take out the "quara

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#6). Change subject: KUDU-2290: Tool to re-create a tablet ...

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/9393/5/src/kudu/cl

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 5: (3 comments) I have reservations about how this patch introduces a

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 5: (14 comments) http://gerrit.cloudera.org:8080/#/c/9393/5//COMMIT_MS

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9393/4//COMMIT_

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-12 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#5). Change subject: KUDU-2290: Tool to re-create a tablet

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9393/4//COMMIT_MS

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 4: > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerr

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-12 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#4). Change subject: KUDU-2290: Tool to re-create a tablet

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/9393/2//COMMIT

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-11 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#3). Change subject: KUDU-2290: Tool to re-create a tablet

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-02-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/m

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-02-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9393/2/src/kudu/to

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-02-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 2: (5 comments) Mostly some nits and high-level points http://gerrit

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-02-22 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#2). Change subject: KUDU-2290: Tool to re-create a tablet .. KUDU-2290: Too

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 1: I think tidy bot is wrong about the using decls. -- To view, vi

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9393 Change subject: KUDU-2290: Tool to re-create a tablet .. KUDU-2290: Tool to re-create a tablet This adds a tool `kudu tablet replace_tab