[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-03-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9574 ) Change subject: KUDU-2295 fix nullptr dereference in Tablet .. KUDU-2295 fix nullptr dereference in Tablet Prior to this patch,

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-03-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9574 ) Change subject: KUDU-2295 fix nullptr dereference in Tablet .. Patch Set 2: > I agree with Todd that it would be good to have a test fo

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-03-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9574 ) Change subject: KUDU-2295 fix nullptr dereference in Tablet .. Patch Set 2: > > Would be nice to have a test for this in the codebase,

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-03-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9574 ) Change subject: KUDU-2295 fix nullptr dereference in Tablet .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-03-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9574 ) Change subject: KUDU-2295 fix nullptr dereference in Tablet .. Patch Set 2: I agree with Todd that it would be good to have a test for thi

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-03-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9574 ) Change subject: KUDU-2295 fix nullptr dereference in Tablet .. Patch Set 2: > Would be nice to have a test for this in the codebase, si

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-03-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9574 ) Change subject: KUDU-2295 fix nullptr dereference in Tablet .. Patch Set 2: Would be nice to have a test for this in the codebase, since

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9574 ) Change subject: KUDU-2295 fix nullptr dereference in Tablet .. Patch Set 2: Code-Review+1 Looks OK to me but would prefer another review s

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-03-10 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9574 to look at the new patch set (#2). Change subject: KUDU-2295 fix nullptr dereference in Tablet ..

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9574 Change subject: KUDU-2295 fix nullptr dereference in Tablet .. KUDU-2295 fix nullptr dereference in Tablet Prior to this patch, in the c

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-02-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/9350 ) Change subject: KUDU-2295 fix nullptr dereference in Tablet .. Abandoned Ah, I take it back -- the scoped_refptr consumes RefCountedThreadSafe,

[kudu-CR] KUDU-2295 fix nullptr dereference in Tablet

2018-02-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9350 Change subject: KUDU-2295 fix nullptr dereference in Tablet .. KUDU-2295 fix nullptr dereference in Tablet Prior to this patch, in the c