[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 18: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#18). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 17: (1 comment)

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 17: (1 comment)

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#17). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 16: > All the tests passed locally except ASAN. Failing on

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 16: Code-Review+1 (2 comments) Just some minor nits.

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 15: All the tests passed locally except ASAN. Failing on an

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#16). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 15: I'm sorry to have omitted this case! :( -- To view,

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 15: Code-Review+2 Leaving unmerged for Hao to take another

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-10 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 14: (2 comments)

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-10 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#15). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 14: (2 comments)

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

2019-01-10 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#14). Change subject: KUDU-2636: LBM supports deleting dead containers