[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-07-18 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 21: (10 comments) http://gerrit.cloudera.org:8080/#/c/13426/

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-07-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 21: (14 comments) There's not enough black box unit test

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-07-18 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#21). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-07-18 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 20: (33 comments) Thank you for your detailed comments, Adar

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-07-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 20: (35 comments) http://gerrit.cloudera.org:8080/#/c/13

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-07-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 20: (1 comment) Seems like Mike won't be able to get to

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-07-09 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#20). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-07-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/13426/17

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 19: Verified+1 The failed pre-commit looks like an unrel

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2797: the master aggregates tablet statistics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 19: Code-Review+1 (1 comment) http://gerrit.cloudera.or

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-26 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#19). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-25 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#18). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/13426/1

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 17: (3 comments) Thanks for making the change! http://

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-25 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#17). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/13426/15

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/134

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-24 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#16). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-24 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/13426/1

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 15: (5 comments) Looking good for the most part! I'm le

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-21 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#15). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-21 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#14). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-21 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 13: (12 comments) http://gerrit.cloudera.org:8080/#/c/13426/

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-20 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2797: the master aggregates tablet statistics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 13: (12 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-20 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#13). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-20 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#12). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-20 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/13426/11

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 11: (1 comment) Haven't looked in depth, but I left fee

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-19 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#11). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-19 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#10). Change subject: KUDU-2797: the master aggregates tablet statistics

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-19 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 9: (15 comments) sorry for the late update. http://gerrit.c

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/13426

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-13 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/13426

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/134

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/1342

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-12 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 9: (19 comments) http://gerrit.cloudera.org:8080/#/c/13426/9

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet statistics .. Patch Set 9: (20 comments) http://gerrit.cloudera.org:8080/#/c/134

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-12 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#9). Change subject: KUDU-2797: the master aggregates tablet statistics .

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-12 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#8). Change subject: KUDU-2797: the master aggregates tablet statistics .

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-11 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#7). Change subject: KUDU-2797: the master aggregates tablet statistics .