[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-22 Thread Maxim Smyatkin (Code Review)
Maxim Smyatkin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4800 Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. KUDU-78. Fix pb_util functions which return bool t

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4800/1//COMMIT_MSG Commit Messa

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4800/1/src/kudu/u

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4800/1//COMMIT_MSG Commit Messa

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-24 Thread Maxim Smyatkin (Code Review)
Maxim Smyatkin has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4800/1//COMMIT_MSG Commit M

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-24 Thread Maxim Smyatkin (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4800 to look at the new patch set (#2). Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4800/2/src/kudu/consensus/log.

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-25 Thread Maxim Smyatkin (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4800 to look at the new patch set (#3). Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-25 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 3: Code-Review+1 (1 comment) Nice cleanups, LGTM. http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status or void

2016-10-25 Thread Maxim Smyatkin (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4800 to look at the new patch set (#4). Change subject: KUDU-78. Fix pb_util functions which return bool to return Status or void .

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status or void

2016-10-25 Thread Maxim Smyatkin (Code Review)
Maxim Smyatkin has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status or void .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4800/3//COMMIT_MSG C

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status or void

2016-10-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status or void .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4800 To

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status or void

2016-10-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status or void .. KUDU-78. Fix pb_util functions which return bool to return Status or void As