[kudu-CR] Reduce arguments in file Read API

2017-05-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Reduce arguments in file Read API .. Reduce arguments in file Read API Because reads are now always read fully or result in an error if all bytes can’t be

[kudu-CR] Reduce arguments in file Read API

2017-05-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6770 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] Reduce arguments in file Read API

2017-05-02 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6770 to look at the new patch set (#7). Change subject: Reduce arguments in file Read API .. Reduce arguments in file Re

[kudu-CR] Reduce arguments in file Read API

2017-05-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/6/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc:

[kudu-CR] Reduce arguments in file Read API

2017-05-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/6/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: L

[kudu-CR] Reduce arguments in file Read API

2017-05-02 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6770 to look at the new patch set (#6). Change subject: Reduce arguments in file Read API .. Reduce arguments in file Re

[kudu-CR] Reduce arguments in file Read API

2017-05-02 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6770 to look at the new patch set (#5). Change subject: Reduce arguments in file Read API .. Reduce arguments in file Re

[kudu-CR] Reduce arguments in file Read API

2017-05-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc:

[kudu-CR] Reduce arguments in file Read API

2017-05-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: L

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc:

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: L

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.c

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6770 to look at the new patch set (#4). Change subject: Reduce arguments in file Read API .. Reduce arguments in file Re

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/env.h File src/kudu/util/env.h: Line 382:

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/env.h File src/kudu/util/env.h: Line 355:

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/env.h File src/kudu/util/env.h: PS3, Line 3

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/env.h File src/kudu/util/env.h: PS3, Line 3

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/env.h File src/kudu/util/env.h: PS3, Line 3

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reduce arguments in file Read API .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/env.h File src/kudu/util/env.h: Line 376:

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6770 to look at the new patch set (#3). Change subject: Reduce arguments in file Read API .. Reduce arguments in file Re

[kudu-CR] Reduce arguments in file Read API

2017-05-01 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6770 to look at the new patch set (#2). Change subject: Reduce arguments in file Read API .. Reduce arguments in file Re

[kudu-CR] Reduce arguments in file Read API

2017-04-30 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/6770 Change subject: Reduce arguments in file Read API .. Reduce arguments in file Read API Because reads are now always read fully or result i