[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: c++ client: stop requiring the old gcc ABI .. c++ client: stop requiring the old gcc ABI With the upgrade to clang 3.9 and the transition to libc++ for TS

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4515 To unsubscribe, visit h

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4515 To unsubscribe, visit http://gerri

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4515 To unsubscribe, visit http://gerri

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-28 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4515 to look at the new patch set (#2). Change subject: c++ client: stop requiring the old gcc ABI .. c++ client: stop r

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 1: (4 comments) > Do you think it's worth adding -Wabi option into the clang options > to emit warnings in

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 1: Do you think it's worth adding -Wabi warning flag into the clang options to catch possible ABI incomp

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 1: (1 comment) > Uploaded patch set 1. Do you think it's worth adding -Wabi option into the clang optio

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4515/1//COMMIT_MSG Commit Message: PS1, Line 12: The

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-21 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4515 to review the following change. Change subject: c++ client: stop requiring the old gcc ABI .. c++ client: