[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. catalog_manager: make ScopedTabletInfoCommitter generic

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 9: Code-Review+2 LGTM. Perhaps, you would like to

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-25 Thread Adar Dembo (Code Review)
Hello Mike Percy, Alexey Serbin, Dan Burkert, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#9). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ...

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 8: Code-Review+1 (3 comments) http://gerrit.cloud

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 8: Verified+1 Overriding Jenkins, the latest run hit

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-22 Thread Adar Dembo (Code Review)
Hello Mike Percy, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#8). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cl

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-20 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#7). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. cata

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/5/src/kudu/master/cat

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 6: Verified+1 Overriding Jenkins, unrelated test failures. -- To view, visit http://gerrit.cl

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/8089/5/src/kudu/master/catalog_manager.cc

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#6). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. cata

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 5: Code-Review+1 (4 comments) Spotted a few nits (sorry -- I didn't see them in prior passe

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 5: Verified+1 Overriding Jenkins, failure was KUDU-2059. -- To view, visit http://gerrit.clou

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#5). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. catal

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File src/

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File s

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File src/

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File s

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#4). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. catal

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File src

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File src/

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File s

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File src

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#3). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. catalog_manager: make ScopedTabletInfoCommitter generic I want to use it for TableInfo mutations, and to ma

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File s

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File sr

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: Verified+1 Overriding Jenkins, the only failure was an instance of KUDU-1521. -- To view,

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-17 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#2). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. catal

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

2017-09-17 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8089 to review the following change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ..