[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#10). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 9: (2 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 9: (2 comments) Looks good, just two typos.

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 9: Verified+1 An unrelated Java flaky. -- To

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: java/c++: ColumnSchema supports storing column comment .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12890 To

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#9). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#8). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 7: Yeah, i will rebase on master after this

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 7: Oh, I think you still need to rebase. -- To

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 7: Code-Review+1 LGTM but I will let Adar review

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 6: (5 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#7). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 6: Note: This has a merge conflict. You should

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 6: (5 comments) Thank you for all the work on this

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#6). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#5). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 4: (3 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 4: Sorry for quickly retriggering the builder :( -- To

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#4). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 3: (3 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#3). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-02 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 2: (3 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 2: (3 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-02 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#2). Change subject: java/c++: ColumnSchema supports storing column comment