[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: thirdparty: stifle unused argument warnings when building with clang .. thirdparty: stifle unused argument warnings when building with clang Dan tested m

[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: stifle unused argument warnings when building with clang .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4

[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

2016-09-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: stifle unused argument warnings when building with clang .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4514 To unsu

[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

2016-09-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: stifle unused argument warnings when building with clang .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4514 To unsu

[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

2016-09-28 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4514 to look at the new patch set (#2). Change subject: thirdparty: stifle unused argument warnings when building with clang ..

[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

2016-09-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: stifle unused argument warnings when building with clang .. Patch Set 1: Code-Review+2 looks good, although the build failure may be legit. -- To vi

[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

2016-09-21 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4514 to review the following change. Change subject: thirdparty: stifle unused argument warnings when building with clang