[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-17 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/1867/ -- To view, vis

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-17 Thread Sameer Abhyankar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2986 to look at the new patch set (#8). Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. ..

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 7: (21 comments) http://gerrit.cloudera.org:8080/#/c/2986/7/src/kudu/client/pr

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-10 Thread Sameer Abhyankar (Code Review)
Sameer Abhyankar has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 7: > > The main reason for not using unordered_set was because the > > co

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 7: > The main reason for not using unordered_set was because the > collection w

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-09 Thread Sameer Abhyankar (Code Review)
Sameer Abhyankar has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 7: (4 comments) Hi Adar - The latest PS should have the additional change

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-09 Thread Sameer Abhyankar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2986 to look at the new patch set (#7). Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. ..

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/1798/ -- To view, vis

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 6: (5 comments) Did you see my high-level comment about std::unordered_set vs.

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-09 Thread Sameer Abhyankar (Code Review)
Sameer Abhyankar has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 6: (20 comments) Thanks for the review Adar. All the additional changes y

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-09 Thread Sameer Abhyankar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2986 to look at the new patch set (#6). Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. ..

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/1797/ -- To view, vis

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 5: (20 comments) OK, finished reviewing everything except some of the hairier p

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-03 Thread Sameer Abhyankar (Code Review)
Sameer Abhyankar has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 5: (28 comments) Hey folks - I believe most of the changes that Adar had

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-03 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/1742/ -- To view, vis

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-03 Thread Sameer Abhyankar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2986 to look at the new patch set (#5). Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. ..

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-05-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 4: > Quick update ..I have finished making changes based on the review > so far