On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 511
https://reviews.apache.org/r/34193/diff/2/?file=963014#file963014line511
Since we're in an implementation file, we can `using
std::ostringstream;` and then
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84668
---
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34436/
---
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84746
---
Ship it!
src/tests/sched_tests.cpp
On April 25, 2015, 1:03 a.m., Chi Zhang wrote:
include/mesos/mesos.proto, lines 432-438
https://reviews.apache.org/r/32660/diff/3/?file=941248#file941248line432
maybe make it clear that delayed maps to capping; dropped maps to NIC
capacity exceeded?
I'm think the interpretation
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32660/
---
(Updated May 21, 2015, 6:06 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated May 21, 2015, 5:06 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/
---
(Updated May 21, 2015, 3:11 p.m.)
Review request for mesos, Isabel Jimenez,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34563/
---
(Updated May 21, 2015, 8:55 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34534/
---
(Updated May 21, 2015, 8:45 p.m.)
Review request for mesos and Bernd Mathiske.
On May 21, 2015, 7:26 p.m., Vinod Kone wrote:
src/slave/slave.cpp, line 3986
https://reviews.apache.org/r/34559/diff/1/?file=966887#file966887line3986
Can you add a comment here on why we forward periodically instead of
after every update?
Discussed with Vinod offline. It's hard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34306/#review84785
---
Ship it!
Ship It!
- Jie Yu
On May 21, 2015, 12:42 a.m., Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34565/
---
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-2762
On April 8, 2015, 7:46 p.m., Ian Downes wrote:
src/tests/port_mapping_tests.cpp, line 1788
https://reviews.apache.org/r/32664/diff/1/?file=911866#file911866line1788
Did you consider using iperf3 which makes all features available
through a library?
I looked at iperf3 but it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84791
---
Ship it!
src/tests/sched_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34563/
---
Review request for mesos and Joris Van Remoortere.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34559/
---
(Updated May 21, 2015, 9:26 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34559/#review84793
---
Ship it!
Ship It!
- Vinod Kone
On May 21, 2015, 9:26 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34563/#review84795
---
Ship it!
Ship It!
- Joris Van Remoortere
On May 21, 2015, 8:55
On May 20, 2015, 11:47 a.m., Alexander Rojas wrote:
src/examples/test_hook_module.cpp, lines 36-38
https://reviews.apache.org/r/34361/diff/1/?file=962951#file962951line36
This constants are used nowhere but in one method. Is there any reason
why they are not defined in the method
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34545/
---
(Updated May 21, 2015, 2:58 p.m.)
Review request for mesos, Adam B, Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34563/#review84815
---
Patch looks great!
Reviews applied: [34563]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34571/#review84817
---
include/mesos/mesos.proto
On May 21, 2015, 11:24 p.m., Jie Yu wrote:
include/mesos/mesos.proto, line 1189
https://reviews.apache.org/r/34571/diff/1/?file=968376#file968376line1189
This is a protocol between slave and the QoSController, both of which
are internal to Mesos. So we probably should move this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34431/
---
(Updated May 21, 2015, 11:32 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34571/
---
(Updated May 21, 2015, 4:02 p.m.)
Review request for mesos, Jie Yu, Niklas
On May 21, 2015, 11:24 p.m., Jie Yu wrote:
include/mesos/mesos.proto, lines 1189-1211
https://reviews.apache.org/r/34571/diff/1/?file=968376#file968376line1189
It reads weired when one wants to create a QoS correction (too many
words 'correction'):
```
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---
(Updated May 21, 2015, 11:31 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34278/
---
(Updated May 21, 2015, 11:45 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34277/
---
(Updated May 21, 2015, 11:45 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34321/#review84835
---
src/linux/routing/queueing/handle.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/#review84853
---
Ship it!
On May 22, 2015, 2:31 a.m., Benjamin Hindman wrote:
These are minor nits so I'll take care of them for you and commit this, thanks
Bernd!
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 22, 2015, 2:31 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34321/
---
(Updated May 22, 2015, 4:42 a.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review84766
---
Bad patch!
Reviews applied: [34321, 34426, 34321]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34427/#review84769
---
LGTM
- Paul Brett
On May 19, 2015, 6:46 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34559/#review84768
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34559/
---
Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34427/#review84771
---
src/slave/containerizer/provisioners/appc/bind_backend.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated May 21, 2015, 9:05 a.m.)
Review request for mesos, Adam B, Benjamin
On March 4, 2015, 4:03 p.m., Niklas Nielsen wrote:
Niklas Nielsen wrote:
Do you want this in? If so, please update the review :)
Ping - want this in? :)
- Niklas
---
This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/#review84724
---
Ship it!
Ship It!
- Niklas Nielsen
On May 19, 2015, 10:40 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review84726
---
Hey Adam, is this ready for review?
- Niklas Nielsen
On May 14,
On May 19, 2015, 6:53 p.m., Ben Mahler wrote:
Looks like we need to add a step for resolving the JIRA ticket (including
the commit message in a comment), if applicable?
Will add that later. Not sure if it belongs to this file, or we need to have a
new doc regarding the pratices we used
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34306/#review84743
---
Ship it!
Ship It!
- Niklas Nielsen
On May 20, 2015, 5:42 p.m.,
48 matches
Mail list logo
