Re: Review Request 34737: Added test to verify fix for MESOS-2771

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34737/#review85519 --- Patch looks great! Reviews applied: [34737] All tests passed. - M

Re: Review Request 34703: Added stream manipulators for the Time object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/#review85514 --- 3rdparty/libprocess/include/process/time.hpp

Re: Review Request 32664: Add port mapping isolator statistics tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32664/#review85512 --- Bad patch! Reviews applied: [32664] Failed command: ./support/appl

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/#review85511 --- Patch looks great! Reviews applied: [34558] All tests passed. - M

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review85499 --- Patch looks great! Reviews applied: [34687] All tests passed. - M

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ --- (Updated May 28, 2015, 2:37 a.m.) Review request for mesos, Jie Yu, Joris Van R

Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon K

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

> On May 28, 2015, 12:24 a.m., Vinod Kone wrote: > > src/examples/test_resource_estimator_module.cpp, lines 40-44 > > > > > > I'm confused. 'parameters' are unused and the passed 'flags' are empty? > > Niklas Nielsen w

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- (Updated May 28, 2015, 1:20 a.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34654: Send docker inspect output with TaskStatus data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34654/#review85489 --- Patch looks great! Reviews applied: [34654] All tests passed. - M

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

> On May 28, 2015, 12:24 a.m., Vinod Kone wrote: > > src/examples/test_resource_estimator_module.cpp, lines 40-44 > > > > > > I'm confused. 'parameters' are unused and the passed 'flags' are empty? > > Niklas Nielsen w

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

> On May 28, 2015, 12:24 a.m., Vinod Kone wrote: > > src/examples/test_resource_estimator_module.cpp, lines 40-44 > > > > > > I'm confused. 'parameters' are unused and the passed 'flags' are empty? > > Niklas Nielsen w

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

> On May 27, 2015, 5:24 p.m., Vinod Kone wrote: > > src/examples/test_resource_estimator_module.cpp, lines 40-44 > > > > > > I'm confused. 'parameters' are unused and the passed 'flags' are empty? TestResourceEstimator

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

> On May 28, 2015, 12:24 a.m., Vinod Kone wrote: > > src/tests/resource_estimator.hpp, line 39 > > > > > > How come we didn't have this problem with TestAllocator? Because there was no need for TestAllocator to make a

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/#review85473 --- src/examples/test_resource_estimator_module.cpp

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 34730: Added 'updateSlave()' in master to handle oversubscribed resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34730/#review85474 --- Ship it! Ship It! - Jie Yu On May 27, 2015, 11:11 p.m., Vinod Ko

Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.

> On May 27, 2015, 11:44 p.m., Jie Yu wrote: > > src/messages/messages.proto, lines 339-342 > > > > > > It might not be an issue right now, but once we start to support > > updating slave's total regular resources, ho

Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.

> On May 27, 2015, 11:59 p.m., Niklas Nielsen wrote: > > src/messages/messages.proto, lines 339-342 > > > > > > Would it make sense to send them independently, to distinguish between > > the two later on? That was an

Re: Review Request 34740: Add missing handle.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34740/#review85471 --- Ship it! Ship It! - Jie Yu On May 28, 2015, 12:01 a.m., Paul Bre

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- (Updated May 28, 2015, 12:04 a.m.) Review request for mesos, Jie Yu, Niklas Nie

Re: Review Request 34740: Add missing handle.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34740/#review85470 --- src/linux/routing/handle.hpp

Re: Review Request 34730: Added 'updateSlave()' in master to handle oversubscribed resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34730/#review85468 --- Ship it! Taken it is a stub patch src/master/master.cpp

Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.

> On May 27, 2015, 11:44 p.m., Jie Yu wrote: > > src/messages/messages.proto, lines 339-342 > > > > > > It might not be an issue right now, but once we start to support > > updating slave's total regular resources, ho

Review Request 34740: Add missing handle.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34740/ --- Review request for mesos. Repository: mesos Description --- Add missing

Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/#review85466 --- We should probably follow up with a test which verifies that the sum

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 27, 2015, 11:56 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/#review85463 --- src/messages/messages.proto

Re: Review Request 34729: Updated slave to send total amount of oversubscribed resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/#review85462 --- Ship it! Ship It! - Jie Yu On May 27, 2015, 11:11 p.m., Vinod Ko

Re: Review Request 34724: Doxygen enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34724/#review85460 --- Ship it! Awesome! Doxyfile

Re: Review Request 34737: Added test to verify fix for MESOS-2771

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34737/ --- (Updated May 27, 2015, 4:14 p.m.) Review request for mesos, Ian Downes, Jie Yu,

Review Request 34737: Added test to verify fix for MESOS-2771

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34737/ --- Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone. Repository: mesos

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review85456 --- Disk usage by the store is currently unbounded. Do we need to add t

Review Request 34736: Implemented 'updateSlave()' call in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34736/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and Niklas Nielsen. Bug

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review85454 --- Looks good. I'll commit this patch now. - Jie Yu On May 27, 2015,

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/#review85413 --- Do you want to wire up module loading in src/slave/resource_estimato

Re: Review Request 34141: AppC provsioning backend.

> On May 18, 2015, 4:38 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/backend.hpp, line 50 > > > > > > Not a big deal, but would it be more flexible for Bankend to take a > > rootImage as an argu

Re: Review Request 32664: Add port mapping isolator statistics tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32664/ --- (Updated May 27, 2015, 9:04 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/ --- (Updated May 27, 2015, 9:03 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34676: Add printing of extended attributes to Resource objects.

> On May 26, 2015, 8:57 p.m., Vinod Kone wrote: > > src/common/resources.cpp, line 1160 > > > > > > Lets use something other than "*", since we already abuse it to > > represent the default role and unreserved resour

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 27, 2015, 8:54 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

> On May 27, 2015, 6:50 p.m., Vinod Kone wrote: > > src/linux/routing/queueing/handle.hpp, line 69 > > > > > > why protected when you have a get()? It was protected in the merged filter::Handle. - Paul

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/#review85435 --- Ship it! Ship It! - Vinod Kone On May 27, 2015, 7:05 p.m., Paul

Re: Review Request 34728: Changed callbacks to take copies rather than references in monitor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34728/#review85426 --- Ship it! Ship It! - Ian Downes On May 27, 2015, 12:43 p.m., Nikl

Re: Review Request 34728: Changed callbacks to take copies rather than references in monitor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34728/ --- (Updated May 27, 2015, 12:43 p.m.) Review request for mesos, Ian Downes, Jie Yu

Review Request 34730: Added 'updateSlave()' in master to handle oversubscribed resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34730/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-2733 https://issue

Review Request 34729: Updated slave to send total amount of oversubscribed resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34729/ --- Review request for mesos, Niklas Nielsen and Brian Wickman. Bugs: MESOS-2770

Re: Review Request 34676: Add printing of extended attributes to Resource objects.

> On May 26, 2015, 8:57 p.m., Vinod Kone wrote: > > src/common/resources.cpp, line 1160 > > > > > > Lets use something other than "*", since we already abuse it to > > represent the default role and unreserved resour

Re: Review Request 33876: Added usages() to resource monitor

> On May 11, 2015, 3:49 p.m., Jie Yu wrote: > > src/slave/monitor.cpp, line 126 > > > > > > Hum, this looks like a bug to me? Since you capture `containerId` by > > reference, what if by the time `onFailed` is called,

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/#review85420 --- Patch looks great! Reviews applied: [34662] All tests passed. - M

Review Request 34728: Changed callbacks to take copies rather than references in monitor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34728/ --- Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone. Repository: mesos

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/ --- (Updated May 27, 2015, 7:05 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34676: Add printing of extended attributes to Resource objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34676/#review85417 --- src/common/resources.cpp

Re: Review Request 33876: Added usages() to resource monitor

> On May 11, 2015, 3:49 p.m., Jie Yu wrote: > > src/slave/monitor.cpp, line 126 > > > > > > Hum, this looks like a bug to me? Since you capture `containerId` by > > reference, what if by the time `onFailed` is called,

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review85405 --- src/Makefile.am

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

> On May 27, 2015, 6:21 p.m., Vinod Kone wrote: > > What's the motivation for pulling out these constatns to the file scope > > instead of class scope as it was before? I don't follow what you mean by > > "easier sharing". I want to use them in later tests outside the PortMappingIsolatorTest s

Re: Review Request 34724: Doxygen enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34724/ --- (Updated May 27, 2015, 11:38 a.m.) Review request for mesos, Ben Mahler, Joerg

Review Request 34724: Doxygen enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34724/ --- Review request for mesos, Ben Mahler, Joerg Schad, and Marco Massenzio. Reposit

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/#review85402 --- What's the motivation for pulling out these constatns to the file sc

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 34431: Add htb queueing discipline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/#review85400 --- Bad patch! Reviews applied: [34321, 34426] Failed command: ./suppo

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/ --- (Updated May 27, 2015, 6:07 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/ --- (Updated May 27, 2015, 6:05 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 27, 2015, 6:05 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34654: Send docker inspect output with TaskStatus data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34654/#review85390 --- Ship it! This looks good but I'd like to can clean up the 'output'

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 27, 2015, 5:47 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Review Request 34720: Added kill executor correction to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34720/ --- Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod

Review Request 34719: Added QOS_KILLED as status reason

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34719/ --- Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod

Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

> On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote: > > src/common/protobuf_utils.cpp, line 169 > > > > > > We have traditionally used stringify(...) if we needed type T to string > > conversions. Have you checked if

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/ --- (Updated May 27, 2015, 5:23 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

> On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote: > > src/common/protobuf_utils.hpp, line 83 > > > > > > Shouldn't parse() go in > > https://github.com/apache/mesos/blob/master/src/common/parse.hpp? I don't really k

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? Ping. Did you

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

Thx, found the issue (: 2015-05-27 8:39 GMT-07:00 Niklas Nielsen : > +1 to Vinod's suggestion. The buildbot does a dist build, so also make > sure new public headers are in src/Makefile.am > > On 27 May 2015 at 08:32, Vinod Kone wrote: > >> You likely forgot to add the file to your patch. >> >>

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review85384 --- Patch looks great! Reviews applied: [34392, 34703, 30032] All test

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- (Updated May 27, 2015, 4:34 p.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34703: Added stream manipulators for the Time object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/ --- (Updated May 27, 2015, 5:46 p.m.) Review request for mesos, Bernd Mathiske, Mic

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

+1 to Vinod's suggestion. The buildbot does a dist build, so also make sure new public headers are in src/Makefile.am On 27 May 2015 at 08:32, Vinod Kone wrote: > You likely forgot to add the file to your patch. > > @vinodkone > > > On May 27, 2015, at 2:08 AM, Bartek Plotka wrote: > > > > > >

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

You likely forgot to add the file to your patch. @vinodkone > On May 27, 2015, at 2:08 AM, Bartek Plotka wrote: > > > >>> On May 27, 2015, 9 a.m., Mesos ReviewBot wrote: >>> Bad patch! >>> >>> Reviews applied: [34662] >>> >>> Failed command: make -j3 distcheck >>> >>> Error: >>> make dis

Re: Review Request 34703: Added stream manipulators for the Time object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/#review85380 --- 3rdparty/libprocess/include/process/time.hpp

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

> On May 26, 2015, 6:15 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 334 > > > > > > s/class/value > > ? Removed format from here. > On May 26, 2015, 6:15 p.m., Bernd Mathis

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated May 27, 2015, 4:50 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 34703: Added stream manipulators for the Time object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/ --- (Updated May 27, 2015, 4:48 p.m.) Review request for mesos, Bernd Mathiske, Mic

Re: Review Request 34703: Added stream manipulators for the Time object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/#review85364 --- Patch looks great! Reviews applied: [34392, 34703] All tests passe

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

> On May 20, 2015, 7:10 a.m., Nikita Vetoshkin wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 352 > > > > > > strftime formatting is locale dependent. This example > > ``` > > #include > >

Review Request 34703: Added stream manipulators for the Time object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/ --- Review request for mesos, Bernd Mathiske, Michael Park, Nikita Vetoshkin, and Ti

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review85340 --- Patch looks great! Reviews applied: [34687] All tests passed. - M

Re: Review Request 34529: Add non-const reference version of Option::get.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/#review85338 --- Patch looks great! Reviews applied: [34529] All tests passed. - M

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

> On May 27, 2015, 9 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [34662] > > > > Failed command: make -j3 distcheck > > > > Error: > > make dist-gzip am__post_remove_distdir='@:' > > make[1]: Entering directory > > `/home/jenkins/jenkins-slave/workspace/mesos-review

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/#review85336 --- Bad patch! Reviews applied: [34662] Failed command: make -j3 distc

Re: Review Request 34676: Add printing of extended attributes to Resource objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34676/#review85335 --- Patch looks great! Reviews applied: [34676] All tests passed. - M

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

> On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote: > > src/Makefile.am, line 1387 > > > > > > Is the alignment right here? Try to set your tabstop to 8 :) > > Also, shouldn't the ordering bring this further down?

Re: Review Request 30643: Optionally specify executor for "mesos execute".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/#review85332 --- Patch looks great! Reviews applied: [30643] All tests passed. - M

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

> On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote: > > Hey Marco, > > > > First pass: One high-level question to your patch: Could we reuse > > JSON::Protobuf() to some of the modeling? > > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.h