---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/
---
(Updated June 3, 2015, 7:36 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34863/#review86474
---
Patch looks great!
Reviews applied: [34832, 34426, 34863]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34687/#review86453
---
Looking much better! :)
A few suggestions below and let's get this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32757/
---
(Updated June 3, 2015, 11:05 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35038/#review86518
---
LGTM modulo Jie's comment on the hard check
- Niklas Nielsen
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35033/#review86528
---
Patch looks great!
Reviews applied: [35033]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/
---
(Updated June 3, 2015, 9:16 p.m.)
Review request for mesos, Jie Yu, Niklas
On June 3, 2015, 9:06 p.m., Niklas Nielsen wrote:
Do you want to add a test to verify that this works? :)
Definitely will do that in next patch (:
- Bartek
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34633/#review86508
---
Ship it!
src/tests/oversubscription_tests.cpp
On June 3, 2015, 5:54 p.m., Bartek Plotka wrote:
include/mesos/slave/qos_controller.hpp, line 52
https://reviews.apache.org/r/34631/diff/3/?file=977207#file977207line52
Small thing:
s/type/name/ ..to be consistent with allocator factory. (:
What is the reason of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34687/#review86482
---
Patch looks great!
Reviews applied: [34687]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34318/#review86487
---
Ship it!
Ship It!
- Timothy Chen
On May 25, 2015, 4:36 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35033/
---
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86497
---
src/slave/resource_estimators/noop.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32755/
---
(Updated June 3, 2015, 11 p.m.)
Review request for mesos, Ian Downes and Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/
---
Review request for mesos and Ben Mahler.
Repository: mesos
Description
On June 3, 2015, 10:54 a.m., Bartek Plotka wrote:
include/mesos/slave/qos_controller.hpp, line 52
https://reviews.apache.org/r/34631/diff/3/?file=977207#file977207line52
Small thing:
s/type/name/ ..to be consistent with allocator factory. (:
What is the reason of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35024/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-2776
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34863/#review86494
---
Ship it!
Ship It!
- Jie Yu
On June 3, 2015, 9:20 p.m., Paul
On April 8, 2015, 6:44 p.m., Ian Downes wrote:
src/tests/memory_test_helper.cpp, lines 191-194
https://reviews.apache.org/r/32755/diff/1/?file=913063#file913063line191
What happens to this test if /tmp is a tmpfs? Do the cache pages get
accounted differently
Tested with /tmp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32754/
---
(Updated June 3, 2015, 10:59 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35024/#review86505
---
Ship it!
Ship It!
- Vinod Kone
On June 3, 2015, 10:08 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34317/#review86506
---
Greg can you rebase your patches on latest master and update the
On June 3, 2015, 11:30 p.m., Vinod Kone wrote:
src/slave/resource_estimators/fixed.cpp, line 47
https://reviews.apache.org/r/35028/diff/1/?file=977721#file977721line47
Since the slave now asks the estimator everytime it wants to forward an
update and doesn't store a cached value,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/
---
(Updated June 4, 2015, 12:08 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35038/#review86514
---
Ship it!
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35033/
---
(Updated June 3, 2015, 3:53 p.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34894/#review86503
---
Patch looks great!
Reviews applied: [34894]
All tests passed.
-
On April 8, 2015, 6:44 p.m., Ian Downes wrote:
src/tests/memory_test_helper.cpp, lines 297-300
https://reviews.apache.org/r/32757/diff/1/?file=913069#file913069line297
What happens to this test if /tmp is a tmpfs?
Yeah, with /tmp mounted as tmpfs, 'writeback' is 0.
To account for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/#review86507
---
src/slave/resource_estimators/fixed.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/#review86493
---
Ship it!
src/linux/routing/queueing/internal.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34631/#review86499
---
Ship it!
include/mesos/slave/qos_controller.hpp
On April 8, 2015, 6:44 p.m., Ian Downes wrote:
src/tests/memory_test_helper.hpp, lines 69-70
https://reviews.apache.org/r/32756/diff/1/?file=913065#file913065line69
How does this tie into the timing loop above in the test? Do we know
within what time the kernel will mark pages
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/#review86502
---
LGTM :)
src/Makefile.am
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/
---
(Updated June 3, 2015, 10:21 p.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35033/#review86498
---
Ship it!
Ship It!
- Jie Yu
On June 3, 2015, 10:53 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34632/#review86501
---
LGTM overall. Just one place (regarding the time when we start to
On June 3, 2015, 11:44 p.m., Jie Yu wrote:
Also, could you please adjust the comments above the public resource estimator
'oversubscribable()' interface since we incur a minimal interval in the slave?
- Jie
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86366
---
Patch looks great!
Reviews applied: [34962, 34980]
All tests
On June 3, 2015, 4:38 a.m., Marco Massenzio wrote:
Hi Alex - I noticed the new 'code drop' but none of the comments were
addressed in the new diff: is something missing?
Thanks!
The code drop was just a rebasing, I'm slowly getting to all my old patches.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34984/
---
Review request for mesos, Niklas Nielsen and Vinod Kone.
Bugs: MESOS-2277
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review86379
---
Patch looks great!
Reviews applied: [34976]
All tests passed.
-
On June 3, 2015, 5:29 a.m., Adam B wrote:
docs/getting-started.md, line 24
https://reviews.apache.org/r/34976/diff/1/?file=977149#file977149line24
Can you merge this in with the Ubuntu 12.04 instructions below? I don't
think they're drastically different, and we can probably
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34984/#review86374
---
Patch looks great!
Reviews applied: [34984]
All tests passed.
-
On May 29, 2015, 7:23 p.m., Vinod Kone wrote:
src/tests/oversubscription_tests.cpp, line 117
https://reviews.apache.org/r/34633/diff/1/?file=970999#file970999line117
Why not implement the TODO?
s/AWAIT_READY(received)/AWAIT_ASSERT_EQ(expected, received)/ ?
Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32360/
---
(Updated June 3, 2015, 5:16 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34534/#review86433
---
docs/configuration.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35012/
---
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32364/
---
(Updated June 3, 2015, 5:19 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35000/#review86404
---
3rdparty/libprocess/include/process/subprocess.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32356/
---
(Updated June 3, 2015, 5:11 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/
---
(Updated June 4, 2015, 1:19 a.m.)
Review request for mesos, Chi Zhang, Ian
On June 3, 2015, 10:54 a.m., Bartek Plotka wrote:
include/mesos/slave/qos_controller.hpp, line 52
https://reviews.apache.org/r/34631/diff/3/?file=977207#file977207line52
Small thing:
s/type/name/ ..to be consistent with allocator factory. (:
What is the reason of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34832/
---
(Updated June 3, 2015, 6:25 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34832/#review86458
---
Ship it!
src/tests/routing_tests.cpp
On June 3, 2015, 10:35 p.m., Jie Yu wrote:
src/linux/routing/queueing/internal.hpp, line 320
https://reviews.apache.org/r/34426/diff/11/?file=977689#file977689line320
Why =?
The definition for RTNL_TC_STATS_MAX comes from libnl and looks like this:
enum rtnl_tc_stat {
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34534/#review86440
---
Ship it!
Ship It!
- Timothy Chen
On June 3, 2015, 5:23 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86441
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34631/#review86447
---
include/mesos/slave/qos_controller.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34910/#review86449
---
Can we make the test a unit test? Looks like we could pull up
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review86442
---
docs/home.md
https://reviews.apache.org/r/33241/#comment138454
61 matches
Mail list logo
