Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35438/#review87895 --- src/tests/fetcher_cache_tests.cpp

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87885 --- 3rdparty/libprocess/include/process/address.hpp

Re: Review Request 35441: Removed unused macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35441/#review87878 --- Patch looks great! Reviews applied: [35441] All tests passed. - M

Review Request 35441: Removed unused macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35441/ --- Review request for mesos and Niklas Nielsen. Repository: mesos Description --

Re: Review Request 14309: Properly get gethostbyname2_r error on OS X.

> On June 12, 2015, 10:47 p.m., Niklas Nielsen wrote: > > BenH: Still want this in? I'll do one better, since these macros are no longer used I'll just remove all of that code! See https://reviews.apache.org/r/35441. - Benjamin --- Thi

Re: Review Request 35000: Doxygen'ized Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35000/ --- (Updated June 14, 2015, 5:17 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 35000: Doxygen'ized Subprocess.

> On June 4, 2015, 10:20 a.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 141 > > > > > > Suggestion: maybe we should add what structure this "status" has. It is > > propagated

Re: Review Request 35129: Refactor Future::Data to use Result. Remove dynamic allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35129/#review87872 --- Patch looks great! Reviews applied: [35129] All tests passed. - M

Re: Review Request 35129: Refactor Future::Data to use Result. Remove dynamic allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35129/ --- (Updated June 14, 2015, 4:17 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 35439: Updated documentation for CentOS 6 and 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35439/#review87869 --- Ship it! Ship It! - Benjamin Hindman On June 14, 2015, 3:30 p.m.

Review Request 35439: Updated documentation for CentOS 6 and 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35439/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35438/#review87866 --- Patch looks great! Reviews applied: [35438] All tests passed. - M

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

> On June 9, 2015, 6:11 p.m., Vinod Kone wrote: > > src/tests/fetcher_cache_tests.cpp, lines 201-207 > > > > > > While this looks good as a temporary fix, what is the long term > > strategy here? > > > > I re

Re: Review Request 34943: Added validation to flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/ --- (Updated June 14, 2015, 1:55 p.m.) Review request for mesos. Changes ---

Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35438/ --- Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone. Repos

Re: Review Request 34943: Added validation to flags.

> On June 11, 2015, 6:45 p.m., Ben Mahler wrote: > > This patch is mixing changes across libprocess, stout, and mesos.. :) It just hadn't been rebased. Fixed now. - Benjamin --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 34943: Added validation to flags.

> On June 11, 2015, 4:43 p.m., Jojy Varghese wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 516 > > > > > > Style comment: Default captures are considered stylistically bad. > > Capt

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

Vinod, I am working on it. I reckon this will work: s/Return()/DeclineOffers() I’ll prepare a RR with this, that also fixes the CHECK the way Jie proposed. Bernd > On Jun 12, 2015, at 8:59 PM, Vinod Kone wrote: > > This is an automatically generated e-mail. To reply, > visit:https://reviews

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87858 --- Ship it! This looks good Joris! Thans for all the hard work, iterat

Re: Review Request 35432: Enable move semantics for Future and Promise.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35432/#review87854 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 9:26 p.m.

Re: Review Request 35433: CHECK that checkpointed resources exist on the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review87857 --- Just so I understand, does this mean if we happen to get in the unfo

Re: Review Request 35253: Enable configure to detect libevent and openssl on Mac OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35253/#review87856 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 2:32 p.m.

Re: Review Request 35431: Enable Option to hold a noncopyable type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35431/#review87855 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 8:57 p.m.