---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36036/#review89876
---
Ship it!
Ship It!
- Isabel Jimenez
On June 30, 2015, 6:28 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36040/
---
Review request for mesos, Anand Mazumdar, Marco Massenzio, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/
---
(Updated June 30, 2015, 9:07 a.m.)
Review request for mesos, Anand Mazumdar,
On June 30, 2015, 6:08 a.m., Adam B wrote:
Minor points, but otherwise shippable.
I guess I'm still a little confused by the motivation. When would the
firewall filter rule have more information about how to respond than the
caller would? Can you give an example?
The idea is to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/
---
Review request for mesos.
Repository: mesos
Description
---
The
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---
(Updated June 30, 2015, 8:29 a.m.)
Review request for mesos, Adam B and Jie
On June 30, 2015, 7:26 a.m., Adam B wrote:
Looks good to me, but I'll let Vinod give the final approval.
I was wondering if there could be any upgrade issues, but I don't think so,
since it's an optional field and we aren't even reading reading it
anywhere, just setting it for new
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---
(Updated June 30, 2015, 8:30 a.m.)
Review request for mesos, Adam B and Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36068/
---
(Updated June 30, 2015, 5:33 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36072/
---
Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/#review8
---
Patch looks great!
Reviews applied: [36041]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/#review89984
---
Ship it!
Ship It!
- Joris Van Remoortere
On June 30, 2015,
On June 30, 2015, 6:48 p.m., Vinod Kone wrote:
This is an API change! Before embarking on this change, it's prudent to get
feedback from the community on acceptable semantics (e.g., what do popular
metric collectors do if they encounter 302 redirect? do they ignore the
value or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/
---
(Updated July 1, 2015, 12:14 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/
---
(Updated June 30, 2015, 5:32 p.m.)
Review request for mesos, Adam B and Joris
On June 30, 2015, 11:48 a.m., Vinod Kone wrote:
This is an API change! Before embarking on this change, it's prudent to get
feedback from the community on acceptable semantics (e.g., what do popular
metric collectors do if they encounter 302 redirect? do they ignore the
value or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36056/#review90003
---
Patch looks great!
Reviews applied: [36056]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36071/
---
Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/
---
(Updated July 1, 2015, 1:43 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36074/
---
(Updated July 1, 2015, 2:26 a.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36078/
---
Review request for mesos, Adam B, Benjamin Hindman, and Ben Mahler.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35857/
---
(Updated July 1, 2015, 5:26 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31207/#review89893
---
Ship it!
3rdparty/libprocess/src/process.cpp (line 1380)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/#review90006
---
Patch looks great!
Reviews applied: [35799]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36077/
---
Review request for mesos, Ben Mahler, Jie Yu, and Marco Massenzio.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35856/
---
(Updated July 1, 2015, 5:25 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/#review90008
---
Patch looks great!
Reviews applied: [36061]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36078/#review90009
---
include/mesos/scheduler/scheduler.proto (lines 297 - 304)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36071/#review90010
---
Bad patch!
Reviews applied: [36071]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35855/
---
(Updated July 1, 2015, 5:24 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36018/#review89894
---
Ship it!
I added a comment for posterity that explains why it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---
(Updated June 30, 2015, 4:56 p.m.)
Review request for mesos, Adam B and Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review89945
---
This is an API change! Before embarking on this change, it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/#review89943
---
Thanks Marco! This is a great change for our users!
On June 30, 2015, 4:24 p.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, line 777
https://reviews.apache.org/r/36040/diff/1/?file=995839#file995839line777
What is this change intending to solve ? If it's the ability to not
close the connection for streamed responses.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36056/
---
(Updated June 30, 2015, 4:53 p.m.)
Review request for mesos, Adam B and Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/
---
Review request for mesos, Adam B and Joris Van Remoortere.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36040/#review89909
---
3rdparty/libprocess/src/http.cpp (line 777)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36056/
---
Review request for mesos, Adam B and Jie Yu.
Bugs: MESOS-2603
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36003/
---
(Updated June 30, 2015, 6:41 p.m.)
Review request for mesos, Adam B and
On June 30, 2015, 6:01 p.m., Vinod Kone wrote:
src/common/protobuf_utils.cpp, line 145
https://reviews.apache.org/r/36036/diff/1/?file=995699#file995699line145
We should've added a comment on this method that this is only used by
the StandaloneMasterDetector (used in tests and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36003/#review89949
---
Ship it!
Ship It!
- Adam B
On June 30, 2015, 11:41 a.m., Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35919/#review89880
---
Patch looks great!
Reviews applied: [35919]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36068/
---
Review request for mesos, Adam B, Benjamin Hindman, and Artem Harutyunyan.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/#review89977
---
This looks good, Isabel!
Just a few nits about error messages and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30643/#review89976
---
Ship it!
Ship It!
src/cli/execute.cpp (line 101)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/
---
(Updated June 30, 2015, 11:34 p.m.)
Review request for mesos, Adam B and Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35874/#review89982
---
Hi Alex,
I just wanted to follow up on our conversation.
As
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36036/
---
(Updated June 30, 2015, 11:23 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34135/#review89974
---
src/slave/containerizer/isolators/filesystem/linux.cpp (line 216)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34137/#review89975
---
src/slave/containerizer/mesos/containerizer.cpp (line 626)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35755/
---
(Updated June 30, 2015, 4:24 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36024/
---
(Updated June 30, 2015, 4:25 p.m.)
Review request for mesos and Joris Van
On June 30, 2015, 6:48 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/src/process.cpp, lines 899-902
https://reviews.apache.org/r/36061/diff/1/?file=996141#file996141line899
1. Did you choose to `LOG(ERROR)` followed by `exit(EXIT_FAILURE)` for
a specific reason?
I
54 matches
Mail list logo