Re: Review Request 36954: Performed a self bind mount of rootfs itself in fs::chroot::enter().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36954/#review93702 --- Ship it! src/linux/fs.cpp (lines 515 - 516)

Re: Review Request 36954: Performed a self bind mount of rootfs itself in fs::chroot::enter().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36954/#review93703 --- Ship it! Ship It! - Timothy Chen On July 30, 2015, 10:09 p.m., J

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/#review93704 --- src/tests/fetcher_tests.cpp (line 343)

Review Request 36978: MESOS-3142 Refactoring os::shell - patch 1/2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36978/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-3142 https://iss

Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/ --- Review request for mesos. Bugs: MESOS-3142 https://issues.apache.org/jira/b

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

> On July 31, 2015, 7:39 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_tests.cpp, line 343 > > > > > > This change seems to eliminate the essence of the test, namely the > > leading white space. There are two U

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review93709 --- Patch looks great! Reviews applied: [36978, 36979] All tests passe

Review Request 36987: Extend 'getFormValue' -> 'getFormValues' to handle invalid input uniformly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36987/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- S

Re: Review Request 36987: Extend 'getFormValue' -> 'getFormValues' to parse input uniformly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36987/ --- (Updated July 31, 2015, 3:12 p.m.) Review request for mesos and Jie Yu. Summa

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

> On July 31, 2015, 12:39 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_tests.cpp, line 343 > > > > > > This change seems to eliminate the essence of the test, namely the > > leading white space. > > Klaus Ma w

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/ --- (Updated July 31, 2015, 8:23 a.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36987: Extend 'getFormValue' -> 'getFormValues' to parse input uniformly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36987/#review93727 --- Bad patch! Reviews applied: [36040, 35934, 35939, 35947, 35702, 359

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/#review93728 --- Ship it! Ship It! - haosdent huang On July 31, 2015, 3:23 p.m.,

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/#review93733 --- Patch looks great! Reviews applied: [36946] All tests passed. - M

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/ --- (Updated July 31, 2015, 8:54 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 36999: Libprocess: Added missing libevent_ssl_socket.hpp to Makefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36999/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/ --- (Updated July 31, 2015, 8:55 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/ --- (Updated July 31, 2015, 9:02 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

> On July 21, 2015, 9:17 p.m., Vinod Kone wrote: > > did you also test with ubuntu? > > Vinod Kone wrote: > any updates on this? Sorry this took a while. It turned out I needed a solution to MESOS-781 to get this to work correctly. I ran the test with: `OS="centos:7" COMPILER="gcc" CONFIG

Review Request 37000: Refactor Subprocess logic in linux/perf.cpp to use common subroutine.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37000/ --- Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Cong Wang. Bugs:

Re: Review Request 36999: Libprocess: Added missing libevent_ssl_socket.hpp to Makefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36999/#review93786 --- Ship it! 3rdparty/libprocess/Makefile.am (lines 81 - 82)

Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/#review93787 --- Ship it! Ship It! - Vinod Kone On July 31, 2015, 9:02 p.m., Jori

Re: Review Request 36829: Stout: Introduced configurable `UNIMPLEMENTED()` macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36829/ --- (Updated July 31, 2015, 9:53 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36830: Libprocess: Introduced configurable `UNIMPLEMENTED` macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36830/ --- (Updated July 31, 2015, 9:53 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36842: Mesos: Introduce configurable `UNIMPLEMENTED` macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36842/ --- (Updated July 31, 2015, 9:54 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36987: Extend 'getFormValue' -> 'getFormValues' to parse input uniformly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36987/ --- (Updated July 31, 2015, 9:56 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated July 31, 2015, 9:56 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/ --- (Updated July 31, 2015, 9:57 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated July 31, 2015, 9:57 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, line 507 > > > > > > The code until this line is basically request validation and > > authorization. Though it's not how we do it now,

Re: Review Request 36930: Forced the network isolator to use the mount namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36930/ --- (Updated July 31, 2015, 10:23 p.m.) Review request for mesos, Chi Zhang and Vin

Re: Review Request 36956: Created a test abstraction for preparing test rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36956/ --- (Updated July 31, 2015, 10:23 p.m.) Review request for mesos, Ian Downes, Timot

Re: Review Request 36929: Fixed a few issues in test launcher header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36929/ --- (Updated July 31, 2015, 10:23 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 36954: Performed a self bind mount of rootfs itself in fs::chroot::enter().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36954/ --- (Updated July 31, 2015, 10:23 p.m.) Review request for mesos, Ian Downes, Timot

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/#review93802 --- Patch looks great! Reviews applied: [36987, 35702, 35983, 35984] A

Re: Review Request 36830: Libprocess: Introduced configurable `UNIMPLEMENTED` macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36830/#review93803 --- Ship it! Ship It! - Michael Park On July 31, 2015, 9:53 p.m., Jo

Re: Review Request 36842: Mesos: Introduce configurable `UNIMPLEMENTED` macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36842/#review93804 --- Ship it! Ship It! - Michael Park On July 31, 2015, 9:54 p.m., Jo

Re: Review Request 36829: Stout: Introduced configurable `UNIMPLEMENTED()` macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36829/#review93806 --- Ship it! `s/UNIMPLEMENTED()/UNIMPLEMENTED/` -- I'll fix this before

Re: Review Request 36712: Added ONCE guard for Eventloop::initialize

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36712/#review93808 --- Ship it! Ship It! - Michael Park On July 23, 2015, 12:17 a.m., J

Review Request 37007: Pass ExecutorID to task-status label decorator hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Niklas Nielsen. Bugs: M

Re: Review Request 36842: Mesos: Introduce configurable `UNIMPLEMENTED` macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36842/#review93823 --- configure.ac (lines 1560 - 1561)

Re: Review Request 36842: Mesos: Introduce configurable `UNIMPLEMENTED` macro.

> On Aug. 1, 2015, 12:22 a.m., Ben Mahler wrote: > > configure.ac, lines 1560-1561 > > > > > > Hm.. coming across this I can't tell how this works, mind adding a > > comment? > > > > The following seems li

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/#review93825 --- Patch looks great! Reviews applied: [37007] All tests passed. - M

Review Request 37010: stout: Removed unused 'fatal' and 'fatalerror' macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37010/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 37012: mesos: Removed unused 'fatal' and 'fatalerror' macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37012/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 37011: libprocess: Removed unused 'fatal' and 'fatalerror' macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37011/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/#review93827 --- include/mesos/hook.hpp (line 89)

Re: Review Request 37012: mesos: Removed unused 'fatal' and 'fatalerror' macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37012/#review93830 --- Patch looks great! Reviews applied: [37010, 37011, 37012] All test

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/ --- (Updated Aug. 1, 2015, 12:24 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

> On July 31, 2015, 10:22 p.m., Michael Park wrote: > > src/slave/slave.cpp, lines 2740-2743 > > > > > > Why did this have to move? I guess we want the `update` within the `if > > (executor == NULL)` statement bloc

Re: Review Request 37011: libprocess: Removed unused 'fatal' and 'fatalerror' macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37011/#review93832 --- Ship it! Ship It! - Artem Harutyunyan On July 31, 2015, 7:10 p.m

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/#review93834 --- Patch looks great! Reviews applied: [37007] All tests passed. - M