Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-08-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/#review93834 --- Patch looks great! Reviews applied: [37007] All tests passed. -

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-08-01 Thread haosdent huang
On Aug. 1, 2015, 5:07 p.m., Timothy Chen wrote: src/hook/manager.cpp, line 187 https://reviews.apache.org/r/36185/diff/4/?file=1008885#file1008885line187 From the hook signature it seems like we make not distinction between launching a custom executor or a task. I

Re: Review Request 36814: Use executor in mesos-execute.

2015-08-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36814/ --- (Updated Aug. 1, 2015, 5:49 p.m.) Review request for mesos, Adam B and Ben

Re: Review Request 36814: Fill executor_id in state.json when task is run in CommandExecutor.

2015-08-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36814/ --- (Updated Aug. 1, 2015, 5:58 p.m.) Review request for mesos, Adam B and Ben

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-08-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review93844 --- src/hook/manager.cpp (line 187)

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-08-01 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated Aug. 1, 2015, 3:52 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-08-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/#review93849 --- Ship it! src/tests/containerizer/cgroups_tests.cpp (lines 1143 -

Re: Review Request 32700: Removed FrameworkID from FrameworkState.

2015-08-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32700/ --- (Updated Aug. 1, 2015, 3:13 p.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-08-01 Thread Artem Harutyunyan
On Aug. 1, 2015, 3:30 p.m., Benjamin Hindman wrote: src/tests/containerizer/cgroups_tests.cpp, lines 1143-1146 https://reviews.apache.org/r/36627/diff/5/?file=1024882#file1024882line1143 But doesn't this mean we might stay in an infinite loop forever? I'm assuming that somehow

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-08-01 Thread Timothy Chen
On Aug. 1, 2015, 5:07 p.m., Timothy Chen wrote: src/hook/manager.cpp, line 187 https://reviews.apache.org/r/36185/diff/4/?file=1008885#file1008885line187 From the hook signature it seems like we make not distinction between launching a custom executor or a task. I

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated Aug. 1, 2015, 10:09 a.m.) Review request for mesos, Benjamin Hindman