Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94105 --- Looking better! Can you please pull out the fixes to

Re: Review Request 36402: Adding 'Accept' header in request

On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/http.cpp, line 156 https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line156 This will crash the program if tokens is empty! Please see comment below. - Isabel

Re: Review Request 36402: Adding 'Accept' header in request

On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/http.cpp, line 219 https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219 This will crash the program if tokens is empty! Isabel Jimenez wrote: This will not crash, tokenize will always

Re: Review Request 36783: Windows: Header splitting continued (stout/os.hpp)

On Aug. 4, 2015, 5:38 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp, lines 22-50 https://reviews.apache.org/r/36783/diff/4/?file=1024905#file1024905line22 Why do we have both os.hpp and os/os.hpp? Seems strange to put only the structs here,

Review Request 37109: Removed ability to mutate user from scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37109/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 37109: Removed ability to mutate user from scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37109/#review94171 --- Ship it! Ship It! - Vinod Kone On Aug. 5, 2015, 1:23 a.m.,

Re: Review Request 37108: Remove unused failover functionality in scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37108/#review94170 --- Ship it! Ship It! - Vinod Kone On Aug. 5, 2015, 1:19 a.m.,

Re: Review Request 34835: Add constexpr to C++ whitelist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review94172 --- docs/mesos-c++-style-guide.md (line 557)

Re: Review Request 36810: Don't check protobuf jar in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/#review94175 --- Ship it! Seems reasonable to me. I haven't run a build personally

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097/ --- (Updated Aug. 4, 2015, 9:29 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 36402: Adding 'Accept' header in request

On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/http.cpp, line 219 https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219 This will crash the program if tokens is empty! Isabel Jimenez wrote: This will not crash, tokenize will always

Re: Review Request 36402: Adding 'Accept' header in request

On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: Looking better! Can you please pull out the fixes to 'acceptsEncoding' into a separate review? Also, would like to see tests for the cases that weren't handled correctly (e.g. gzipp;q=1.0 should not match gzip). Pulling the changes apart

Review Request 37106: PortMappingIsolatorProcess shell script can silently fail.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37106/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs:

Review Request 37108: Remove unused failover functionality in scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37108/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

<    1   2