Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/ --- (Updated Aug. 10, 2015, 7:04 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Aug. 10, 2015, 7:05 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/ --- (Updated Aug. 10, 2015, 7:04 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Aug. 10, 2015, 7:05 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Aug. 10, 2015, 7:05 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/ --- (Updated Aug. 10, 2015, 7:05 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37176/ --- (Updated Aug. 10, 2015, 7:05 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. B

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/ --- (Updated Aug. 10, 2015, 7:05 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/ --- (Updated Aug. 10, 2015, 7:05 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. B

Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. B

Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37281/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. B

Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. B

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

> On Aug. 6, 2015, 7:15 p.m., Joseph Wu wrote: > > src/master/master.cpp, line 3874 > > > > > > Since Unavailability updates are done by the operator, we might want > > this method to take `Machines` (plural) or ev

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 10, 2015, 10:51 a.m.) Review request for mesos, Alexander Rojas a

Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 10, 2015, 10:53 a.m.) Review request for mesos, Alexander Rojas a

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 10, 2015, 10:52 a.m.) Review request for mesos, Alexander Rojas a

Review Request 37289: Corrected the comments for DRFSorter::dirty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37289/ --- Review request for mesos. Bugs: MESOS-3245 https://issues.apache.org/jira/b

Re: Review Request 37258: stout: Fixed break before braces style for 'enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37258/#review94713 --- Ship it! Ship It! - Till Toenshoff On Aug. 10, 2015, 12:59 a.m.,

Re: Review Request 37259: libprocess: Fixed break before braces style for 'enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37259/#review94714 --- Ship it! Ship It! - Till Toenshoff On Aug. 10, 2015, 12:59 a.m.,

Re: Review Request 37260: mesos: Fixed break before braces style for 'enum'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37260/#review94715 --- Ship it! Ship It! - Till Toenshoff On Aug. 10, 2015, 1 a.m., Mic

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Aug. 10, 2015, 9:50 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 37275: [3/3]Generate make batch file to build project in windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37275/ --- (Updated Aug. 10, 2015, 9:52 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/#review94716 --- Bad patch! Reviews applied: [36321, 36571, 37052] Failed command:

Review Request 37291: Add missing unimplemented.hpp to windows specific OS code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37291/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-3247 http

Re: Review Request 37024: Add an endpoint that exposes component version.

> On Aug. 8, 2015, 9:19 a.m., Marco Massenzio wrote: > > src/master/http.cpp, line 1185 > > > > > > can you please double-check this is consistent with what we add to > > `MasterInfo` in the master's `initialize()`

Re: Review Request 37024: Add an endpoint that exposes component version.

> On Aug. 3, 2015, 7:37 p.m., Ben Mahler wrote: > > src/master/http.cpp, lines 526-542 > > > > > > Could you include these fields as well? They capture "version" / > > "build" information. Once you do, perhaps it is

Re: Review Request 36431: Show stdout/stderr when using mesos-execute.

> On Aug. 6, 2015, 11:43 p.m., Marco Massenzio wrote: > > Before we go too far down this path, can you please see > > https://reviews.apache.org/r/36424/ and see whether it does what you are > > trying to achieve here? > > (maybe not, I'm not familiar at all with `cli` - just asking) > > haosd

Re: Review Request 37222: Enable automake maintainer mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37222/#review94728 --- Ship it! Ship It! - Till Toenshoff On Aug. 10, 2015, 12:16 p.m.,

Re: Review Request 37221: Enable automake maintainer mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37221/#review94729 --- Ship it! Ship It! - Till Toenshoff On Aug. 10, 2015, 12:15 p.m.,

Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/ --- (Updated Aug. 10, 2015, 2:25 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37188: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/ --- (Updated Aug. 10, 2015, 2:25 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 10, 2015, 2:26 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

> On Aug. 8, 2015, 11:43 p.m., Michael Park wrote: > > include/mesos/authorizer/authorizer.hpp, lines 45-47 > > > > > > Looks like we call `initialize` even for non-default implementations of > > `Authenticator`, wh

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 10, 2015, 4:35 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37165: Introduced v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/#review94746 --- src/Makefile.am (line 244)

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94748 --- Patch looks great! Reviews applied: [37187, 37188, 37189] All test

Re: Review Request 36049: Added support for modularized Authorizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated Aug. 10, 2015, 5:29 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 36050: Added test authorizer module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 10, 2015, 5:36 p.m.) Review request for mesos, Adam B, Bernd Math

Review Request 37300: Disabled EventCallFramework test for now

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37300/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2552 https

Review Request 37298: Remove auth from scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37298/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Review Request 37301: Scheduler tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2552 https

Review Request 37302: Delete receive,install

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Review Request 37303: Moved scheduler library to http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2552 https

Re: Review Request 37301: Scheduler tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- (Updated Aug. 10, 2015, 4:44 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37302: Delete receive,install

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- (Updated Aug. 10, 2015, 4:45 p.m.) Review request for mesos, Ben Mahler and Vin

Review Request 37304: Add authorization for http based schedulers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37304/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Re: Review Request 37298: Remove auth from scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37298/#review94762 --- Ship it! Ship It! - Vinod Kone On Aug. 10, 2015, 4:42 p.m., Anan

Re: Review Request 37298: Remove auth from scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37298/ --- (Updated Aug. 10, 2015, 5:27 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37300: Disabled EventCallFramework test for now

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37300/ --- (Updated Aug. 10, 2015, 5:27 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37165: Introduced v1 API.

> On Aug. 10, 2015, 2:57 p.m., haosdent huang wrote: > > If the order is 1. "mv -f ../include/mesos/v1/mesos.pb.cc ../include/mesos/v1" 2. "mv -f ../include/mesos/v1/mesos.pb.cc v1" It would not left mesos.pb.cc in "../include/mesos/v1" If the order is 1. "mv -f ../include/mesos/v1/mesos.pb.

Re: Review Request 37165: Introduced v1 API.

> On Aug. 10, 2015, 2:57 p.m., haosdent huang wrote: > > > > haosdent huang wrote: > If the order is > 1. "mv -f ../include/mesos/v1/mesos.pb.cc ../include/mesos/v1" > 2. "mv -f ../include/mesos/v1/mesos.pb.cc v1" > > It would not left mesos.pb.cc in "../include/mesos/v1" >

Re: Review Request 37263: Add support for non-subscribe HTTP calls in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37263/#review94768 --- src/master/http.cpp (lines 396 - 398)

Re: Review Request 37301: Scheduler tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/#review94769 --- src/tests/scheduler_tests.cpp (lines 166 - 170)

Re: Review Request 37301: Scheduler tests

> On Aug. 10, 2015, 6:17 p.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, lines 167-171 > > > > > > I'm confused. Just because we are not using authentication, we are > > getting a new event here? Why didn

Re: Review Request 37291: Add missing unimplemented.hpp to windows specific OS code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37291/#review94774 --- First, let me say thanks for putting this work in, and apologies for

Re: Review Request 37272: [1/3]Remove thread_tests.cpp in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37272/#review94775 --- See my review in #37291. There are a few changes we've made locally

Review Request 37307: Changed Image::AppC::id from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37307/ --- Review request for mesos, Ian Downes, Jie Yu, Timothy Chen, and Vinod Kone. Bug

Review Request 37308: Added AppcImageManifest protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37308/ --- Review request for mesos, Ian Downes and Jie Yu. Bugs: MESOS-3194 https://i

Review Request 37309: Add app::paths which handles Appc related path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37309/ --- Review request for mesos. Repository: mesos Description --- - Akin to sl

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review94776 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 55)

Review Request 37310: Added Appc spec validation utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37310/ --- Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Repository: mesos

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

> On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/glog-0.3.3.patch, line 21 > > > > > > Looks like your updating the patchfile here to include my glog PR that > > opens it to working

Re: Review Request 37302: Delete receive,install

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- (Updated Aug. 10, 2015, 6:46 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37291: Add missing unimplemented.hpp to windows specific OS code.

> On Aug. 10, 2015, 6:26 p.m., Alex Clemmer wrote: > > First, let me say thanks for putting this work in, and apologies for not > > communicating the exact status of the port ahead of time -- we're in a rush > > to get things in shape for MesosCon, and a lot of things are in the air > > right

Re: Review Request 37298: Remove auth from scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37298/ --- (Updated Aug. 10, 2015, 6:49 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37310: Added Appc spec validation utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37310/ --- (Updated Aug. 10, 2015, 11:50 a.m.) Review request for mesos, Chi Zhang, Ian Do

Review Request 37311: Implemented a 'read-only' Appc image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37311/ --- Review request for mesos. Bugs: MESOS-3194 https://issues.apache.org/jira/b

Re: Review Request 37302: Delete receive,install

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- (Updated Aug. 10, 2015, 6:47 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94781 --- Ship it! Maybe the code around checking for acceptable headers woul

Re: Review Request 37310: Added Appc spec validation utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37310/ --- (Updated Aug. 10, 2015, 12:18 p.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37311/ --- (Updated Aug. 10, 2015, 12:19 p.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 10, 2015, 7:20 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37303: Moved scheduler library to http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review94777 --- looks like the SchedulerTest.Subscribe test failed? src/common/htt

Re: Review Request 37307: Changed Image::AppC::id from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37307/#review94792 --- include/mesos/mesos.proto (line 1208)

Re: Review Request 37307: Changed Image::AppC::id from required to optional.

> On Aug. 10, 2015, 1:29 p.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 1208 > > > > > > Should the user have the ability then to specify either a name or a id? > > > > If name is required th

Review Request 37315: Added basic authentication documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37315/ --- Review request for mesos. Bugs: MESOS-1838 https://issues.apache.org/jira/b

Re: Review Request 37315: Added basic authentication documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37315/#review94799 --- Thanks for doing this. Looking pretty good, just some minor comments

Re: Review Request 37315: Added basic authentication documentation

> On Aug. 10, 2015, 9:33 p.m., Vinod Kone wrote: > > Thanks for doing this. Looking pretty good, just some minor comments. Thanks for taking the time to review, Vinod. I'll make those changes tomorrow. - Tim --- This is an automaticall

Re: Review Request 36402: Adding 'Accept' header in request

> On Aug. 10, 2015, 7:03 p.m., Marco Massenzio wrote: > > 3rdparty/libprocess/src/http.cpp, lines 219-220 > > > > > > I'm not sure I understand why you do this. > > Can you please comment or explain? Here we in

Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/ --- (Updated Aug. 10, 2015, 9:52 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37311/#review94810 --- Patch looks great! Reviews applied: [37307, 37308, 37309, 37310, 37

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/ --- (Updated Aug. 10, 2015, 10:13 p.m.) Review request for mesos, Lily Chen, Ian Do

Review Request 37322: Added filesystem isolator tests to test volumes from the host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37322/ --- Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vi

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37311/#review94814 --- src/slave/containerizer/provisioners/appc/store.cpp (line 63)

Re: Review Request 37196: Add Docker Image type to Container Image protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37196/ --- (Updated Aug. 10, 2015, 10:30 p.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 10, 2015, 10:30 p.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 37304: Add authorization for http based schedulers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37304/#review94819 --- Ship it! src/master/master.cpp (line 1828)

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 10, 2015, 10:47 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

> On Aug. 10, 2015, 3:20 p.m., Timothy Chen wrote: > > src/tests/containerizer/appc_provisioner_tests.cpp, line 119 > > > > > > Btw looking at this and the read-only store, is there documentation > > around how user

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 10, 2015, 10:53 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 10, 2015, 10:54 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37236: Added the linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review94622 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 370) <

Review Request 37327: Added a recordio::Reader for wrapping an http::Pipe::Reader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37327/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, Jie Yu, and Vinod Ko

Review Request 37326: Added a TODO on recordio::Decoder for EOF semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37326/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos De

Re: Review Request 37322: Added filesystem isolator tests to test volumes from the host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37322/#review94828 --- Ship it! Ship It! - Timothy Chen On Aug. 10, 2015, 10:15 p.m., J

Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/#review94830 --- Ship it! Looks reasonable for me. Not run/tested locally for correc

Re: Review Request 37326: Added a TODO on recordio::Decoder for EOF semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37326/#review94834 --- Ship it! Ship It! - Vinod Kone On Aug. 10, 2015, 11:41 p.m., Ben

Re: Review Request 37327: Added a recordio::Reader for wrapping an http::Pipe::Reader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37327/#review94831 --- Ship it! src/common/recordio.hpp (line 177)

  1   2   >