Re: Review Request 37493: Detect gflags when present and link when building Python module

2015-08-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95534 --- configure.ac (line 561)

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review95510 --- Patch looks great! Reviews applied: [37500] All tests passed. -

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

2015-08-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review95509 --- src/Makefile.am (line 635)

Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-15 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3240

Review Request 37501: Add support for removing capabilities.

2015-08-15 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37501/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3258

Re: Review Request 37501: Add support for removing capabilities.

2015-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37501/#review95511 --- Bad patch! Reviews applied: [37501] Failed command:

Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

2015-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37502/ --- Review request for mesos, Alex Clemmer and Michael Park. Bugs: MESOS-3270

Re: Review Request 37257: Add SUPPRESS call interface to the scheduler

2015-08-15 Thread haosdent huang
On Aug. 13, 2015, 11:39 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [37257] Failed command: ./support/apply-review.sh -n -r 37257 Error: 2015-08-13 23:39:06 URL:https://reviews.apache.org/r/37257/diff/raw/ [5394/5394] - 37257.patch [1] error: patch failed:

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

2015-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37502/#review95515 --- Patch looks great! Reviews applied: [37502] All tests passed. -

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated Aug. 15, 2015, 2:47 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37272: [1/3]Remove thread_tests.cpp in stout.

2015-08-15 Thread haosdent huang
On Aug. 10, 2015, 6:29 p.m., Alex Clemmer wrote: See my review in #37291. There are a few changes we've made locally to the Stout tests CMakeLists, and I think it makes sense to wrap them up into one diff, and push them into master. Thank you! I discarded this. - haosdent

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated Aug. 15, 2015, 4:34 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37501: Add support for removing capabilities.

2015-08-15 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37501/ --- (Updated Aug. 15, 2015, 4:35 p.m.) Review request for mesos and Vinod Kone.