Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated Aug. 16, 2015, 6:05 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review95536 --- src/tests/hook_tests.cpp (line 573)

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

On Aug. 16, 2015, 6:53 a.m., Timothy Chen wrote: I think other than the minor issues I see this seems to good to go, once you fix this I'll run this locally and this should be ready to go. The jenkins seems have problem. https://builds.apache.org/job/Mesos/705/ The job hang 2 days. I

Re: Review Request 37246: Refactor store to use updated DockerImage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37246/ --- (Updated Aug. 16, 2015, 8:34 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 16, 2015, 8:35 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37245: Refactor Docker Image to exclude path and manifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37245/ --- (Updated Aug. 16, 2015, 8:33 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37199/ --- (Updated Aug. 16, 2015, 8:32 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 16, 2015, 8:33 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- (Updated Aug. 16, 2015, 8:36 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 16, 2015, 8:38 a.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 16, 2015, 8:31 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 16, 2015, 8:31 a.m.) Review request for mesos, Ian Downes, Jie

Review Request 37505: Fix broken health check in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ --- Review request for mesos, Adam B and Timothy Chen. Bugs: MESOS-3136

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated Aug. 16, 2015, 7:15 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37505: Fix broken health check in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/#review95541 --- Patch looks great! Reviews applied: [37505] All tests passed. -

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review95540 --- Patch looks great! Reviews applied: [37196, 37197, 37198, 37199,

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review95539 --- Patch looks great! Reviews applied: [36185] All tests passed. -

Re: Review Request 37493: Detect gflags when present and link when building Python module

On Aug. 16, 2015, 3:42 a.m., Timothy Chen wrote: configure.ac, line 561 https://reviews.apache.org/r/37493/diff/1/?file=1040648#file1040648line561 I think we can basically follow the same syntax we've calling AC_CHECK_LIB in the other places [AC_CHECK_LIB([leveldb],

Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/#review95547 --- Ship it! Definitely a band-aid but given that we keep tracking

Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/#review95548 --- Ship it! Definitely a band-aid but given that we keep tracking

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

On Aug. 14, 2015, 10:28 p.m., haosdent huang wrote: Again, sorry it's taken so long to get round to doing this review and s many thanks for doing this! I've only got halfway through, I'll try my best to do more in the next few days, less craziness (here's to hoping, anyway!)

Re: Review Request 37511: Fixed master to reject non-subscribe calls made before subscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37511/#review95559 --- Ship it! Ship It! - Guangya Liu On 八月 16, 2015, 11:41 p.m.,

Re: Review Request 37508: Add destruct ShutdownHook in java MesosExecutorDriver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37508/#review95560 --- Patch looks great! Reviews applied: [37508] All tests passed. -

Review Request 37511: Fixed master to reject non-subscribe calls made before subscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37511/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Review Request 37512: Added user doc for Scheduler HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Repository: mesos

Re: Review Request 37509: Log Scheduler HTTP API Requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37509/#review95556 --- Ship it! Ship It! - Vinod Kone On Aug. 16, 2015, 8:27 p.m.,

Re: Review Request 37510: Add more logging to the scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/#review95563 --- Bad patch! Reviews applied: [37510] Failed command:

Review Request 37509: Log Scheduler HTTP API Requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37509/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review95552 --- Patch looks great! Reviews applied: [37024] All tests passed. -

Re: Review Request 37510: Add more logging to the scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/#review95554 --- Ship it! Ship It! - Guangya Liu On 八月 16, 2015, 9:18 p.m.,

Re: Review Request 37410: Disallow copy construction/assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37410/ --- (Updated Aug. 16, 2015, 8:40 p.m.) Review request for mesos, Ben Mahler and

Review Request 37508: Add destruct ShutdownHook in java MesosExecutorDriver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37508/ --- Review request for mesos. Bugs: MESOS-3264

Review Request 37510: Add more logging to the scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 37510: Add more logging to the scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/#review95551 --- Ship it! Ship It! - Vinod Kone On Aug. 16, 2015, 9:18 p.m.,

Review Request 37513: added Scrapinghub to powered by mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37513/ --- Review request for mesos. Bugs: MESOS-3276