Re: Review Request 40756: Updated codebase to use `nonRevocable()` where appropriate.

2015-11-28 Thread Alexander Rukletsov
> On Nov. 28, 2015, 3:39 a.m., Guangya Liu wrote: > > https://github.com/apache/mesos/blob/master/src/master/master.cpp#L4322 > > also needs an update I'm not sure about that one. I think it's more readable how it's now. - Alexander --

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/ --- (Updated Nov. 28, 2015, 11:15 a.m.) Review request for mesos, Bernd Mathiske an

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-28 Thread Benjamin Bannier
> On Nov. 27, 2015, 9:53 p.m., Till Toenshoff wrote: > > src/tests/fetcher_cache_tests.cpp, lines 325-326 > > > > > > Let's add a reference to the JIRA describing the issue in more detail > > -- here and also in tho

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108257 --- Patch looks great! Reviews applied: [40776] Passed command: expor

Re: Review Request 40756: Updated codebase to use `nonRevocable()` where appropriate.

2015-11-28 Thread Guangya Liu
> On εδΈ€ζœˆ 28, 2015, 3:39 a.m., Guangya Liu wrote: > > https://github.com/apache/mesos/blob/master/src/master/master.cpp#L4322 > > also needs an update > > Alexander Rukletsov wrote: > I'm not sure about that one. I think it's more readable how it's now. I think that you already did some sim