Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review111743 --- Patch looks great! Reviews applied: [41600] Passed command: expor

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Dec. 23, 2015, 7:22 a.m.) Review request for Alex Naparu and Alex Clem

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40620/ --- (Updated Dec. 23, 2015, 7:22 a.m.) Review request for Alex Naparu and Alex Clem

Re: Review Request 40940: Windows: Modified `launch.cpp`

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40940/ --- (Updated Dec. 23, 2015, 7:20 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 40939: Windows: Unified POSIX and Windows implementation of su

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40939/ --- (Updated Dec. 23, 2015, 7:16 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/ --- (Updated Dec. 23, 2015, 7:17 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

> On Dec. 23, 2015, 5:28 a.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 104 > > > > > > Can you check the semnatic of opendir() function? I'm un

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Dec. 23, 2015, 6:44 a.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/ --- (Updated 十二月 23, 2015, 6:43 a.m.) Review request for mesos and Alexander Ruklet

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

> On Dec. 23, 2015, 5:28 a.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 1 > > > > > > Does it have to be in makefile.am? Or this is used only on W

Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-4161 https://

Review Request 41673: Windows: Forked signal handling in `signalhandler.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41673/ --- Review request for mesos. Repository: mesos Description --- Windows: For

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Dec. 23, 2015, 5:49 a.m.) Review request for mesos, Adam B and Neil Co

Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- Review request for mesos, Adam B and Neil Conway. Bugs: MESOS-4200 https://

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 23, 2015, 5:46 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review111717 --- 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/#review111726 --- Ship it! Ship It! src/slave/containerizer/mesos/provisioner/dock

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review111725 --- Ship it! Ship It! - Alex Naparu On Dec. 23, 2015, 2:15 a.m., Al

Re: Review Request 41661: Added documentation for API versioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111719 --- docs/versioning.md (line 30)

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 23, 2015, 3:56 a.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 23, 2015, 3 a.m.) Review request for mesos, Adam B and Anand Mazu

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review111718 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 41661: Added documentation for API versioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111715 --- Patch looks great! Reviews applied: [41661] Passed command: expor

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

> On Dec. 12, 2015, 8:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > lines 198-200 > > > > > > Where does the internal data for DIR get fre

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

> On Dec. 12, 2015, 8:09 p.m., Joris Van Remoortere wrote: > > Let's get some Windows team reviews on this. > > let's try and use snake_case in stout. Wasn't sure where you wanted me to use snake_case, so those changes aren't reflected in iteration 8. - Alex

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Dec. 23, 2015, 2:12 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/ --- (Updated Dec. 23, 2015, 2:10 a.m.) Review request for mesos, Adam B and Anand M

Re: Review Request 41661: Added documentation for API versioning.

> On Dec. 22, 2015, 11:55 p.m., Guangya Liu wrote: > > docs/versioning.md, line 36 > > > > > > Not clear for what does " It would be really hard to debug an error > > that happens with Scheduler v2 API, Executor v4 A

Re: Review Request 41661: Added documentation for API versioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/ --- (Updated Dec. 23, 2015, 2:09 a.m.) Review request for mesos, Neil Conway and Vi

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 23, 2015, 2:09 a.m.) Review request for mesos, Adam B and Anand M

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

> On Dec. 15, 2015, 4:24 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 79 > > > > > > Consider using a smart pointer instead. Same below. I would

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 23, 2015, 2:05 a.m.) Review request for mesos, Adam B and Anand M

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review111703 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 41665: Tests: Use 'in_memory' registry by default for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41665/#review111697 --- Patch looks great! Reviews applied: [41665] Passed command: expor

Re: Review Request 41661: Added documentation for API versioning.

> On 十二月 22, 2015, 11:55 p.m., Guangya Liu wrote: > > docs/versioning.md, line 22 > > > > > > Not yours, but can you please add the following to "Terminology" > > section? > > > > Scheduler API > > Execu

Re: Review Request 41661: Added documentation for API versioning.

> On Dec. 22, 2015, 11:55 p.m., Guangya Liu wrote: > > docs/versioning.md, line 22 > > > > > > Not yours, but can you please add the following to "Terminology" > > section? > > > > Scheduler API > > Exec

Re: Review Request 41661: Added documentation for API versioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111689 --- docs/versioning.md (line 20)

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/ --- (Updated Dec. 22, 2015, 11:48 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 22, 2015, 11:47 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41657: Added user facing documentation for containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/#review111688 --- Patch looks great! Reviews applied: [41656, 41657] Passed command

Re: Review Request 41665: Tests: Use 'in_memory' registry by default for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41665/#review111684 --- By changing the default registry to "in_memory", you also have to c

Re: Review Request 41661: Added documentation for API versioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/ --- (Updated Dec. 22, 2015, 10:57 p.m.) Review request for mesos, Neil Conway and V

Review Request 41665: Tests: Use 'in_memory' registry by default for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41665/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, an

Re: Review Request 41661: Added documentation for API versioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111679 --- docs/versioning.md (line 11)

Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

> On 十二月 22, 2015, 10:24 p.m., Guangya Liu wrote: > > I found that all of the links in home.md does not work, take "Getting > > Started" as example, it will redirect to > > https://github.com/apache/mesos/blob/master/documentation/latest/getting-started > > and report 404 error. > > Joerg Sch

Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41656/#review111680 --- Ship it! docs/mesos-provisioner.md (line 112)

Re: Review Request 41657: Added user facing documentation for containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/ --- (Updated Dec. 22, 2015, 10:27 p.m.) Review request for mesos, Jie Yu and Joerg

Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

> On Dec. 22, 2015, 10:24 p.m., Guangya Liu wrote: > > I found that all of the links in home.md does not work, take "Getting > > Started" as example, it will redirect to > > https://github.com/apache/mesos/blob/master/documentation/latest/getting-started > > and report 404 error. I guess that

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41658/#review111675 --- Patch looks great! Reviews applied: [41658] Passed command: expor

Re: Review Request 41657: Added user facing documentation for containerizers.

> On Dec. 22, 2015, 9:42 p.m., Joseph Wu wrote: > > docs/containerizer.md, line 53 > > > > > > Maybe: s/OSX/POSIX/ If we have to say linux, then I would think we should use an operating system like osx/bsd. posix is

Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41656/#review111674 --- I found that all of the links in home.md does not work, take "Getti

Re: Review Request 41657: Added user facing documentation for containerizers.

> On Dec. 22, 2015, 9:42 p.m., Joseph Wu wrote: > > docs/containerizer.md, lines 13-15 > > > > > > I feel like these three points say the same thing. Maybe you can > > condense them down to two points. > > > >

Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41656/ --- (Updated Dec. 22, 2015, 10:11 p.m.) Review request for mesos, Jie Yu and Joerg

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

> On Dec. 19, 2015, 10:01 a.m., Adam B wrote: > > include/mesos/mesos.proto, lines 1576-1577 > > > > > > Do we expect to add more fields to the Vip message later? > > If not, why don't we just add a `repeated st

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 22, 2015, 10:03 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41657: Added user facing documentation for containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/#review111665 --- Looks good. Just a few suggestions: docs/containerizer.md (lines

Review Request 41661: Added documentation for API versioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/ --- Review request for mesos, Neil Conway and Vinod Kone. Bugs: MESOS-4192 http

Re: Review Request 41425: Fix the Mesos pkg-config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41425/#review111664 --- Ship it! LGTM. - Joseph Wu On Dec. 22, 2015, 12:45 p.m., James

Re: Review Request 41424: Install picojson.h if we are using the bundled version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/#review111661 --- Ship it! Verified this does not break a clean build. - Joseph Wu

Re: Review Request 41657: Added user facing documentation for containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/#review111662 --- Patch looks great! Reviews applied: [41656, 41657] Passed command

Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41656/#review111660 --- Ship it! docs/home.md (line 34)

Re: Review Request 41111: Logger Module: Add test for default executor/task stdout/stderr logging behavior (to sandbox).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- (Updated Dec. 22, 2015, 1:09 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41575: Removed outdated "Logging and Debugging" doc page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41575/#review111658 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 19, 2015, 12:1

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41026/#review111657 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 18, 2015, 11:5

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 22, 2015, 8:43 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 22, 2015, 8:49 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 22, 2015, 8:42 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 22, 2015, 8:39 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 167 > > > > > > Is the `int32_t`, `uint32_t`, and `float` overloads necessary? With only

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 192 > > > > > > Why not s/type/type_/ here? I think I was following the guideline of "add

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 58-63 > > > > > > An implicit cast operator that is non-const is always code smell > > be

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 22, 2015, 8:23 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 41594: libprocess: Added support for `jsonify` result to `OK` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41594/ --- (Updated Dec. 22, 2015, 8:23 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/#review111644 --- Patch looks great! Reviews applied: [41514, 41515, 41603] Passed

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

> On Oct. 6, 2015, 5:12 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 87 > > > > > > Seems like this will give a negative array access if you set `p

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/#review111641 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 22, 2015, 6:08

Re: Review Request 41515: Refactored error messages to reduce jaggedness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41515/#review111640 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 22, 2015, 6:08

Review Request 41658: Track the allocation candidates to bound the allocation queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41658/ --- Review request for mesos, Ben Mahler and Klaus Ma. Bugs: MESOS-3157 https:/

Re: Review Request 41514: Accepted a single JSON object for quota set request.

> On Dec. 22, 2015, 7:48 p.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, lines 357-359 > > > > > > Have you considered making this static? > > What about building it up from the true and false

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/#review111638 --- Ship it! src/master/quota_handler.cpp (lines 332 - 334)

Review Request 41657: Added user facing documentation for containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/ --- Review request for mesos, Jie Yu and Joerg Schad. Repository: mesos Descripti

Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41656/ --- Review request for mesos, Jie Yu and Joerg Schad. Repository: mesos Descripti

Re: Review Request 41513: Cleaned up STL I/O includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/#review111635 --- Patch looks great! Reviews applied: [41509, 41510, 41511, 41512, 4

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/ --- (Updated Dec. 22, 2015, 6:09 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/ --- (Updated Dec. 22, 2015, 6:08 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 41515: Refactored error messages to reduce jaggedness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41515/ --- (Updated Dec. 22, 2015, 6:08 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 41514: Accepted a single JSON object for quota set request.

> On Dec. 22, 2015, 5:47 p.m., Anand Mazumdar wrote: > > src/master/quota_handler.cpp, line 30 > > > > > > Remove this. This must have crept in due to handling multiple `force` > > field values ? You're right and th

Re: Review Request 41513: Cleaned up STL I/O includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/ --- (Updated Dec. 22, 2015, 5:59 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41512/ --- (Updated Dec. 22, 2015, 5:56 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/ --- (Updated Dec. 22, 2015, 5:55 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41509: [libprocess] Cleaned up STL I/O includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41509/ --- (Updated Dec. 22, 2015, 5:53 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/ --- (Updated Dec. 22, 2015, 5:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41510/ --- (Updated Dec. 22, 2015, 5:51 p.m.) Review request for mesos, Michael Park and T

Re: Review Request 41509: [libprocess] Cleaned up STL I/O includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41509/ --- (Updated Dec. 22, 2015, 5:51 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

> On Dec. 18, 2015, 1:44 p.m., Benjamin Bannier wrote: > > include/mesos/type_utils.hpp, line 26 > > > > > > Looks like a forward decl is good enough here. I'm not sure we can forward declare it since it's a template

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/#review111624 --- Ship it! LGTM ! src/master/quota_handler.cpp (line 30)

Re: Review Request 41649: Removed slave checkpointing after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Dec. 22, 2015, 5:33 p.m.) Review request for mesos and Joerg Schad.

Re: Review Request 41648: Used initializer list c-tor for brevity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41648/#review111617 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 41646: Removed extra '; ' after inline class function definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41646/#review111615 --- Patch looks great! Reviews applied: [41646] Passed command: expor

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111614 --- Patch looks great! Reviews applied: [41444] Passed command: expor

  1   2   >