Re: Review Request 35711: Disallow special characters in role name.

> On Jan. 7, 2016, 10:51 p.m., Adam B wrote: > > Still wondering if `class Roles` is any better than `namespace roles`, and > > unsure about the need for the CMake change. Thank you very much for your great reviews! Could you help review again? I change to use namespaces roles. - haosdent

Re: Review Request 37703: Add docker exec command.

> On Jan. 9, 2016, 1:05 a.m., Timothy Chen wrote: > > I just ran the CheckExec test and it failed for me, can you try it yourself > > and see if you can repro? sorry, my bad. Let me update again.. - haosdent --- This is an

Review Request 42107: Added sample to use RETURN_ERROR_IF.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42107/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Review Request 42106: Added helper function to return Error in condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42106/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated Jan. 9, 2016, 11:15 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 42107: Added sample to use RETURN_ERROR_IF.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42107/ --- (Updated Jan. 9, 2016, 9:09 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 42106: Added helper function to return Error in condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42106/ --- (Updated Jan. 9, 2016, 9:09 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 37703: Add docker exec command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/ --- (Updated Jan. 9, 2016, 10:35 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 9, 2016, 11:38 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 9, 2016, 10:24 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 9, 2016, 11:36 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42048: Defined of the CgroupNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42048/ --- (Updated Jan. 9, 2016, 9:08 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 37703: Add docker exec command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review113626 --- src/tests/containerizer/docker_tests.cpp (line 299)

Re: Review Request 41810: Added credential to Docker image protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41810/#review113623 --- Should this also update `v1/mesos.proto`? - Neil Conway On Dec.

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42047/ --- (Updated Jan. 9, 2016, 8:30 p.m.) Review request for mesos and Jie Yu. Bugs:

Review Request 42097: Added cgroup/net_cls to the mesos containerizer isolation flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42097/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 8:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1302 > > > > > > If framework has reserved.statless resources, allocator should not > > dispatch it as

Re: Review Request 37703: Add docker exec command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/ --- (Updated Jan. 10, 2016, 6:32 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

> On Jan. 9, 2016, 8:09 a.m., Klaus Ma wrote: > > src/master/validation.cpp, line 597 > > > > > > There're several similar code: > > if (condition) { > > return Error(); > > } > >

Re: Review Request 41857: Got evictable executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/ --- (Updated Jan. 9, 2016, 5:06 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41857: Got evictable executors.

> On Jan. 8, 2016, 4:36 p.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 3985 > > > > > > I am not sure whether this situation will happen, because it means a > > task using allocation slack and is waiting for

Re: Review Request 41857: Got evictable executors.

> On Jan. 4, 2016, 4:21 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 3954 > > > > > > Here should be requested.stateless().reserved() Using `allocationSlackable` for `stateless().reserved()`. > On Jan.

Re: Review Request 41859: Launch tasks after evicting executors.

> On Jan. 8, 2016, 5:12 p.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 1449 > > > > > > If an evictable executor is in terminating state because of task > > finished, it cannot be moved out of

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Jan. 8, 2016, 10:36 a.m., Adam B wrote: > > Here's my first full pass over this patch. Couldn't find anything major > > except the PUT vs. POST question. > > I'll admit I was surprised to see in your testing section that `role1` > > showed up in `/roles` even though it has a default

Re: Review Request 41855: Trace pending executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41855/ --- (Updated Jan. 9, 2016, 5:38 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41855: Trace pending executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41855/#review113614 --- src/slave/slave.hpp (line 803)

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review113639 --- include/mesos/roles.hpp (line 51)