Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/#review114898 --- Patch looks great! Reviews applied: [42100] Passed command: expor

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/ --- (Updated Jan. 17, 2016, 6:49 a.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/ --- (Updated Jan. 17, 2016, 6:48 a.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/#review114896 --- Thanks! Just a small comment below. support/docker_build.sh (line

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review114895 --- src/tests/fetcher_tests.cpp (line 706)

Re: Review Request 42390: Fixed fetching uris when slave is running inside a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42390/ --- (Updated Jan. 17, 2016, 3:33 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/ --- (Updated 一月 17, 2016, 2:24 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review114892 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 13, 2016, 2:43

Re: Review Request 42386: Updated createFrameworkInfo for hierarchical_allocator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/#review114891 --- src/tests/hierarchical_allocator_tests.cpp (line 201)

Re: Review Request 42305: Updated comments around sorters in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42305/#review114890 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (line 409) <

Re: Review Request 42222: Added a comment on allocator recovery.

> On Jan. 15, 2016, 6:50 a.m., Ben Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 205-206 > > > > > > It looks like if we trip the `resume` call in `addSlave`, this delayed > > resume will cras

Re: Review Request 42222: Added a comment on allocator recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review114888 --- Ship it! I've rephrased and moved the comment as per BenM's sugges

Re: Review Request 42254: Checked whether the remaining cluster resources is allocatable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42254/#review114887 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 13, 2016, 3:29

Re: Review Request 42221: Removed references to wDRF from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42221/#review114886 --- Ship it! src/master/allocator/mesos/hierarchical.cpp (line 1245)

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/#review114884 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 7, 2016, 9:47

Re: Review Request 39834: Made `path_tests.cpp` standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39834/#review114883 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 4, 2016, 7:10

Re: Review Request 39805: Moved filesystems tests to their own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/#review114881 --- Missing includes `stout/os/touch.hpp` and `stout/os/rm.hpp` from `

Re: Review Request 42336: Documented endpoint failure when HTTP authentication disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42336/#review114880 --- Ship it! Ship It! - Jie Yu On Jan. 16, 2016, 4:38 p.m., Greg Ma

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 16, 2016, 8:44 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 42334: Changed 'ReservationInfo.principal' from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42334/#review114879 --- Ship it! src/master/validation.cpp (line 667)

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ --- (Updated Jan. 16, 2016, 8:37 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review114875 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.

Re: Review Request 42379: Add reverse_foreach in libprocess.

Maybe include boost::adaptor into stout under namespace adaptor? I liked the adaptor idea since it can be composed. - Jie On Sat, Jan 16, 2016 at 10:48 AM, Benjamin Mahler wrote: > It seems unfortunate to introduce alternative looping constructs, for > example the following would be the more co

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review114874 --- 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/

Re: Review Request 40731: Added a test fixture for checking floating point precision.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 16, 2016, 7:26 p.m.) Review request for mesos, Bernd Mathiske, Kl

Re: Review Request 42379: Add reverse_foreach in libprocess.

It seems unfortunate to introduce alternative looping constructs, for example the following would be the more composable approach: foreach (int i, reversed(numbers)) { } I remember this coming up before: http://mail-archives.apache.org/mod_mbox/mesos-dev/201410.mbox/%3c20141002211204.18846.48...

Re: Review Request 40553: Enable mesos tests installation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 16, 2016, 5:41 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 42379: Add reverse_foreach in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42379/#review114871 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/foreach

Re: Review Request 42390: Fixed fetching uris when slave is running inside a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42390/#review114869 --- Patch looks great! Reviews applied: [42390] Passed command: expor

Re: Review Request 42334: Changed 'ReservationInfo.principal' from required to optional.

> On Jan. 16, 2016, 1:17 p.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 663-664 > > > > > > I saw that most comments including some verison info if we want to > > deprecate sth in one release. Please

Re: Review Request 42336: Documented endpoint failure when HTTP authentication disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42336/ --- (Updated Jan. 16, 2016, 4:38 p.m.) Review request for mesos, Jie Yu, Michael Pa

Re: Review Request 42361: Added dynamic reservation test with no principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/ --- (Updated Jan. 16, 2016, 4:31 p.m.) Review request for mesos, Jie Yu, Michael Pa

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42368/ --- (Updated Jan. 16, 2016, 4:31 p.m.) Review request for mesos, Jie Yu, Michael Pa

Re: Review Request 42334: Changed 'ReservationInfo.principal' from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42334/ --- (Updated Jan. 16, 2016, 4:30 p.m.) Review request for mesos, Jie Yu, Michael Pa

Review Request 42390: Fixed fetching uris when slave is running inside a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42390/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-4249 https://issues.

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review114863 --- Patch looks great! Reviews applied: [41769] Passed command: expor

Re: Review Request 42334: Changed 'ReservationInfo.principal' from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42334/#review114862 --- include/mesos/mesos.proto (lines 575 - 576)

Re: Review Request 42336: Documented endpoint failure when HTTP authentication disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42336/#review114861 --- docs/reservation.md (line 60)

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/ --- (Updated 一月 16, 2016, 12:45 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/ --- (Updated 一月 16, 2016, 12:44 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 42379: Add reverse_foreach in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42379/#review114856 --- Ship it! Ship It! - haosdent huang On Jan. 16, 2016, 1:32 a.m.,

Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42389/#review114855 --- Ship it! Ship It! - haosdent huang On Jan. 16, 2016, 8:45 a.m.,

Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42389/#review114854 --- Patch looks great! Reviews applied: [42379, 42389] Passed command

Re: Review Request 42124: Updated /state to show usage slack and allocation slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42124/#review114853 --- Patch looks great! Reviews applied: [40375, 41334, 41333, 40529, 4

Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42389/ --- Review request for mesos, haosdent huang and Jie Yu. Bugs: MESOS-3379 https

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38164/#review114852 --- Going to rebase this patch and use the newer primitive for this fix

Re: Review Request 40553: Enable mesos tests installation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review114851 --- Bad patch! Reviews applied: [39780, 39781, 39782, 40553] Failed c

Re: Review Request 40731: Adding test fixture for checking floating point arithmetic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review114848 --- Bad patch! Reviews applied: [40731] Failed command: ./support/app

Re: Review Request 42124: Updated /state to show usage slack and allocation slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42124/ --- (Updated 一月 16, 2016, 8:03 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42123/ --- (Updated 一月 16, 2016, 8 a.m.) Review request for mesos, Ben Mahler, Artem Harut