Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Bernd Mathiske
> On Jan. 28, 2016, 11:40 p.m., Timothy Chen wrote: > > docs/fetcher.md, line 119 > > > > > > then files with a recognized extension > > Bernd Mathiske wrote: > Soryy, I do not understand what you mean. > > Tim

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Timothy Chen
> On Jan. 29, 2016, 7:40 a.m., Timothy Chen wrote: > > docs/fetcher.md, line 119 > > > > > > then files with a recognized extension > > Bernd Mathiske wrote: > Soryy, I do not understand what you mean. Sorry, I

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Bernd Mathiske
> On Jan. 28, 2016, 11:40 p.m., Timothy Chen wrote: > > docs/fetcher.md, line 119 > > > > > > then files with a recognized extension Soryy, I do not understand what you mean. - Bernd

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116929 --- Fix it, then Ship it! Ship It! docs/fetcher.md (line 119)

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review116928 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 20, 2016, 9

Re: Review Request 42946: Replace tabs with spaces in configure.ac.

2016-01-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/#review116927 --- Ship it! Commit message should probably be `s/Replace/Replaced/

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116924 --- Ship it! Ship It! - Guangya Liu On Jan. 28, 2016, 6:17 p.m.,

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

2016-01-28 Thread Guangya Liu
> On Jan. 15, 2016, 12:03 a.m., Zhitao Li wrote: > > src/docker/docker.cpp, lines 410-420 > > > > > > (Sorry I just got time to come back to this). > > > > I don't exactly understand your suggestion about "a

Re: Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

2016-01-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42927/#review116917 --- Ship it! Ship It! - Guangya Liu On Jan. 29, 2016, 12:05 a.m.

Re: Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/#review116916 --- Patch looks great! Reviews applied: [42936] Passed command: expo

Re: Review Request 42946: Replace tabs with spaces in configure.ac.

2016-01-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/#review116914 --- Ship it! Ship It! - haosdent huang On Jan. 29, 2016, 2:55 a.

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of `shell.hpp`.

2016-01-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/#review116912 --- Ship it! Ship It! - Michael Park On Jan. 29, 2016, 12:04 a.m

Re: Review Request 42946: Replace tabs with spaces in configure.ac.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/#review116911 --- Patch looks great! Reviews applied: [42946] Passed command: expo

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of `shell.hpp`.

2016-01-28 Thread Michael Park
> On Jan. 28, 2016, 10:41 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp, > > lines 41-55 > > > > > > I'm curious as to whether this struct is meant to be widely u

Re: Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/ --- (Updated Jan. 29, 2016, 5:34 a.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/ --- (Updated Jan. 29, 2016, 5:30 a.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 5:25 a.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/#review116899 --- Fix it, then Ship it! src/master/flags.cpp (line 144)

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of `shell.hpp`.

2016-01-28 Thread Michael Park
> On Jan. 28, 2016, 10:41 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp, > > lines 41-55 > > > > > > I'm curious as to whether this struct is meant to be widely u

Re: Review Request 42940: Removed command-line flags from 'logging.md'.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42940/#review116896 --- Patch looks great! Reviews applied: [42939, 42940] Passed comman

Re: Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/ --- (Updated Jan. 29, 2016, 4:30 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/#review116886 --- Bad patch! Reviews applied: [42936] Failed command: ./support/ap

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116884 --- Patch looks great! Reviews applied: [42828] Passed command: expo

Re: Review Request 42946: Replace tabs with spaces in configure.ac.

2016-01-28 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/ --- (Updated Jan. 29, 2016, 10:55 a.m.) Review request for mesos, Benjamin Bannier

Review Request 42946: Replace tabs with spaces in configure.ac.

2016-01-28 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/ --- Review request for mesos. Repository: mesos Description --- Replace tabs

Re: Review Request 42539: Support image specified Entrypoint and Cmd.

2016-01-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42539/#review116882 --- src/launcher/executor.cpp (line 269)

Re: Review Request 42539: Support image specified Entrypoint and Cmd.

2016-01-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42539/#review116869 --- src/launcher/executor.cpp (line 34)

Review Request 42940: Removed command-line flags from 'logging.md'.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42940/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4298 https://issues.ap

Re: Review Request 40851: Windows:[1/2] Add patch for Windows ZK version.

2016-01-28 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/ --- (Updated Jan. 29, 2016, 2:17 a.m.) Review request for Alex Naparu, Dario Bazan,

Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4298 https://issues.ap

Review Request 42936: Edited flag help strings for style.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4298 https://issues.ap

Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.

2016-01-28 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/ --- (Updated Jan. 29, 2016, 2:17 a.m.) Review request for Alex Naparu, Daniel Prava

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116875 --- Bad patch! Reviews applied: [42927, 42928, 42929] Failed command

Re: Review Request 42773: Added utility function to compute SHA512 digest.

2016-01-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/ --- (Updated Jan. 29, 2016, 2:03 a.m.) Review request for mesos. Bugs: MESOS-4454

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Kevin Klues
> On Jan. 29, 2016, 1:37 a.m., Anand Mazumdar wrote: > > You would need to update the Summary/Description again while committing. > > Probably got erased by not having `--guess_fields=auto`. :-( This is now the default if you use the standard .reviewboardrc https://reviews.apache.org/r/41411/

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Kevin Klues
> On Jan. 29, 2016, 1:10 a.m., Kevin Klues wrote: > > support/verify_reviews.py, line 140 > > > > > > To avoid using tee, you could just do: > > > > "%s > %s 2>&1" % (command, build_output) > > Vinod Kone w

Re: Review Request 40731: Added a test case for floating point precision of resource allocation.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review116868 --- Patch looks great! Reviews applied: [40731] Passed command: expo

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116866 --- Ship it! Ship It! - haosdent huang On Jan. 28, 2016, 5:59 p.

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116865 --- Ship it! Ship It! - Anand Mazumdar On Jan. 29, 2016, 1:32 a.

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116864 --- Ship it! You would need to update the Summary/Description again

Re: Review Request 42773: Added utility function to compute SHA512 digest.

2016-01-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/#review116863 --- Fix it, then Ship it! I'll fix the remaining issue for you. s

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/ --- (Updated Jan. 29, 2016, 1:32 a.m.) Review request for mesos, Anand Mazumdar, Gr

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/ --- (Updated Jan. 29, 2016, 1:27 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42755: Added documentation for labeled reserved resources.

2016-01-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review116861 --- docs/reservation.md (lines 80 - 81)

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Vinod Kone
> On Jan. 29, 2016, 1:10 a.m., Kevin Klues wrote: > > support/verify_reviews.py, line 140 > > > > > > To avoid using tee, you could just do: > > > > "%s > %s 2>&1" % (command, build_output) The above just o

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/ --- (Updated Jan. 29, 2016, 1:15 a.m.) Review request for mesos, Anand Mazumdar, Gr

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Vinod Kone
> On Jan. 29, 2016, 1:03 a.m., Anand Mazumdar wrote: > > support/verify_reviews.py, line 151 > > > > > > hmm .. what happens to the build_output file thereafter? Should we be > > cleaning it up too? This gets clean

Re: Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

2016-01-28 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42927/#review116859 --- Ship it! Ship It! - Kevin Klues On Jan. 29, 2016, 12:05 a.m.

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116858 --- support/verify_reviews.py (line 139)

Re: Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

2016-01-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42866/#review116856 --- Ship it! Ship It! - Timothy Chen On Jan. 27, 2016, 8:38 p.m.

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116850 --- LGTM. Just one minor query about what happens to the piped file an

Re: Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

2016-01-28 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42928/#review116855 --- Ship it! Ship It! - Kevin Klues On Jan. 29, 2016, 12:06 a.m.

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116854 --- Ship it! Ship It! - Kevin Klues On Jan. 29, 2016, 12:10 a.m.

Re: Review Request 42841: WIP: Introducing appc image fetcher.

2016-01-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Jan. 29, 2016, 12:58 a.m.) Review request for Jie Yu. Repository: me

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jojy Varghese
> On Jan. 28, 2016, 10:12 p.m., Jie Yu wrote: > > it's strange that this protobuf is exposed in Mesos API. Similar to Docker, > > can we move this to include/mesos/appc/spec.proto? Will be working on a separate patch for moving this message to appc/spec.proto. - Jojy ---

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/ --- (Updated Jan. 29, 2016, 12:56 a.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 42773: Added utility function to compute SHA512 digest.

2016-01-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/ --- (Updated Jan. 29, 2016, 12:54 a.m.) Review request for mesos. Changes ---

Re: Review Request 40731: Added a test case for floating point precision of resource allocation.

2016-01-28 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 29, 2016, 12:45 a.m.) Review request for mesos, Bernd Mathiske, K

Re: Review Request 40731: Added a test case for floating point precision of resource allocation.

2016-01-28 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 29, 2016, 12:42 a.m.) Review request for mesos, Bernd Mathiske, K

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116848 --- Ship it! LGTM. Looks like the review bot vaidated that the `Env

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116847 --- Bad patch! Reviews applied: [42927, 42928, 42929] Failed command

Re: Review Request 42755: Added documentation for labeled reserved resources.

2016-01-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review116846 --- Ship it! Ship It! - Qian Zhang On Jan. 26, 2016, 7:02 a.m.,

Re: Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42928/#review116844 --- Ship it! Can we also set up the Jenkins xUnit Plugin to find th

Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. Bugs: MES

Re: Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42927/#review116842 --- Ship it! Ship It! - Anand Mazumdar On Jan. 29, 2016, 12:05 a

Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

2016-01-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42928/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. Repositor

Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

2016-01-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42927/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. Repositor

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of `shell.hpp`.

2016-01-28 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/ --- (Updated Jan. 29, 2016, 12:04 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 42921: Fixed flaky MaxCompletedTasksPerFrameworkFlag test.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42921/#review116837 --- Patch looks great! Reviews applied: [42921] Passed command: expo

Re: Review Request 42921: Fixed flaky MaxCompletedTasksPerFrameworkFlag test.

2016-01-28 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42921/ --- (Updated Jan. 28, 2016, 10:56 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 42921: Fixed flaky MaxCompletedTasksPerFrameworkFlag test.

2016-01-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42921/#review116829 --- Looks great, just some minor comments below. src/tests/master_te

Review Request 42921: Fixed flaky MaxCompletedTasksPerFrameworkFlag test.

2016-01-28 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42921/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-4518 h

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/#review116826 --- it's strange that this protobuf is exposed in Mesos API. Similar t

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Anand Mazumdar
> On Jan. 28, 2016, 10:08 p.m., Anand Mazumdar wrote: > > include/mesos/mesos.proto, line 1637 > > > > > > hmmm .. we have generally just used `name` as the field-name at other > > places for specifying the image n

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jie Yu
> On Jan. 28, 2016, 10:08 p.m., Anand Mazumdar wrote: > > include/mesos/mesos.proto, line 1637 > > > > > > hmmm .. we have generally just used `name` as the field-name at other > > places for specifying the image n

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/#review116823 --- include/mesos/mesos.proto (line 1637)

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42554/#review116822 --- Fix it, then Ship it! include/mesos/mesos.proto (line 1640)

Re: Review Request 42773: Added utility function to compute SHA512 digest.

2016-01-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/#review116820 --- src/common/command_utils.hpp (line 68)

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

2016-01-28 Thread Zhitao Li
> On Jan. 15, 2016, 12:03 a.m., Zhitao Li wrote: > > src/docker/docker.cpp, lines 410-420 > > > > > > (Sorry I just got time to come back to this). > > > > I don't exactly understand your suggestion about "a

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116817 --- Patch looks great! Reviews applied: [42914] Passed command: expo

Re: Review Request 42539: Support image specified Entrypoint and Cmd.

2016-01-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42539/ --- (Updated Jan. 28, 2016, 12:28 p.m.) Review request for mesos, Jie Yu and Timoth

Re: Review Request 42901: Fixed a few typos in the HA framework guide.

2016-01-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42901/#review116810 --- Ship it! Thank you! - Vinod Kone On Jan. 28, 2016, 7:26 a.m.

Re: Review Request 40731: Added a fixture to test the floating point precision for CPU resource allocation.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review116809 --- Bad patch! Reviews applied: [40731] Failed command: ./support/ap

Re: Review Request 42915: Check SlaveId when recover Docker containers.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42915/#review116807 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 42841: WIP: Introducing appc image fetcher.

2016-01-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Jan. 28, 2016, 7:10 p.m.) Review request for Jie Yu. Changes ---

Re: Review Request 42810: Added the CgroupInfo protobuf.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42810/#review116805 --- Patch looks great! Reviews applied: [42810] Passed command: expo

Re: Review Request 42773: Added utility function to compute SHA512 digest.

2016-01-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42773/ --- (Updated Jan. 28, 2016, 6:44 p.m.) Review request for mesos. Changes ---

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/ --- (Updated Jan. 28, 2016, 10:17 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 42832: Added a status method to the Isolator interface.

2016-01-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42832/#review116804 --- Ship it! Ship It! - Jie Yu On Jan. 28, 2016, 5:57 p.m., Avin

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 28, 2016, 5:59 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116803 --- Patch looks great! Reviews applied: [42530, 42362] Passed comman

Re: Review Request 40731: Added a fixture to test the floating point precision for CPU resource allocation.

2016-01-28 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 28, 2016, 6 p.m.) Review request for mesos, Bernd Mathiske, Klaus

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
> On Jan. 28, 2016, 5:49 p.m., Alexander Rukletsov wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, lines 1118-1119 > > > > > > I advocate the practice when each block wrapped in curly braces is > > pr

Re: Review Request 42832: Added a status method to the Isolator interface.

2016-01-28 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42832/ --- (Updated Jan. 28, 2016, 5:57 p.m.) Review request for mesos, Jie Yu and Kapil A

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
> On Jan. 28, 2016, 5:49 p.m., Alexander Rukletsov wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, lines 1118-1119 > > > > > > I advocate the practice when each block wrapped in curly braces is > > pr

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116797 --- src/tests/persistent_volume_endpoints_tests.cpp (lines 1118 - 111

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116796 --- docs/fetcher.md (line 122)

Re: Review Request 42915: Check SlaveId when recover Docker containers.

2016-01-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42915/ --- (Updated Jan. 28, 2016, 5:37 p.m.) Review request for mesos. Bugs: MESOS-3573

Review Request 42915: Check SlaveId when recover Docker containers.

2016-01-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42915/ --- Review request for mesos. Bugs: MESOS-3484 https://issues.apache.org/jira/b

Re: Review Request 42810: Added the CgroupInfo protobuf.

2016-01-28 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42810/ --- (Updated Jan. 28, 2016, 5:32 p.m.) Review request for mesos and Jie Yu. Summa

  1   2   >