Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang
> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do yo

Re: Review Request 43144: Added env var to set upper bound on number of worker threads.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review117775 --- I think that this is a duplicate patch with https://reviews.apache

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43149/#review117776 --- It is duplicate with https://reviews.apache.org/r/43144/ - Guangy

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

2016-02-04 Thread Till Toenshoff
> On Jan. 5, 2016, 9:03 a.m., Joerg Schad wrote: > > configure.ac, line 46 > > > > > > General comment: As this adds another tool to our build chain, should > > we have a brief discussion on the dev mailing list? Th

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang
> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do yo

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Andy Pang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/ --- (Updated 二月 4, 2016, 8:56 a.m.) Review request for mesos, BenjaminVW BenjaminVW

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Andy Pang
> On 二月 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do you

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang
> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do yo

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2016-02-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/#review117783 --- Ship it! Ship It! - Till Toenshoff On Jan. 27, 2016, 6:47 p.

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117784 --- src/docker/docker.cpp (line 548)

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang
> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do yo

Review Request 43182: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Andy Pang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43182/ --- Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2016-02-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/#review117786 --- Fix it, then Ship it! Thanks James! There are two minor style n

Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread Andy Pang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43183/ --- Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Reposi

Re: Review Request 43182: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43182/#review117789 --- Ship it! Actually I not sure whether use a var to replace `2` o

Re: Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43183/#review117790 --- Ship it! Please also fill the `Bug` field to `MESOS-4577` in th

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/#review113842 --- Patch looks great! Reviews applied: [41871] Passed command: expo

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117792 --- Bad patch! Reviews applied: [43136] Failed command: ./support/ap

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2016-02-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review117796 --- include/mesos/mesos.proto (lines 643 - 649)

Re: Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43183/#review117797 --- Patch looks great! Reviews applied: [43182, 43183] Passed comman

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2016-02-04 Thread Klaus Ma
> On Feb. 4, 2016, 7:43 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, lines 643-649 > > > > > > This looks like an internal information, the *source* of a revocable > > resource. While we definite

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

2016-02-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43149/#review117805 --- 3rdparty/libprocess/src/process.cpp (line 2204)

Re: Review Request 43144: Added env var to set upper bound on number of worker threads.

2016-02-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review117806 --- 3rdparty/libprocess/src/process.cpp (line 2202)

Re: Review Request 43091: Renamed a variable and updated a comment for clarity.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43091/#review117813 --- src/master/allocator/mesos/hierarchical.cpp (line 182)

Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43118/#review117817 --- Ship it! Ship It! - Guangya Liu On Feb. 3, 2016, 12:39 a.m.,

Re: Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43124/#review117818 --- docs/attributes-resources.md (lines 94 - 96)

Re: Review Request 42911: Removed extra blank line.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42911/#review117819 --- Ship it! Ship It! - Guangya Liu On Jan. 28, 2016, 1:13 p.m.,

Re: Review Request 43105: Ensured the allocator does not double account resources.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/#review117822 --- This case may happen when master is recovering, framework recovery

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

2016-02-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/ --- (Updated Feb. 4, 2016, 3:49 p.m.) Review request for mesos, Joerg Schad, Michae

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

2016-02-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Feb. 4, 2016, 4:46 p.m.) Review request for mesos, Benjamin Bannier, K

Review Request 43193: Fixed parsing docker image env vars.

2016-02-04 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4587 https://issues.apache

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-04 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/ --- (Updated Feb. 4, 2016, 5:07 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review117838 --- Ship it! Ship It! - haosdent huang On Feb. 4, 2016, 5:07 p.m

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

2016-02-04 Thread Jiang Yan Xu
> On Feb. 3, 2016, 5:11 p.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2207-2208 > > > > > > Since we do LOG(WARNING) instead of LOG(FATAL), maybe say the below so > > it's clear that we i

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

2016-02-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43165/#review117841 --- Ship it! Ship It! - Jiang Yan Xu On Feb. 3, 2016, 4:17 p.m.,

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Feb. 4, 2016, 5:39 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Avinash sridharan
> On Feb. 3, 2016, 6:18 p.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, line 379 > > > > > > I would suggest we create smaller tests, each of which test one > > specific part of the code. For int

Re: Review Request 43105: Ensured the allocator does not double account resources.

2016-02-04 Thread Alexander Rukletsov
> On Feb. 4, 2016, 3:46 p.m., Guangya Liu wrote: > > This case may happen when master is recovering, framework recovery start > > before some agent. Can you please add a unit test to cover this code > > change? It could be register framework first, then addslave and check the > > result. Nope

Re: Review Request 43081: Supported entrypoint and cmd in docker runtime isolator.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43081/#review117844 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines

Re: Review Request 43082: Added new flag to command executor for command passing.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43082/#review117847 --- Ship it! Ship It! - Jie Yu On Feb. 3, 2016, 8:42 p.m., Gilbe

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/ --- (Updated Feb. 4, 2016, 6:02 p.m.) Review request for mesos, Guangya Liu and hao

Re: Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

2016-02-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43124/#review117848 --- Fix it, then Ship it! docs/attributes-resources.md (line 181)

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-04 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/ --- (Updated Feb. 4, 2016, 6:07 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review117849 --- Patch looks great! Reviews applied: [43193] Passed command: expo

Re: Review Request 40553: Enable mesos tests installation.

2016-02-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Feb. 4, 2016, 6:14 p.m.) Review request for mesos, Benjamin Bannier an

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Feb. 4, 2016, 6:18 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Abhishek Dasgupta
> On Feb. 3, 2016, 12:04 p.m., haosdent huang wrote: > > src/docker/docker.cpp, line 535 > > > > > > I think need return Error when `version.isError()` version is a Future type and it does not have isError(), So I h

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

2016-02-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/ --- (Updated Feb. 4, 2016, 6:32 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread haosdent huang
> On Feb. 3, 2016, 12:04 p.m., haosdent huang wrote: > > src/docker/docker.cpp, line 535 > > > > > > I think need return Error when `version.isError()` > > Abhishek Dasgupta wrote: > version is a Future type and

Review Request 43203: Added a missing file (`freebsd.hpp`) to stout's Makefile.am

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43203/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

2016-02-04 Thread Neil Conway
> On Feb. 4, 2016, 3:16 p.m., Guangya Liu wrote: > > docs/attributes-resources.md, lines 94-97 > > > > > > why adjust the order here? Made it alphabetical. - Neil -

Re: Review Request 43203: Added a missing file (`freebsd.hpp`) to stout's Makefile.am

2016-02-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43203/#review117855 --- Ship it! Ship It! - Vinod Kone On Feb. 4, 2016, 6:36 p.m., N

Review Request 43198: Added common appc spec utilities.

2016-02-04 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43198/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4596 https://issues.apache

Re: Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43124/ --- (Updated Feb. 4, 2016, 6:40 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42982/ --- (Updated Feb. 4, 2016, 6:41 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43203: Added a missing file (`freebsd.hpp`) to stout's Makefile.am

2016-02-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43203/#review117858 --- Ship it! Ship It! - haosdent huang On Feb. 4, 2016, 6:44 p.m

Re: Review Request 43203: Added a missing file (`freebsd.hpp`) to stout's Makefile.am

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43203/ --- (Updated Feb. 4, 2016, 6:44 p.m.) Review request for mesos and Vinod Kone. Bu

Review Request 43202: Fixed rendering error in quota docs.

2016-02-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43202/ --- Review request for mesos, Joerg Schad and Joris Van Remoortere. Repository: mes

Re: Review Request 42754: Added support for labels to resource reservations.

2016-02-04 Thread Neil Conway
> On Feb. 3, 2016, 8:38 p.m., Joerg Schad wrote: > > src/tests/resources_tests.cpp, line 1756 > > > > > > Isn't this already checked above? Hmm -- where? > On Feb. 3, 2016, 8:38 p.m., Joerg Schad wrote: > > src/t

Re: Review Request 43202: Fixed rendering error in quota docs.

2016-02-04 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43202/#review117859 --- Ship it! Ship It! - Joerg Schad On Feb. 4, 2016, 6:51 p.m.,

Re: Review Request 43081: Supported entrypoint and cmd in docker runtime isolator.

2016-02-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43081/ --- (Updated Feb. 4, 2016, 10:58 a.m.) Review request for mesos, Artem Harutyunyan,

Review Request 43201: Updated reservation documentation.

2016-02-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/ --- Review request for mesos, Neil Conway and Vinod Kone. Bugs: MESOS-4452 http

Review Request 43199: Updated authorization documentation.

2016-02-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/ --- Review request for mesos, Neil Conway and Vinod Kone. Bugs: MESOS-4452 http

Review Request 43200: Updated role documentation.

2016-02-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/ --- Review request for mesos, Neil Conway and Vinod Kone. Bugs: MESOS-4452 http

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-04 Thread Maged Michael
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 4, 2016, 7:09 p.m.) Review request for mesos and Klaus Ma. Summ

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/#review117856 --- src/slave/containerizer/fetcher.cpp (lines 751 - 752)

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

2016-02-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42983/ --- (Updated Feb. 4, 2016, 7:13 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/ --- (Updated Feb. 4, 2016, 7:14 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Shuai Lin
> On Feb. 4, 2016, 7:09 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 751-752 > > > > > > Perhaps you should augment this comment with something like: > > ``` > > The libprocess port i

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/ --- (Updated Feb. 4, 2016, 7:16 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/#review117857 --- src/tests/containerizer/isolator_tests.cpp (lines 374 - 395)

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-04 Thread Maged Michael
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 4, 2016, 7:25 p.m.) Review request for mesos and Klaus Ma. Repo

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-04 Thread Maged Michael
> On Feb. 4, 2016, 1:38 p.m., Klaus Ma wrote: > > 3rdparty/libprocess/src/process.cpp, line 2202 > > > > > > blank line before. Fixed. Updated patch. > On Feb. 4, 2016, 1:38 p.m., Klaus Ma wrote: > > 3rdparty/lib

Re: Review Request 43003: Moved Appc spec proto messages to its own spec file.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43003/#review117869 --- Ship it! Ship It! - Jie Yu On Feb. 4, 2016, 2:52 a.m., Jojy

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/#review117870 --- Ship it! Ship It! - Vinod Kone On Feb. 3, 2016, 10:40 p.m.,

Re: Review Request 40553: Enable mesos tests installation.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review117871 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-02-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- (Updated Feb. 4, 2016, 7:42 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 43199: Updated authorization documentation.

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/#review117865 --- docs/authorization.md (line 78)

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/#review117872 --- src/slave/containerizer/fetcher.cpp (line 756)

Re: Review Request 43200: Updated role documentation.

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review117868 --- docs/roles.md (line 14)

Re: Review Request 43200: Updated role documentation.

2016-02-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/ --- (Updated Feb. 4, 2016, 7:55 p.m.) Review request for mesos, Neil Conway and Vin

Re: Review Request 42557: Moved CachedImage to a separate file.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42557/#review117874 --- Ship it! Ship It! - Jie Yu On Feb. 4, 2016, 2:53 a.m., Jojy

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-04 Thread Maged Michael
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 4, 2016, 7:55 p.m.) Review request for mesos and Klaus Ma. Bugs

Re: Review Request 43199: Updated authorization documentation.

2016-02-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/ --- (Updated Feb. 4, 2016, 7:54 p.m.) Review request for mesos, Neil Conway and Vin

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/#review117877 --- Bad patch! Reviews applied: [42586, 42587, 42588, 43096, 42618]

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/ --- (Updated Feb. 4, 2016, 8:30 p.m.) Review request for mesos, Ben Mahler, Greg Ma

Review Request 43215: Added code to remove a process's endpoint help strings upon termination.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43215/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4552 https://issues.ap

Review Request 43219: Added unit tests for hitting the /help endpoints of a process.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43219/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4552 https://issues.ap

Review Request 43218: Updated the HttpProcess test class for more enhanced testing.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43218/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4552 https://issues.ap

Re: Review Request 42791: Added link to HTTP Endpoints doc in home.md.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42791/ --- (Updated Feb. 4, 2016, 8:38 p.m.) Review request for mesos, Ben Mahler, Greg Ma

Review Request 43221: Updated Rakefile to support subdirectories in /docs folder.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43221/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Bugs: MESOS-3

Review Request 43217: Added ability to return the /help endpoint as a JSON object.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43217/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Bugs: MESOS-3

Review Request 43220: Added script to generate docs from endpoint help strings.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43220/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Bugs: MESOS-3

Review Request 43216: Added json() function for jsonification of the global help process.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43216/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Bugs: MESOS-3

Re: Review Request 42790: Added documentation for all http endpoints.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42790/ --- (Updated Feb. 4, 2016, 8:40 p.m.) Review request for mesos, Ben Mahler, Greg Ma

Re: Review Request 42754: Added support for labels to resource reservations.

2016-02-04 Thread Joerg Schad
> On Feb. 3, 2016, 8:38 p.m., Joerg Schad wrote: > > src/tests/resources_tests.cpp, line 1756 > > > > > > Isn't this already checked above? > > Neil Conway wrote: > Hmm -- where? In the Substraction test case

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Feb. 4, 2016, 9:03 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Avinash sridharan
> On Feb. 4, 2016, 7:21 p.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 374-395 > > > > > > Hum, I don't think this test fixture is needed. Just create > > handleManager in each test. > >

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/#review117882 --- 3rdparty/libprocess/src/help.cpp (line 107)

Review Request 43207: Don't remove IP from the logger's environment.

2016-02-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43207/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs: MESOS-4

  1   2   >